From c68464d1ddeacefcde79c16db7832ad761e336bd Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Tue, 28 Jul 2026 12:20:52 +0200 Subject: [PATCH 1/3] Fix scale bar migration for canvas change --- .../PartSeg/common_gui/napari_image_view.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/package/PartSeg/common_gui/napari_image_view.py b/package/PartSeg/common_gui/napari_image_view.py index bdbce0202..43e1d207f 100644 --- a/package/PartSeg/common_gui/napari_image_view.py +++ b/package/PartSeg/common_gui/napari_image_view.py @@ -42,6 +42,7 @@ _napari_ge_5 = parse_version(napari.__version__) >= parse_version("0.5.0a1") _napari_le_7_0 = parse_version(napari.__version__) <= parse_version("0.7.0") +_napari_gt_8_0 = parse_version(napari.__version__) > parse_version("0.8.0") # if run with numpy<2 on macOS arm64 architecture compiled from pypi wheels # then it will crash with bus error if numpy is used in different thread @@ -232,7 +233,10 @@ def _connect_to_settings(self): self.settings.connect_to_profile("scale_bar_ticks", self._update_scale_bar_ticks) def _update_scale_bar_ticks(self): - self.viewer.scale_bar.ticks = self.settings.get_from_profile("scale_bar_ticks", True) + if _napari_gt_8_0: + self.viewer.canvas.overlays.scale_bar.ticks = self.settings.get_from_profile("scale_bar_ticks", True) + else: + self.viewer.scale_bar.ticks = self.settings.get_from_profile("scale_bar_ticks", True) def toggle_points_visibility(self): if self.points_layer is not None: @@ -950,15 +954,11 @@ def closeEvent(self, event): super().closeEvent(event) def _render(self): - if _napari_ge_5: - return self.canvas._scene_canvas.render() - return self.canvas.render() - - if _napari_ge_5: + return self.canvas._scene_canvas.render() - @property - def view(self): - return self.canvas.view + @property + def view(self): + return self.canvas.view class SearchComponentModal(QtPopup): From 4b0728bb68dfbecc7bf8fe7f80174d2d5cade111 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Tue, 28 Jul 2026 15:41:27 +0200 Subject: [PATCH 2/3] apply suggestions --- package/PartSeg/common_gui/napari_image_view.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/PartSeg/common_gui/napari_image_view.py b/package/PartSeg/common_gui/napari_image_view.py index 43e1d207f..7ea872fd3 100644 --- a/package/PartSeg/common_gui/napari_image_view.py +++ b/package/PartSeg/common_gui/napari_image_view.py @@ -233,10 +233,11 @@ def _connect_to_settings(self): self.settings.connect_to_profile("scale_bar_ticks", self._update_scale_bar_ticks) def _update_scale_bar_ticks(self): + ticks = self.settings.get_from_profile("scale_bar_ticks", True) if _napari_gt_8_0: - self.viewer.canvas.overlays.scale_bar.ticks = self.settings.get_from_profile("scale_bar_ticks", True) + self.viewer.canvas.overlays.scale_bar.ticks = ticks else: - self.viewer.scale_bar.ticks = self.settings.get_from_profile("scale_bar_ticks", True) + self.viewer.scale_bar.ticks = ticks def toggle_points_visibility(self): if self.points_layer is not None: From 9922c6b3598809b2e7e3301e877e6d3f9145bcb8 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Tue, 28 Jul 2026 19:08:39 +0200 Subject: [PATCH 3/3] remove unused variable --- package/PartSeg/common_gui/napari_image_view.py | 1 - 1 file changed, 1 deletion(-) diff --git a/package/PartSeg/common_gui/napari_image_view.py b/package/PartSeg/common_gui/napari_image_view.py index 7ea872fd3..b283245b2 100644 --- a/package/PartSeg/common_gui/napari_image_view.py +++ b/package/PartSeg/common_gui/napari_image_view.py @@ -40,7 +40,6 @@ from vispy.scene import BaseCamera -_napari_ge_5 = parse_version(napari.__version__) >= parse_version("0.5.0a1") _napari_le_7_0 = parse_version(napari.__version__) <= parse_version("0.7.0") _napari_gt_8_0 = parse_version(napari.__version__) > parse_version("0.8.0")