cmsis_iccarm.h lacks of correct prototypes reported by IAR

[PLFSTM]

Hi,

Using IAR 'Required prototype' option set in the IDE, my project compilation fails on the call to the following APIs:

• Error[Pa045]: function "__CLREX" has no prototype
• Error[Pa045]: function "__enable_fault_irq" has no prototype
• Error[Pa045]: function "__disable_fault_irq" has no prototype

Looking at the new introduced code in CMSIS v6.2.0

__IAR_FT void __CLREX() {
  __ASM volatile("CLREX" ::: "memory");
}

#if (defined(__ARM_ARCH_ISA_THUMB) && __ARM_ARCH_ISA_THUMB >= 2)
// This is not really fault_irq on Cortex-not-M. However
// there seems to be code that assumes this.
  __IAR_FT void __disable_fault_irq()
  {
    __ASM volatile ("CPSID F" ::: "memory");
  }

  __IAR_FT void __enable_fault_irq()
  {
    __ASM volatile ("CPSIE F" ::: "memory");
  }
#endif

I note that the void type is missing in the functions declaration. It must be declared as such:

__IAR_FT void __CLREX(void) {
  __ASM volatile("CLREX" ::: "memory");
}

#if (defined(__ARM_ARCH_ISA_THUMB) && __ARM_ARCH_ISA_THUMB >= 2)
// This is not really fault_irq on Cortex-not-M. However
// there seems to be code that assumes this.
  __IAR_FT void __disable_fault_irq(void)
  {
    __ASM volatile ("CPSID F" ::: "memory");
  }

  __IAR_FT void __enable_fault_irq(void)
  {
    __ASM volatile ("CPSIE F" ::: "memory");
  }
#endif

regards
Patrice

[JonatanAntoni]

cc @RobinKastberg

[mhepeyiler]

Merge request is created for fix.

[JonatanAntoni]

Thanks @mhepeyiler.

[PLFSTM]

Thank you for the fix. May I know what is the CMSIS v6.3.0 release plan ?

[JonatanAntoni]

We do not have final release plans, yet. Currently, we have support for Arm China's STAR-MC3 in the works. Once this is done we shall have a release 6.3.0 shipping CMSIS-Core 6.2.0.

If its vital to you, we could discuss having an intermediate patch release 6.2.1 with CMSIS-Core 6.1.2 containing all bug fixes contributed since 6.2.0.

[PLFSTM]

Thanks.
Having an intermediate patch release 6.2.1 with CMSIS-Core 6.1.2 fixing this #264 but also the #246, #252 and #259 bugs will surely provide added-values before you issue support for Arm China's STAR-MC3.