Skip to content
This repository was archived by the owner on Jan 18, 2026. It is now read-only.

Commit 48a21aa

Browse files
author
Erazem Kokot
authored
Lint configure_quick.sh (#880)
Update variable definitions in configure_quick.sh
1 parent bc89bb8 commit 48a21aa

1 file changed

Lines changed: 51 additions & 52 deletions

File tree

‎lib/configure_quick.sh‎

Lines changed: 51 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,105 +1,104 @@
11
#!/usr/bin/env bash
22

33
quick_install() {
4-
5-
case "$install_opt" in
4+
case "${install_opt}" in
65
Anarchy-Desktop) kernel="linux"
76
sh="/usr/bin/zsh"
8-
shrc="$default"
7+
shrc="${default}"
98
bootloader="grub"
109
net_util="networkmanager"
1110
enable_nm=true
1211
multilib=true
1312
dhcp=true
1413
desktop=true
15-
base_install="base-devel linux-headers zsh zsh-syntax-highlighting grub dialog networkmanager wireless_tools wpa_supplicant os-prober $base_defaults "
14+
base_install="base-devel linux-headers zsh zsh-syntax-highlighting grub dialog networkmanager wireless_tools wpa_supplicant os-prober ${base_defaults} "
1615

17-
if "$bluetooth" ; then
16+
if "${bluetooth}" ; then
1817
base_install+="bluez bluez-utils pulseaudio-bluetooth "
1918
enable_bt=true
2019
fi
2120

22-
if "$enable_f2fs" ; then
21+
if "${enable_f2fs}" ; then
2322
base_install+="f2fs-tools "
2423
fi
2524

26-
if "$UEFI" ; then
25+
if "${UEFI}" ; then
2726
base_install+="efibootmgr "
2827
fi
2928

3029
quick_desktop
31-
base_install+="$DE "
30+
base_install+="${DE} "
3231
;;
3332
Anarchy-Desktop-LTS) kernel="linux-lts"
3433
sh="/usr/bin/zsh"
35-
shrc="$default"
34+
shrc="${default}"
3635
bootloader="grub"
3736
net_util="networkmanager"
3837
enable_nm=true
3938
multilib=true
4039
dhcp=true
4140
desktop=true
42-
base_install="base-devel linux-lts linux-lts-headers zsh zsh-syntax-highlighting grub dialog networkmanager wireless_tools wpa_supplicant os-prober $base_defaults "
41+
base_install="base-devel linux-lts linux-lts-headers zsh zsh-syntax-highlighting grub dialog networkmanager wireless_tools wpa_supplicant os-prober ${base_defaults} "
4342

44-
if "$bluetooth" ; then
43+
if "${bluetooth}" ; then
4544
base_install+="bluez bluez-utils pulseaudio-bluetooth "
4645
enable_bt=true
4746
fi
4847

49-
if "$enable_f2fs" ; then
48+
if "${enable_f2fs}" ; then
5049
base_install+="f2fs-tools "
5150
fi
5251

53-
if "$UEFI" ; then
52+
if "${UEFI}" ; then
5453
base_install+="efibootmgr "
5554
fi
5655

5756
quick_desktop
58-
base_install+="$DE "
57+
base_install+="${DE} "
5958
;;
6059
Anarchy-Server) kernel="linux"
6160
sh="/usr/bin/zsh"
62-
shrc="$default"
61+
shrc="${default}"
6362
bootloader="grub"
6463
net_util="networkmanager"
6564
enable_nm=true
6665
multilib=true
6766
dhcp=true
68-
base_install="base-devel openssh linux-headers zsh zsh-syntax-highlighting grub dialog wireless_tools wpa_supplicant os-prober $base_defaults "
67+
base_install="base-devel openssh linux-headers zsh zsh-syntax-highlighting grub dialog wireless_tools wpa_supplicant os-prober ${base_defaults} "
6968

70-
if "$bluetooth" ; then
69+
if "${bluetooth}" ; then
7170
base_install+="bluez bluez-utils pulseaudio-bluetooth "
7271
enable_bt=true
7372
fi
7473

75-
if "$enable_f2fs" ; then
74+
if "${enable_f2fs}" ; then
7675
base_install+="f2fs-tools "
7776
fi
7877

79-
if "$UEFI" ; then
78+
if "${UEFI}" ; then
8079
base_install+="efibootmgr "
8180
fi
8281
;;
8382
Anarchy-Server-LTS) kernel="linux-lts"
8483
sh="/usr/bin/zsh"
85-
shrc="$default"
84+
shrc="${default}"
8685
bootloader="grub"
8786
net_util="networkmanager"
8887
enable_nm=true
8988
multilib=true
9089
dhcp=true
91-
base_install="base-devel openssh linux-lts linux-lts-headers zsh zsh-syntax-highlighting grub dialog wireless_tools wpa_supplicant os-prober $base_defaults "
90+
base_install="base-devel openssh linux-lts linux-lts-headers zsh zsh-syntax-highlighting grub dialog wireless_tools wpa_supplicant os-prober ${base_defaults} "
9291

93-
if "$bluetooth" ; then
92+
if "${bluetooth}" ; then
9493
base_install+="bluez bluez-utils pulseaudio-bluetooth "
9594
enable_bt=true
9695
fi
9796

98-
if "$enable_f2fs" ; then
97+
if "${enable_f2fs}" ; then
9998
base_install+="f2fs-tools "
10099
fi
101100

102-
if "$UEFI" ; then
101+
if "${UEFI}" ; then
103102
base_install+="efibootmgr "
104103
fi
105104
;;
@@ -110,15 +109,15 @@ quick_install() {
110109
quick_desktop() {
111110

112111
while (true) ; do
113-
de=$(dialog --ok-button "$done_msg" --cancel-button "$cancel" --menu "$environment_msg" 14 60 5 \
114-
"Anarchy-budgie" "$de24" \
115-
"Anarchy-cinnamon" "$de23" \
116-
"Anarchy-gnome" "$de22" \
117-
"Anarchy-openbox" "$de18" \
118-
"Anarchy-xfce4" "$de15" 3>&1 1>&2 2>&3)
119-
120-
if [ -z "$de" ]; then
121-
if (dialog --yes-button "$yes" --no-button "$no" --yesno "\n$desktop_cancel_msg" 10 60) then
112+
de=$(dialog --ok-button "${done_msg}" --cancel-button "${cancel}" --menu "${environment_msg}" 14 60 5 \
113+
"Anarchy-budgie" "${de24}" \
114+
"Anarchy-cinnamon" "${de23}" \
115+
"Anarchy-gnome" "${de22}" \
116+
"Anarchy-openbox" "${de18}" \
117+
"Anarchy-xfce4" "${de15}" 3>&1 1>&2 2>&3)
118+
119+
if [ -z "${de}" ]; then
120+
if (dialog --yes-button "${yes}" --no-button "${no}" --yesno "\n${desktop_cancel_msg}" 10 60) then
122121
return
123122
fi
124123
else
@@ -130,34 +129,34 @@ quick_desktop() {
130129
sed -i -e '$a\\n[anarchy-local]\nServer = file:///usr/share/anarchy/pkg\nSigLevel = Never' /etc/pacman.conf
131130
fi
132131

133-
case "$de" in
134-
"Anarchy-xfce4") config_env="$de"
132+
case "${de}" in
133+
"Anarchy-xfce4") config_env="${de}"
135134
start_term="exec startxfce4"
136-
DE+="xfce4 xfce4-goodies $extras "
135+
DE+="xfce4 xfce4-goodies ${extras} "
137136
;;
138-
"Anarchy-budgie") config_env="$de"
137+
"Anarchy-budgie") config_env="${de}"
139138
start_term="export XDG_CURRENT_DESKTOP=Budgie:GNOME ; exec budgie-desktop"
140-
DE+="budgie-desktop mousepad terminator nautilus gnome-backgrounds gnome-control-center $extras "
139+
DE+="budgie-desktop mousepad terminator nautilus gnome-backgrounds gnome-control-center ${extras} "
141140
;;
142-
"Anarchy-cinnamon") config_env="$de"
143-
DE+="cinnamon cinnamon-translations gnome-terminal file-roller p7zip zip unrar terminator $extras "
141+
"Anarchy-cinnamon") config_env="${de}"
142+
DE+="cinnamon cinnamon-translations gnome-terminal file-roller p7zip zip unrar terminator ${extras} "
144143
start_term="exec cinnamon-session"
145144
;;
146-
"Anarchy-gnome") config_env="$de"
145+
"Anarchy-gnome") config_env="${de}"
147146
start_term="exec gnome-session"
148-
DE+="gnome gnome-extra terminator $extras "
147+
DE+="gnome gnome-extra terminator ${extras} "
149148
;;
150-
"Anarchy-openbox") config_env="$de"
149+
"Anarchy-openbox") config_env="${de}"
151150
start_term="exec openbox-session"
152-
DE+="openbox thunar thunar-volman xfce4-terminal xfce4-panel xfce4-whiskermenu-plugin xcompmgr transset-df obconf lxappearance-obconf wmctrl gxmessage xfce4-pulseaudio-plugin xfdesktop xdotool opensnap ristretto oblogout obmenu-generator polkit-gnome $extras "
151+
DE+="openbox thunar thunar-volman xfce4-terminal xfce4-panel xfce4-whiskermenu-plugin xcompmgr transset-df obconf lxappearance-obconf wmctrl gxmessage xfce4-pulseaudio-plugin xfdesktop xdotool opensnap ristretto oblogout obmenu-generator polkit-gnome ${extras} "
153152
;;
154153
esac
155154

156155
while (true) ; do
157-
if "$VM" ; then
158-
case "$virt" in
156+
if "${VM}" ; then
157+
case "${virt}" in
159158
vbox) GPU="virtualbox-guest-utils "
160-
if [ "$kernel" == "linux" ]; then
159+
if [ "${kernel}" == "linux" ]; then
161160
GPU+="virtualbox-guest-modules-arch "
162161
else
163162
GPU+="virtualbox-guest-dkms "
@@ -172,22 +171,22 @@ quick_desktop() {
172171
esac
173172
break
174173
else
175-
GPU="$default_GPU mesa-libgl"
174+
GPU="${default_GPU} mesa-libgl"
176175
break
177176
fi
178177
done
179178

180-
DE+="$GPU xdg-user-dirs xorg-server xorg-apps xorg-xinit xterm ttf-dejavu gvfs gvfs-smb gvfs-mtp pulseaudio pavucontrol pulseaudio-alsa alsa-utils unzip xf86-input-libinput lightdm-gtk-greeter lightdm-gtk-greeter-settings "
179+
DE+="${GPU} xdg-user-dirs xorg-server xorg-apps xorg-xinit xterm ttf-dejavu gvfs gvfs-smb gvfs-mtp pulseaudio pavucontrol pulseaudio-alsa alsa-utils unzip xf86-input-libinput lightdm-gtk-greeter lightdm-gtk-greeter-settings "
181180

182-
if [ "$net_util" == "networkmanager" ] ; then
183-
if (<<<"$DE" grep "plasma" &> /dev/null); then
181+
if [ "${net_util}" == "networkmanager" ] ; then
182+
if (<<<"${DE}" grep "plasma" &> /dev/null); then
184183
DE+="plasma-nm "
185184
else
186185
DE+="network-manager-applet "
187186
fi
188187
fi
189188

190-
if "$enable_bt" ; then
189+
if "${enable_bt}" ; then
191190
DE+="blueman "
192191
fi
193192

0 commit comments

Comments
 (0)