Improve debug logging

Author: Steve Cody

src/main/java/lti/oauth/OAuthFilter.java

@@ -63,7 +63,7 @@ protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res
 		  							, FilterChain fc) throws ServletException, IOException {
 
 	logger.debug("In OAuthFilter");
-    logger.debug(req.getMethod());
+    logger.debug("Method Type: " + req.getMethod());
 
     // Only apply the filter to LTI tool launches (HTTP POSTS)
     // Seems like there would be a way to configure the filter to 
@@ -75,17 +75,21 @@ protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res
       String consumerKey = alphaSortedMap.get(OAuthUtil.CONSUMER_KEY_PARAM);
 
       Tenant tenant = tenantRepository.findByConsumersOauthConsumerKey(consumerKey);
-      
+      logger.debug("consumerKey: " + consumerKey);
 
 
       if (tenant == null) {
+    	logger.debug("tenant was null for consumerKey: " + consumerKey);
         res.sendRedirect("/errorpage");
         return;
       }
 
+      logger.debug("TenantFound: " + tenant.toString());
+      
       Set<Consumer> consumers = tenant.getConsumers();
 
       if (consumers == null || consumers.isEmpty()) {
+    	logger.debug("OAUTH_MISSING_KEY");
         throw new MissingTenantException("OAUTH_MISSING_KEY");
       }
 
@@ -101,6 +105,10 @@ protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res
         logger.error(e.getMessage(), e);
         throw new ServletException("OAUTH_CALCULATION_ERROR");
       }
+      
+      logger.debug("Signature: " + signature);
+      logger.debug("Calculated Signature: " + calculatedSignature);
+      
 
       // retry by switch prefix between https and http
       if (!signature.equals(calculatedSignature)) {
@@ -122,6 +130,9 @@ protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res
 		    logger.error(e.getMessage(), e);
 		    throw new ServletException("OAUTH_CALCULATION_ERROR");
 		}
+		
+	    logger.debug("recalculatedSignature Signature: " + recalculatedSignature);
+		
         if (!signature.equals(recalculatedSignature)) {
             throw new AuthorizationServiceException("OAUTH_SIGNATURE_MISMATCH");
           }

src/main/java/od/ExceptionFilter.java

@@ -42,8 +42,7 @@ public class ExceptionFilter extends OncePerRequestFilter {
   private static final Logger logger = LoggerFactory.getLogger(ExceptionFilter.class);
 
   @Override
-  protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res, FilterChain fc) throws ServletException, IOException {
-    logger.debug("In ExceptionFilter");
+  protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res, FilterChain fc) throws ServletException, IOException {    
 
     try {
       fc.doFilter(req, res);
@@ -58,12 +57,15 @@ protected void doFilterInternal(HttpServletRequest req, HttpServletResponse res,
     catch (MissingCookieException missingCookieException) {
       // getting a little creative with the status code here
       // want to distiguish from unauthorized
+      logger.debug("Missing Cookie Exception", missingCookieException);
       res.sendError(HttpStatus.NOT_ACCEPTABLE.value(), "COOKIE_ERROR");
     }
     catch (AuthorizationServiceException authorizationServiceException) {
+      logger.debug("AuthorizationServiceException", authorizationServiceException);
       res.sendError(HttpStatus.UNAUTHORIZED.value(), "AUTHORIZATION_ERROR");
     }
     catch(Throwable t) {
+      logger.debug("some throwable ", t);
       res.sendError(HttpStatus.INTERNAL_SERVER_ERROR.value(), "GENERAL_ERROR");
     }