Skip to content

Commit 8ad3564

Browse files
committed
feat: optimized code logic
1 parent 9638f3c commit 8ad3564

1 file changed

Lines changed: 20 additions & 19 deletions

File tree

src/Entity/OneRoster.php

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -11,45 +11,46 @@
1111
* @license http://www.osedu.org/licenses/ECL-2.0 ECL-2.0 License
1212
*/
1313

14+
namespace OpenLRW\Entity;
15+
16+
use OpenLRW\ApiClient;
17+
1418
abstract class OneRoster
1519
{
1620

1721
const PREFIX = 'api/';
1822

19-
/**
20-
* Create a header for HTTP Request to OneRoster routes.
21-
*
22-
* @return array
23-
*/
24-
protected function generateHeader()
23+
protected static function generateHeader()
2524
{
25+
$jwt = ApiClient::smartJwt();
26+
2627
return [
2728
'X-Requested-With' => 'XMLHttpRequest',
28-
'Authorization' => 'Bearer ' . ApiClient::makeJWT()
29+
'Authorization' => "Bearer $jwt"
2930
];
3031
}
3132

32-
protected function get($route)
33+
public static function get($route)
3334
{
34-
$header = $this->generateHeader();
35-
return ApiClient::$http->get(self::PREFIX . $route, $header);
35+
$header = self::generateHeader();
36+
return ApiClient::httpGet(self::PREFIX . $route, $header);
3637
}
3738

38-
protected function post($route, $data)
39+
public static function post($route, $data)
3940
{
40-
$header = $this->generateHeader();
41-
return ApiClient::$http->post(self::PREFIX . $route, $header, $data);
41+
$header = self::generateHeader();
42+
return ApiClient::httpPost(self::PREFIX . $route, $header, $data);
4243
}
4344

44-
protected function patch($route, $data)
45+
public static function patch($route, $data)
4546
{
46-
$header = $this->generateHeader();
47-
return ApiClient::$http->patch(self::PREFIX . $route, $header, $data);
47+
$header = self::generateHeader();
48+
return ApiClient::httpPatch(self::PREFIX . $route, $header, $data);
4849
}
4950

50-
protected function delete($route)
51+
public static function delete($route)
5152
{
52-
$header = $this->generateHeader();
53-
return ApiClient::$http->delete(self::PREFIX . $route, $header);
53+
$header = self::generateHeader();
54+
return ApiClient::httpDelete(self::PREFIX . $route, $header);
5455
}
5556
}

0 commit comments

Comments
 (0)