From 94e97aaaebc98fb615364a46aa400730e558d6d0 Mon Sep 17 00:00:00 2001 From: FalloutFalcon Date: Tue, 15 Sep 2026 16:13:27 -0500 Subject: [PATCH 1/2] theory crafting --- code/__DEFINES/~darkpack/guestbook.dm | 2 +- code/__HELPERS/stack_trace.dm | 2 +- .../modules/guestbook/code/human_helpers.dm | 11 +++++++++++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/code/__DEFINES/~darkpack/guestbook.dm b/code/__DEFINES/~darkpack/guestbook.dm index 6671f15ce3af..066fb147ce2b 100644 --- a/code/__DEFINES/~darkpack/guestbook.dm +++ b/code/__DEFINES/~darkpack/guestbook.dm @@ -9,6 +9,6 @@ #define GUESTBOOK_FORGETMENOT (1 << 3) /// Differs from GET_GUESTBOOK_NAME_TRUE as it returns the known name OR the whole mob for situations where we directly embed into a string for text macros. -#define GET_GUESTBOOK_NAME(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest) +#define GET_GUESTBOOK_NAME(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest.name) /// Macro to get a STRING (never a mob) of the name we refer to them as. #define GET_GUESTBOOK_NAME_TRUE(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest.name) diff --git a/code/__HELPERS/stack_trace.dm b/code/__HELPERS/stack_trace.dm index 6cb79064e0e8..bc26eb0a0295 100644 --- a/code/__HELPERS/stack_trace.dm +++ b/code/__HELPERS/stack_trace.dm @@ -7,7 +7,7 @@ /// Returns an ordered list of all our parent procs, highest to deepest. /// /// introspection like this is mostly useful for debugging, if you have another use I suspect you are just creating god's strongest footgun and should rethink things -/proc/dump_stack(max_depth = STACK_DEPTH_SEARCH_LIMIT) +/proc/dump_stack(max_depth = STACK_DEPTH_SEARCH_LIMIT) as /list // DARKPACK EDIT CHANGE var/list/proc_paths = list() var/crashed = FALSE var/depth = 0 diff --git a/modular_darkpack/modules/guestbook/code/human_helpers.dm b/modular_darkpack/modules/guestbook/code/human_helpers.dm index e9dca2231713..033cf8dc2560 100644 --- a/modular_darkpack/modules/guestbook/code/human_helpers.dm +++ b/modular_darkpack/modules/guestbook/code/human_helpers.dm @@ -44,3 +44,14 @@ if(prefixed) final_string = "\A [final_string]" return lowercase ? LOWER_TEXT(final_string) : final_string + +GLOBAL_LIST_EMPTY(living_ref_stacktraces) +/mob/living/proc/operator""() + var/dump = jointext(dump_stack(3), ": ") + if(GLOB.living_ref_stacktraces[dump]) + GLOB.living_ref_stacktraces[dump]++ + else + GLOB.living_ref_stacktraces[dump] = 1 + logger.Log(LOG_CATEGORY_DEBUG, "Operator Test: [dump]") + return usr?.mind?.guestbook?.get_known_name(usr, src) || name + From 4d3b44c0930c46b865e55e63f62d0ee22727b11a Mon Sep 17 00:00:00 2001 From: FalloutFalcon Date: Tue, 15 Sep 2026 19:01:31 -0500 Subject: [PATCH 2/2] tweak --- modular_darkpack/modules/guestbook/code/human_helpers.dm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modular_darkpack/modules/guestbook/code/human_helpers.dm b/modular_darkpack/modules/guestbook/code/human_helpers.dm index 033cf8dc2560..f3abc31fa56e 100644 --- a/modular_darkpack/modules/guestbook/code/human_helpers.dm +++ b/modular_darkpack/modules/guestbook/code/human_helpers.dm @@ -47,11 +47,12 @@ GLOBAL_LIST_EMPTY(living_ref_stacktraces) /mob/living/proc/operator""() - var/dump = jointext(dump_stack(3), ": ") + var/dump = jointext(dump_stack(1), ": ") if(GLOB.living_ref_stacktraces[dump]) GLOB.living_ref_stacktraces[dump]++ else GLOB.living_ref_stacktraces[dump] = 1 + sortTim(GLOB.living_ref_stacktraces, GLOBAL_PROC_REF(cmp_numeric_dsc), associative = TRUE) logger.Log(LOG_CATEGORY_DEBUG, "Operator Test: [dump]") return usr?.mind?.guestbook?.get_known_name(usr, src) || name