Skip to content

Commit 42c37a0

Browse files
committed
fix tests
1 parent 1650684 commit 42c37a0

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/requestTracing/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) Microsoft Corporation.
22
// Licensed under the MIT license.
33

4-
import { OperationOptions } from "@azure/core-client";
4+
import { OperationOptions } from "@azure-rest/core-client";
55
import { AzureAppConfigurationOptions } from "../appConfigurationOptions.js";
66
import { FeatureFlagTracingOptions } from "./featureFlagTracingOptions.js";
77
import { AIConfigurationTracingOptions } from "./aiConfigurationTracingOptions.js";
@@ -57,8 +57,8 @@ export function applyRequestTracing<T extends OperationOptions>(requestTracingOp
5757
if (requestTracingOptions.enabled) {
5858
actualOptions.requestOptions = {
5959
...actualOptions.requestOptions,
60-
customHeaders: {
61-
...actualOptions.requestOptions?.customHeaders,
60+
headers: {
61+
...actualOptions.requestOptions?.headers,
6262
[CORRELATION_CONTEXT_HEADER_NAME]: createCorrelationContextHeader(requestTracingOptions)
6363
}
6464
};

test/afd.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe("loadFromAzureFrontDoor", function() {
9797
userAgent = headerPolicy.headers.get("User-Agent");
9898
}
9999

100-
expect(userAgent).satisfy((ua: string) => ua.startsWith("javascript-appconfiguration-provider"));
100+
expect(userAgent).satisfy((ua: string) => ua.includes("javascript-appconfiguration-provider"));
101101
expect(headerPolicy.headers.get("Authorization")).to.be.undefined;
102102
expect(headerPolicy.headers.get("Sync-Token")).to.be.undefined;
103103
});

test/requestTracing.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe("request tracing", function () {
5353
userAgent = headerPolicy.headers.get("User-Agent");
5454
}
5555

56-
expect(userAgent).satisfy((ua: string) => ua.startsWith("javascript-appconfiguration-provider"));
56+
expect(userAgent).satisfy((ua: string) => ua.includes("javascript-appconfiguration-provider"));
5757
});
5858

5959
it("should have request type in correlation-context header", async () => {
@@ -131,7 +131,7 @@ describe("request tracing", function () {
131131
});
132132
} catch { /* empty */ }
133133
expect(headerPolicy.headers).not.undefined;
134-
expect(headerPolicy.headers.get("User-Agent")).satisfy((ua: string) => ua.startsWith("javascript-appconfiguration-provider"));
134+
expect(headerPolicy.headers.get("User-Agent")).satisfy((ua: string) => ua.includes("javascript-appconfiguration-provider"));
135135
const correlationContext = headerPolicy.headers.get("Correlation-Context");
136136
expect(correlationContext).not.undefined;
137137
expect(correlationContext.includes("AFD")).eq(true);
@@ -246,7 +246,7 @@ describe("request tracing", function () {
246246
it("should have filter type in correlation-context header if feature flags use feature filters", async () => {
247247
let correlationContext: string = "";
248248
const listKvCallback = (listOptions) => {
249-
correlationContext = listOptions?.requestOptions?.customHeaders[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
249+
correlationContext = listOptions?.requestOptions?.headers?.[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
250250
};
251251

252252
mockAppConfigurationClientListConfigurationSettings([[
@@ -284,7 +284,7 @@ describe("request tracing", function () {
284284
it("should have max variants in correlation-context header if feature flags use variants", async () => {
285285
let correlationContext: string = "";
286286
const listKvCallback = (listOptions) => {
287-
correlationContext = listOptions?.requestOptions?.customHeaders[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
287+
correlationContext = listOptions?.requestOptions?.headers?.[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
288288
};
289289

290290
mockAppConfigurationClientListConfigurationSettings([[
@@ -322,7 +322,7 @@ describe("request tracing", function () {
322322
it("should have telemety tag in correlation-context header if feature flags enable telemetry", async () => {
323323
let correlationContext: string = "";
324324
const listKvCallback = (listOptions) => {
325-
correlationContext = listOptions?.requestOptions?.customHeaders[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
325+
correlationContext = listOptions?.requestOptions?.headers?.[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
326326
};
327327

328328
mockAppConfigurationClientListConfigurationSettings([[
@@ -358,7 +358,7 @@ describe("request tracing", function () {
358358
it("should have seed tag in correlation-context header if feature flags use allocation seed", async () => {
359359
let correlationContext: string = "";
360360
const listKvCallback = (listOptions) => {
361-
correlationContext = listOptions?.requestOptions?.customHeaders[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
361+
correlationContext = listOptions?.requestOptions?.headers?.[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
362362
};
363363

364364
mockAppConfigurationClientListConfigurationSettings([[
@@ -395,7 +395,7 @@ describe("request tracing", function () {
395395
it("should have AI tag in correlation-context header if key values use AI configuration", async () => {
396396
let correlationContext: string = "";
397397
const listKvCallback = (listOptions) => {
398-
correlationContext = listOptions?.requestOptions?.customHeaders[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
398+
correlationContext = listOptions?.requestOptions?.headers?.[CORRELATION_CONTEXT_HEADER_NAME] ?? "";
399399
};
400400

401401
mockAppConfigurationClientListConfigurationSettings([[

0 commit comments

Comments
 (0)