Currently, ANY "MUST FIX" comment (human, AI or diagnostic) causes API approval to be blocked. However, Diagnostics are passed in by the parser and cannot be changed or resolved through the UI. The only way to fix them is by fixing the issue in the underlying code, using the parser's suppression mechanism (if it has one) or fixing the offending diagnostic rule.
Because diagnostics have long been ignored, this has created the situation where APIs exist today with long-standing MUST FIX diagnostics in place, and this causes problems when it comes time for a new approval.
Plan
- Temporarily exclude diagnostics from the "MUST FIX" rule that disables approvals.
- Add a pop-up warning when an API with MUST FIX diagnostics is approved that this will soon not be allowed and they need to address these issues in their code or parser.
- Include the date when this feature will be turned on.
This gives language teams time to address these issues while unblocking them in the near term.
Currently, ANY "MUST FIX" comment (human, AI or diagnostic) causes API approval to be blocked. However, Diagnostics are passed in by the parser and cannot be changed or resolved through the UI. The only way to fix them is by fixing the issue in the underlying code, using the parser's suppression mechanism (if it has one) or fixing the offending diagnostic rule.
Because diagnostics have long been ignored, this has created the situation where APIs exist today with long-standing MUST FIX diagnostics in place, and this causes problems when it comes time for a new approval.
Plan
This gives language teams time to address these issues while unblocking them in the near term.