test: parameterize unwrapEscapedQuotes scenarios

Refactor duplicate UnwrapEscapedQuotes execute tests into a MethodSource-based parameterized test and keep the case provider in the helper section for maintainability.

Made-with: Cursor

Author: AnjBB72

boat-scaffold/src/test/java/com/backbase/oss/codegen/java/BoatSpringCodeGenTests.java

@@ -49,14 +49,17 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang.UnhandledException;
 import org.hamcrest.Matchers;
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.openapitools.codegen.CliOption;
 import org.openapitools.codegen.ClientOptInput;
 import org.openapitools.codegen.CodegenOperation;
@@ -98,56 +101,18 @@ void newLineIndent() throws IOException {
         assertThat(output.toString(), equalTo(String.format("__%n__Good%n__  morning,%n__ Dave%n")));
     }
 
-    @Test
-    void unwrapEscapedQuotes_withNullInput_shouldWriteNothing() throws IOException {
-        final BoatSpringCodeGen.UnwrapEscapedQuotes lambda = new BoatSpringCodeGen.UnwrapEscapedQuotes();
-        final StringWriter output = new StringWriter();
-        final Fragment frag = mock(Fragment.class);
-
-        when(frag.execute()).thenReturn(null);
-
-        lambda.execute(frag, output);
-
-        assertThat(output.toString(), equalTo(""));
-    }
-
-    @Test
-    void unwrapEscapedQuotes_withWrappedEscapedQuotes_shouldRemoveOuterEscapedQuotes() throws IOException {
-        final BoatSpringCodeGen.UnwrapEscapedQuotes lambda = new BoatSpringCodeGen.UnwrapEscapedQuotes();
-        final StringWriter output = new StringWriter();
-        final Fragment frag = mock(Fragment.class);
-
-        when(frag.execute()).thenReturn("\\\"{\\\"message\\\":\\\"Bad Request\\\"}\\\"");
-
-        lambda.execute(frag, output);
-
-        assertThat(output.toString(), equalTo("{\\\"message\\\":\\\"Bad Request\\\"}"));
-    }
-
-    @Test
-    void unwrapEscapedQuotes_withDoubleEscapedQuotesAndNoWrapper_shouldOnlyNormalize() throws IOException {
-        final BoatSpringCodeGen.UnwrapEscapedQuotes lambda = new BoatSpringCodeGen.UnwrapEscapedQuotes();
-        final StringWriter output = new StringWriter();
-        final Fragment frag = mock(Fragment.class);
-
-        when(frag.execute()).thenReturn("prefix\\\\\"quoted\\\\\"suffix");
-
-        lambda.execute(frag, output);
-
-        assertThat(output.toString(), equalTo("prefix\\\"quoted\\\"suffix"));
-    }
-
-    @Test
-    void unwrapEscapedQuotes_withShortEscapedQuoteToken_shouldNotUnwrap() throws IOException {
+    @ParameterizedTest
+    @MethodSource("unwrapEscapedQuotesCases")
+    void unwrapEscapedQuotes_execute_shouldHandleAllScenarios(String input, String expectedOutput) throws IOException {
         final BoatSpringCodeGen.UnwrapEscapedQuotes lambda = new BoatSpringCodeGen.UnwrapEscapedQuotes();
         final StringWriter output = new StringWriter();
         final Fragment frag = mock(Fragment.class);
 
-        when(frag.execute()).thenReturn("\\\"");
+        when(frag.execute()).thenReturn(input);
 
         lambda.execute(frag, output);
 
-        assertThat(output.toString(), equalTo("\\\""));
+        assertThat(output.toString(), equalTo(expectedOutput));
     }
 
     @Test
@@ -644,4 +609,12 @@ private static void assertMethodCollectionReturnType(MethodDeclaration method, S
             .getTypeArguments().get().getFirst().get();
         assertEquals(itemType, collectionItemType.getName().toString());
     }
+
+    static Stream<Arguments> unwrapEscapedQuotesCases() {
+        return Stream.of(
+                Arguments.of((String) null, ""),
+                Arguments.of("\\\"{\\\"message\\\":\\\"Bad Request\\\"}\\\"", "{\\\"message\\\":\\\"Bad Request\\\"}"),
+                Arguments.of("prefix\\\\\"quoted\\\\\"suffix", "prefix\\\"quoted\\\"suffix"),
+                Arguments.of("\\\"", "\\\""));
+    }
 }