Skip to content

Commit 6d7a046

Browse files
authored
Merge pull request #15 from bcgsc/remove_ntedit_submodule
Remove ntEdit submodule
2 parents d089003 + 5f43d74 commit 6d7a046

8 files changed

Lines changed: 9 additions & 52 deletions

File tree

β€Ž.gitmodulesβ€Ž

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +0,0 @@
1-
[submodule "subprojects/ntEdit"]
2-
path = subprojects/ntEdit
3-
url = https://github.com/bcgsc/ntEdit.git

β€ŽREADME.mdβ€Ž

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,24 +37,16 @@ conda install -c bioconda -c conda-forge ntroot
3737

3838
Installing ntRoot from the source code:
3939
```
40-
git clone --recurse-submodules https://github.com/bcgsc/ntRoot.git
40+
git clone https://github.com/bcgsc/ntRoot.git
4141
cd ntRoot
42-
meson setup build --prefix=/path/to/install/directory
43-
cd build
44-
ninja install
4542
```
46-
ntRoot and all required scripts will be installed to: /path/to/install/directory
43+
No compilation is required for ntRoot (only the dependencies), so simply add the ntRoot repository to your PATH.
4744

4845
### Dependencies <a name=dependencies></a>
4946
- python 3.9+
5047
- perl
51-
- [meson](https://mesonbuild.com/)
52-
- [ninja](https://ninja-build.org/)
48+
- [ntEdit 2.0.1+](https://github.com/bcgsc/ntEdit)
5349
- [snakemake](https://snakemake.readthedocs.io/en/stable/)
54-
- [btllib](https://github.com/bcgsc/btllib)
55-
- [boost](https://www.boost.org/doc/libs/1_61_0/more/getting_started/unix-variants.html)
56-
- [ntCard](https://github.com/bcgsc/ntCard)
57-
- [ntHits](https://github.com/bcgsc/ntHits)
5850
- [samtools](https://www.htslib.org/)
5951

6052

β€Žazure-pipelines.ymlβ€Ž

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,12 @@ jobs:
1919
- script: |
2020
source activate ntroot_CI
2121
conda install --yes --name ntroot_CI -c conda-forge -c bioconda python=3.9 mamba
22-
mamba install --yes -c conda-forge -c bioconda meson ninja snakemake perl btllib compilers boost-cpp ntcard nthits
22+
mamba install --yes -c conda-forge -c bioconda meson ninja snakemake perl 'ntedit>=2.0.1' samtools
2323
displayName: Install Conda packages
2424
2525
- script: |
2626
source activate ntroot_CI
27-
meson setup build --prefix=$(pwd)/test_build
28-
cd build
29-
ninja install
30-
displayName: Compile ntRoot
31-
32-
- script: |
33-
source activate ntroot_CI
34-
export PATH=$(pwd)/test_build/bin:$PATH
27+
export PATH=$(pwd):$PATH
3528
which ntroot
3629
cd demo
3730
./run_ntroot_demo.sh
@@ -55,19 +48,12 @@ jobs:
5548
- script: |
5649
source activate ntroot_CI
5750
conda install --yes --name ntroot_CI -c conda-forge -c bioconda python=3.9 mamba
58-
mamba install --yes -c conda-forge -c bioconda meson ninja snakemake perl btllib compilers boost-cpp ntcard nthits
51+
mamba install --yes -c conda-forge -c bioconda snakemake perl 'ntedit>=2.0.1' samtools
5952
displayName: Install Conda packages
6053
6154
- script: |
6255
source activate ntroot_CI
63-
meson setup build --prefix=$(pwd)/test_build
64-
cd build
65-
ninja install
66-
displayName: Compile ntRoot
67-
68-
- script: |
69-
source activate ntroot_CI
70-
export PATH=$(pwd)/test_build/bin:$PATH
56+
export PATH=$(pwd):$PATH
7157
which ntroot
7258
cd demo
7359
./run_ntroot_demo.sh

β€Žbin/meson.buildβ€Ž

Lines changed: 0 additions & 5 deletions
This file was deleted.

β€Žmeson.buildβ€Ž

Lines changed: 0 additions & 12 deletions
This file was deleted.

β€Žntroot_run_pipeline.smkβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ rule ntedit_reads:
6464
params = f"-k {k} -t {t} -z {z} -j {j} -Y {Y} --solid ",
6565
vcf_input = f"-l {l}" if l else ""
6666
shell:
67-
"{params.benchmark} run-ntedit snv --draft {reference} --reads {reads_prefix} {params.params} "
67+
"{params.benchmark} run-ntedit snv --reference {reference} --reads {reads_prefix} {params.params} "
6868
"{params.vcf_input}"
6969

7070
rule ntedit_genome:
@@ -81,7 +81,7 @@ rule ntedit_genome:
8181
params = f"-k {k} -t {t} -z {z} -j {j} -Y {Y}",
8282
vcf_input = f"-l {l}" if l else ""
8383
shell:
84-
"{params.benchmark} run-ntedit snv --draft {reference} --genome {input.genomes} {params.params} "
84+
"{params.benchmark} run-ntedit snv --reference {reference} --genome {input.genomes} {params.params} "
8585
" {params.vcf_input}"
8686

8787
rule samtools_faidx:

β€Žsubprojects/ntEditβ€Ž

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
Β (0)