drop http client pool

Author: BitPatty

Readme.md

@@ -27,8 +27,6 @@ The client supports synchronous and asynchronous GET requests on the following e
 
 Authentication via HTTP is supported to update user profiles. POST/PUT requests on other endpoints are not possible, since users are missing the required privileges.
 
-The client also supports a user defined number of HTTP clients. Using a pool size of > 10 is not recommended.
-
 ---
 
 ## Requirements

SRLApiClient/Endpoints/Countries/CountriesClient.cs

@@ -2,7 +2,6 @@
 using System.Collections.ObjectModel;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.Countries
 {

SRLApiClient/Endpoints/Games/GamesClient.cs

@@ -3,7 +3,6 @@
 using System.Collections.ObjectModel;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.Games
 {
@@ -65,7 +64,7 @@ private sealed class GameCollection : SRLData
     /// <returns>Returns a list of games matching the search query</returns>
     public ReadOnlyCollection<Game> Search(string name)
     {
-      if (String.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
       GameCollection gs = SrlClient.Get<GameCollection>($"{BasePath}?search={name.ToLower()}");
       return gs?.Games?.AsReadOnly();
     }
@@ -77,7 +76,7 @@ public ReadOnlyCollection<Game> Search(string name)
     /// <returns>Returns a list of games matching the search query</returns>
     public async Task<ReadOnlyCollection<Game>> SearchAsync(string name)
     {
-      if (String.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
       GameCollection gs = await SrlClient.GetAsync<GameCollection>($"{BasePath}?search={name.ToLower()}").ConfigureAwait(false);
       return gs?.Games?.AsReadOnly();
     }
@@ -110,7 +109,7 @@ public string GetRules(Game g)
     /// <returns>Returns the rules string</returns>
     public string GetRules(string gameAbbreviation)
     {
-      if (String.IsNullOrWhiteSpace(gameAbbreviation)) throw new ArgumentException(nameof(gameAbbreviation), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(gameAbbreviation)) throw new ArgumentException(nameof(gameAbbreviation), "Parameter can't be empty");
       return SrlClient.Get<GameRules>($"/rules/{gameAbbreviation}")?.Rules;
     }
 
@@ -129,7 +128,7 @@ public async Task<string> GetRulesAsync(Game g)
     /// <returns>Returns the rules string</returns>
     public async Task<string> GetRulesAsync(string gameAbbreviation)
     {
-      if (String.IsNullOrWhiteSpace(gameAbbreviation)) throw new ArgumentException(nameof(gameAbbreviation), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(gameAbbreviation)) throw new ArgumentException(nameof(gameAbbreviation), "Parameter can't be empty");
       return (await SrlClient.GetAsync<GameRules>($"/rules/{gameAbbreviation}").ConfigureAwait(false))?.Rules;
     }
   }

SRLApiClient/Endpoints/Leaderboards/LeaderboardsClient.cs

@@ -1,5 +1,4 @@
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.Leaderboards
 {

SRLApiClient/Endpoints/PastRaces/PastRacesClient.cs

@@ -4,7 +4,6 @@
 using System.Linq;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.PastRaces
 {
@@ -42,8 +41,8 @@ public ReadOnlyCollection<PastRace> Get(string playerName = null, string gameAbb
       if (page < 1) throw new ArgumentException(nameof(page), "Parameter must be 1 or greater");
       if (pageSize < 1) throw new ArgumentException(nameof(pageSize), "Parameter must be 1 or greater");
 
-      string playerFilter = !String.IsNullOrWhiteSpace(playerName) ? $"&player={playerName}" : "";
-      string gameFilter = !String.IsNullOrWhiteSpace(gameAbbreviation) ? $"&game={gameAbbreviation}" : "";
+      string playerFilter = !string.IsNullOrWhiteSpace(playerName) ? $"&player={playerName}" : "";
+      string gameFilter = !string.IsNullOrWhiteSpace(gameAbbreviation) ? $"&game={gameAbbreviation}" : "";
 
       return SrlClient.Get<PastRacesCollection>($"{BasePath}?page={page}&pageSize={pageSize}{playerFilter}{gameFilter}")?.Races?.AsReadOnly();
     }
@@ -61,8 +60,8 @@ public async Task<ReadOnlyCollection<PastRace>> GetAsync(string playerName = nul
       if (page < 1) throw new ArgumentException(nameof(page), "Parameter must be 1 or greater");
       if (pageSize < 1) throw new ArgumentException(nameof(pageSize), "Parameter must be 1 or greater");
 
-      string playerFilter = !String.IsNullOrWhiteSpace(playerName) ? $"&player={playerName}" : "";
-      string gameFilter = !String.IsNullOrWhiteSpace(gameAbbreviation) ? $"&game={gameAbbreviation}" : "";
+      string playerFilter = !string.IsNullOrWhiteSpace(playerName) ? $"&player={playerName}" : "";
+      string gameFilter = !string.IsNullOrWhiteSpace(gameAbbreviation) ? $"&game={gameAbbreviation}" : "";
 
       return (await SrlClient.GetAsync<PastRacesCollection>($"{BasePath}?page={page}&pageSize={pageSize}{playerFilter}{gameFilter}").ConfigureAwait(false))?.Races?.AsReadOnly();
     }
@@ -74,7 +73,7 @@ public async Task<ReadOnlyCollection<PastRace>> GetAsync(string playerName = nul
     /// <returns>Returns the past race</returns>
     public PastRace Get(string raceId)
     {
-      if (String.IsNullOrWhiteSpace(raceId)) throw new ArgumentException(nameof(raceId), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(raceId)) throw new ArgumentException(nameof(raceId), "Parameter can't be empty");
       return SrlClient.Get<PastRacesCollection>($"{BasePath}/{raceId.ToLower()}")?.Races?.FirstOrDefault();
     }
 
@@ -85,7 +84,7 @@ public PastRace Get(string raceId)
     /// <returns>Returns the past race</returns>
     public async Task<PastRace> GetAsync(string raceId)
     {
-      if (String.IsNullOrWhiteSpace(raceId)) throw new ArgumentException(nameof(raceId), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(raceId)) throw new ArgumentException(nameof(raceId), "Parameter can't be empty");
       return (await SrlClient.GetAsync<PastRacesCollection>($"{BasePath}/{raceId.ToLower()}").ConfigureAwait(false))?.Races?.FirstOrDefault();
     }
   }

SRLApiClient/Endpoints/Players/PlayersClient.cs

@@ -3,7 +3,6 @@
 using System.Collections.ObjectModel;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 using SRLApiClient.User;
 
 namespace SRLApiClient.Endpoints.Players
@@ -51,7 +50,7 @@ private sealed class PlayerSearch : SRLData
     /// <returns>List of players matching the queried name</returns>
     public ReadOnlyCollection<Player> Search(string name)
     {
-      if (String.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
       return SrlClient.Get<PlayerSearch>($"{BasePath}?search={name.ToLower()}")?.Players?.AsReadOnly();
     }
 
@@ -62,7 +61,7 @@ public ReadOnlyCollection<Player> Search(string name)
     /// <returns>List of players matching the queried name</returns>
     public async Task<ReadOnlyCollection<Player>> SearchAsync(string name)
     {
-      if (String.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
+      if (string.IsNullOrWhiteSpace(name)) throw new ArgumentException(nameof(name), "Parameter can't be empty");
       return (await SrlClient.GetAsync<PlayerSearch>($"{BasePath}?search={name.ToLower()}").ConfigureAwait(false))?.Players?.AsReadOnly();
     }
 

SRLApiClient/Endpoints/Races/RacesClient.cs

@@ -2,7 +2,6 @@
 using System.Collections.ObjectModel;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.Races
 {

SRLApiClient/Endpoints/SRLData.cs

@@ -18,8 +18,6 @@ public class SRLData
 
     [OnDeserialized()]
     private void SetTimeStamp(StreamingContext context)
-    {
-      Deserialized = DateTime.Now;
-    }
+      => Deserialized = DateTime.Now;
   }
 }

SRLApiClient/Endpoints/Stats/StatsClient.cs

@@ -3,7 +3,6 @@
 using System.Collections.ObjectModel;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using SRLApiClient.Exceptions;
 
 namespace SRLApiClient.Endpoints.Stats
 {

SRLApiClient/Exceptions/SRLParseException.cs

@@ -7,9 +7,20 @@ namespace SRLApiClient.Exceptions
 {
   public class SRLParseException : Exception
   {
-    public SRLParseException() { }
-    public SRLParseException(string message) : base(message) { }
-    public SRLParseException(string message, Exception inner) : base(message, inner) { }
-    protected SRLParseException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+    public SRLParseException()
+    {
+    }
+
+    public SRLParseException(string message) : base(message)
+    {
+    }
+
+    public SRLParseException(string message, Exception inner) : base(message, inner)
+    {
+    }
+
+    protected SRLParseException(SerializationInfo info, StreamingContext context) : base(info, context)
+    {
+    }
   }
 }