Skip to content

Commit 684e65a

Browse files
committed
Use call instead of bind where possible
1 parent cb00dc1 commit 684e65a

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/gui/list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ modmanager.gui.MenuList = sc.ListTabbedPane.extend({
234234

235235
list.clear()
236236
buttonGroup.clear()
237-
this.tabz[this.currentTabIndex].populateFunc.bind(this)(list, buttonGroup, this.currentSort)
237+
this.tabz[this.currentTabIndex].populateFunc.call(this, list, buttonGroup, this.currentSort)
238238
},
239239
addObservers() {
240240
sc.Model.addObserver(sc.menu, this)

src/gui/multipage-button-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ modmanager.gui.MultiPageButtonBoxGui = sc.MultiPageBoxGui.extend({
103103

104104
const negativeScrollContainerHeight = this.buttonConfigs ? 12 : 0
105105
sc.HelpScrollContainer.prototype.setSize = function (this: sc.HelpScrollContainer) {
106-
backup.bind(this)(width + 1, height - 34 - negativeScrollContainerHeight)
106+
backup.call(this, width + 1, height - 34 - negativeScrollContainerHeight)
107107
}
108108
this.parent(width)
109109
sc.HelpScrollContainer.prototype.setSize = backup

src/gui/options/option-elements-inject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ modmanager.gui.OptionsObjectSlider = ig.GuiElementBase.extend({
9696

9797
const func = this.base.guiOption.customNumberDisplay
9898
if (func) {
99-
let ret = func.bind(this.base.guiOption)(this._lastVal)
99+
let ret = func.call(this.base.guiOption, this._lastVal)
100100
if (typeof ret == 'number') {
101101
ret = ret.round(3)
102102
}
@@ -254,7 +254,7 @@ sc.OPTION_GUIS[sc.OPTION_TYPES.CONTROLS].inject({
254254
// @ts-expect-error
255255
ig.lang.get = (path: string, ...args) => {
256256
if (!(optionRow instanceof modmanager.gui.OptionsOptionRow)) throw new Error('what')
257-
if (path == 'sc.gui.options.controls.none') return backup_ig_lang_get.bind(ig.lang)(path, ...args)
257+
if (path == 'sc.gui.options.controls.none') return backup_ig_lang_get.call(ig.lang, path, ...args)
258258
if (path == 'sc.gui.options.controls.description') return optionRow.guiOption.description
259259
if (path.startsWith('sc.gui.options.controls.keys.')) return optionRow.guiOption.name
260260
throw new Error('what')

src/mod-options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ function registerAndGetModOptions<T extends Options>(settings: ModOptionsSetting
367367
const str = typeof v === 'object' ? JSON.stringify(v) : v.toString()
368368
localStorage.setItem(id, str)
369369
if (!noEvent && 'changeEvent' in option && option.changeEvent)
370-
option.changeEvent.bind(guiOption)()
370+
option.changeEvent.call(guiOption)
371371
if (
372372
!noEvent &&
373373
'updateMenuOnChange' in option &&
@@ -418,7 +418,7 @@ export function modOptionsPoststart() {
418418
if (!controlConfig.global && !isInGame) continue
419419
const id = controlConfig.id.substring('keys-'.length) as ig.Input.KnownAction
420420
if (controlConfig.pressEvent && ig.input.pressed(id)) {
421-
controlConfig.pressEvent.bind(controlConfig)()
421+
controlConfig.pressEvent.call(controlConfig)
422422
}
423423
if (controlConfig.holdEvent && ig.input.state(id)) {
424424
controlConfig.holdEvent()

0 commit comments

Comments
 (0)