fix: guard optional accesses and numeric parse calls against absent/malformed values#116
Open
SoundMatt wants to merge 1 commit into
Open
fix: guard optional accesses and numeric parse calls against absent/malformed values#116SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
…alformed values Four related issues where WebSocket-derived values could be absent or non-numeric: (a) node.getValue().value() in generateTriplesFromNode now checks has_value() first; (b) coordinate getValue().value() calls in generateTriplesFromCoordinates are guarded similarly; (c) std::stod in getCoordInNtm is wrapped in try/catch returning std::nullopt on failure; (d) std::stoi in parseISO8601ToTime is wrapped in try/catch assigning std::nullopt to milliseconds on failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four sites in
triple_assembler.cppandhelper.cppcall.value()on optionals without checking.has_value(), or pass WebSocket-derived strings tostd::stod/std::stoiwithout catching conversion errors. Any absent value or non-numeric string from the WebSocket causesstd::bad_optional_accessor an unhandledstd::invalid_argument/std::out_of_rangeexception.Root cause
The code assumes that node values and coordinate strings are always present and always numeric. WebSocket messages are external, untrusted input and can legitimately omit values or contain non-numeric data.
Fix
(a) Guard
node.getValue().value()ingenerateTriplesFromNodewith ahas_value()check and throwstd::runtime_errorif absent. (b) Guard the latitude/longitudegetValue().value()calls ingenerateTriplesFromCoordinatesthe same way. (c) Wrapstd::stodingetCoordInNtmin try/catch, returningstd::nullopton failure. (d) Wrapstd::stoiinparseISO8601ToTimein try/catch, assigningstd::nullopttomillisecondson failure.