Skip to content

Commit 4ae0913

Browse files
committed
updating code so that if help message is already deleted, an exception is no longer raised
1 parent d63837d commit 4ae0913

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

wall_e/overriden_coroutines/delete_help_messages.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ async def delete_help_command_messages():
1313
for help_message in help_messages:
1414
channel = bot.get_channel(int(help_message.channel_id))
1515
if channel is not None:
16-
successful = False
16+
help_message_fetched = False
17+
help_message_already_deleted = False
1718
try:
1819
message = await channel.fetch_message(int(help_message.message_id))
1920
try:
@@ -23,15 +24,14 @@ async def delete_help_command_messages():
2324
# means the original invocating message has since been deleted so the code can move on
2425
pass
2526
await message.delete()
26-
successful = True
27+
help_message_fetched = True
2728
except discord.NotFound:
28-
log_exception(
29-
logger,
29+
logger.info(
3030
f"[delete_help_messages.py delete_help_command_messages()] could not find the "
3131
f"message that contains the help command with obj {help_message}"
3232
)
33-
# setting successful True since the message seems to already be deleted
34-
successful = True
33+
# seems the message is already deleted
34+
help_message_already_deleted = True
3535
except discord.Forbidden:
3636
log_exception(
3737
logger,
@@ -41,7 +41,7 @@ async def delete_help_command_messages():
4141
)
4242
# if wall_e does not have the permission to delete the message,
4343
# a retry would not fix that anyways
44-
successful = True
44+
help_message_fetched = True
4545
except discord.HTTPException:
4646
log_exception(
4747
logger,
@@ -50,7 +50,7 @@ async def delete_help_command_messages():
5050
f"contains the help command with obj {help_message}"
5151
)
5252
# there might be a momentary network glitch, best to try again
53-
if successful:
53+
if help_message_fetched or help_message_already_deleted:
5454
await HelpMessage.delete_message(help_message)
5555
except Exception as error:
5656
print_wall_e_exception(error, error.__traceback__, error_logger=logger.error)

0 commit comments

Comments
 (0)