Skip to content

[GrantFox][High] Make billing reconciliation idempotent #1143

Description

@greatest0fallt1me

Summary

Make billing reconciliation idempotent

Why this matters

Provider retries can apply one invoice or payment more than once.

Scope

Add an immutable provider-event key, atomic ledger mutation, conflict detection, and replay reporting.

Acceptance criteria

  • Repeated events leave the ledger unchanged after first application.
  • Conflicting payloads are rejected and audited.
  • Ledger and reconciliation record commit atomically.
  • Tests cover replay, conflict, rollback, and concurrent submissions.

Validation

Add regression coverage for existing behavior, failure modes, authorization boundaries, and compatibility. The implementation must pass the repository CI checks.

Non-goals

  • Typo-only, formatting-only, or documentation-only changes.
  • Unrelated refactors or dependency upgrades.
  • Weakening existing security, authorization, CI, or production safeguards.

Contributor application

Before implementation, comment with relevant experience, a 1–4 bullet approach, and an estimate for opening the first draft PR. Wait for maintainer assignment before coding.

PR requirements

Use a feature branch, include Closes #<issue-number>, check every acceptance criterion, link criteria to code/tests, explain security and failure-mode considerations, and pass CI.

Reward-readiness

This is a substantive GrantFox campaign issue. Merge and CI success do not by themselves guarantee reward eligibility; final reward-readiness is determined by campaign review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions