Skip to content

Commit f0dcacc

Browse files
vdelacruzbclaude
andcommitted
chore(ora): wire Oracle into publish-release.yml + add publish job
oracle.yml had test and deploy-internal jobs but no publish job, so even when invoked via workflow_call from publish-release.yml nothing would upload the package to GCS. publish-release.yml itself never dispatched Oracle either — no change_ora output, no oracle filter, no publish-ora job. Result: the Oracle release zip was never published. Add the missing pieces, modeled on Databricks's publish (closest peer among newer clouds) plus the node+yarn setup Oracle needs to bundle its MLE-JS libraries during create-package. No Python/virtualenv — the Oracle create-package chain is pure node (rollup + build_modules.js). Package destinations: gs://carto-analytics-toolbox-core/oracle/carto-analytics-toolbox-core-oracle-<version>.zip gs://carto-analytics-toolbox-core/oracle/carto-analytics-toolbox-core-oracle-latest.zip gs://carto-analytics-toolbox-core/oracle/metadata.json Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 15e33e8 commit f0dcacc

2 files changed

Lines changed: 52 additions & 0 deletions

File tree

.github/workflows/oracle.yml

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,3 +156,41 @@ jobs:
156156
run: |
157157
cd clouds/oracle
158158
make deploy production=1
159+
160+
publish:
161+
if: github.ref_name == 'stable'
162+
needs: test
163+
runs-on: ubuntu-24.04
164+
timeout-minutes: 10
165+
env:
166+
PACKAGE_BUCKET: gs://carto-analytics-toolbox-core/oracle
167+
steps:
168+
- name: Checkout repo
169+
uses: actions/checkout@v2
170+
- name: Setup node
171+
uses: actions/setup-node@v1
172+
with:
173+
node-version: ${{ env.NODE_VERSION }}
174+
- name: Setup yarn
175+
run: npm install -g yarn
176+
- name: Auth google
177+
uses: google-github-actions/auth@v2
178+
with:
179+
credentials_json: ${{ secrets.GCLOUD_PRODUCTION_RELEASE_SA }}
180+
project_id: ${{ secrets.GCLOUD_PRODUCTION_PROJECT }}
181+
create_credentials_file: true
182+
- name: Setup gcloud
183+
uses: google-github-actions/setup-gcloud@v2
184+
with:
185+
version: ${{ env.GCLOUD_VERSION }}
186+
project_id: ${{ secrets.GCLOUD_PRODUCTION_PROJECT }}
187+
- name: Create package
188+
run: |
189+
cd clouds/oracle
190+
make create-package
191+
- name: Publish package
192+
run: |
193+
cd clouds/oracle
194+
gsutil -h "Content-Type:application/zip" -m cp dist/*.zip ${{ env.PACKAGE_BUCKET }}/
195+
gsutil -h "Content-Type:application/zip" -m cp dist/*.zip ${{ env.PACKAGE_BUCKET }}/carto-analytics-toolbox-core-oracle-latest.zip
196+
gsutil -h "Content-Type:application/json" -m cp dist/*.json ${{ env.PACKAGE_BUCKET }}/

.github/workflows/publish-release.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
outputs:
1515
change_bq: ${{ steps.changes.outputs.bigquery }}
1616
change_db: ${{ steps.changes.outputs.databricks }}
17+
change_ora: ${{ steps.changes.outputs.oracle }}
1718
change_pg: ${{ steps.changes.outputs.postgres }}
1819
change_rs: ${{ steps.changes.outputs.redshift }}
1920
change_sf: ${{ steps.changes.outputs.snowflake }}
@@ -44,6 +45,8 @@ jobs:
4445
- 'clouds/bigquery/version'
4546
databricks:
4647
- 'clouds/databricks/version'
48+
oracle:
49+
- 'clouds/oracle/version'
4750
postgres:
4851
- 'clouds/postgres/version'
4952
redshift:
@@ -55,6 +58,7 @@ jobs:
5558
run: |
5659
BQ_VERSION=$(cat clouds/bigquery/version)
5760
DB_VERSION=$(cat clouds/databricks/version)
61+
ORA_VERSION=$(cat clouds/oracle/version)
5862
PG_VERSION=$(cat clouds/postgres/version)
5963
RS_VERSION=$(cat clouds/redshift/version)
6064
SF_VERSION=$(cat clouds/snowflake/version)
@@ -65,6 +69,9 @@ jobs:
6569
if [[ ${{ steps.changes.outputs.databricks }} = "true" ]]; then
6670
RELEASE_BODY+="\n- Databricks release version $DB_VERSION - [CHANGELOG](https://github.com/${{ github.repository }}/blob/stable/clouds/databricks/CHANGELOG.md)"
6771
fi
72+
if [[ ${{ steps.changes.outputs.oracle }} = "true" ]]; then
73+
RELEASE_BODY+="\n- Oracle release version $ORA_VERSION - [CHANGELOG](https://github.com/${{ github.repository }}/blob/stable/clouds/oracle/CHANGELOG.md)"
74+
fi
6875
if [[ ${{ steps.changes.outputs.postgres }} = "true" ]]; then
6976
RELEASE_BODY+="\n- Postgres release version $PG_VERSION - [CHANGELOG](https://github.com/${{ github.repository }}/blob/stable/clouds/postgres/CHANGELOG.md)"
7077
fi
@@ -111,6 +118,13 @@ jobs:
111118
uses: CartoDB/analytics-toolbox-core/.github/workflows/bigquery.yml@stable
112119
secrets: inherit
113120

121+
publish-ora:
122+
needs: release
123+
if: needs.release.outputs.change_ora == 'true'
124+
name: "Publish AT for Oracle"
125+
uses: CartoDB/analytics-toolbox-core/.github/workflows/oracle.yml@stable
126+
secrets: inherit
127+
114128
publish-pg:
115129
needs: release
116130
if: needs.release.outputs.change_pg == 'true'

0 commit comments

Comments
 (0)