Make invalid FakeChargingStation responses explicit

The FakeChargingStation implementations were implicitly sending invalid
responses to a GetVariablesRequest. Make this behavior configurable and
explicit with a setter method.

Author: robert-s-ubi

ocpp-v1_6-test/src/main/java/eu/chargetime/ocpp/test/FakeChargePoint.java

@@ -64,6 +64,7 @@ public class FakeChargePoint {
   String receivedConfirmationError;
   String receivedConfirmationErrorDescription;
   String receivedConfirmationErrorUniqueId;
+  boolean riggedToSendInvalidResponse = false;
   String url;
 
   public FakeChargePoint() throws MalformedURLException {
@@ -653,4 +654,12 @@ public String getReceivedConfirmationErrorDescription() {
   public String getReceivedConfirmationErrorUniqueId() {
     return receivedConfirmationErrorUniqueId;
   }
+
+  public void setRiggedToSendInvalidResponse(boolean riggedToSendInvalidResponse) {
+    this.riggedToSendInvalidResponse = riggedToSendInvalidResponse;
+  }
+
+  public boolean isRiggedToSendInvalidResponse() {
+    return riggedToSendInvalidResponse;
+  }
 }

ocpp-v2-test/src/main/java/eu/chargetime/ocpp/test/FakeChargingStation.java

@@ -47,4 +47,6 @@ public interface FakeChargingStation {
   String getReceivedConfirmationErrorDescription();
 
   String getReceivedConfirmationErrorUniqueId();
+
+  void setRiggedToSendInvalidResponse(boolean riggedToSendInvalidResponse);
 }

ocpp-v2-test/src/main/java/eu/chargetime/ocpp/test/OCPP201MultiProtocolFakeChargingStation.java

@@ -87,17 +87,24 @@ public GetReportResponse handleGetReportRequest(GetReportRequest request) {
               @Override
               public GetVariablesResponse handleGetVariablesRequest(GetVariablesRequest request) {
                 receivedRequest = request;
-                return new GetVariablesResponse(
-                    new GetVariableResult[] {
-                      new GetVariableResult(
-                          GetVariableStatusEnum.UnknownVariable,
-                          new Component(""),
-                          new Variable("")),
-                      new GetVariableResult(
-                          GetVariableStatusEnum.UnknownVariable,
-                          new Component(""),
-                          new Variable(""))
-                    });
+                int results =
+                    isRiggedToSendInvalidResponse()
+                        ? request.getGetVariableData().length + 1
+                        : request.getGetVariableData().length;
+                GetVariableResult[] result = new GetVariableResult[results];
+                for (int i = 0; i < results; i++) {
+                  result[i] =
+                      i < request.getGetVariableData().length
+                          ? new GetVariableResult(
+                              GetVariableStatusEnum.UnknownVariable,
+                              request.getGetVariableData()[i].getComponent(),
+                              request.getGetVariableData()[i].getVariable())
+                          : new GetVariableResult(
+                              GetVariableStatusEnum.UnknownVariable,
+                              new Component(""),
+                              new Variable(""));
+                }
+                return new GetVariablesResponse(result);
               }
 
               @Override

ocpp-v2-test/src/main/java/eu/chargetime/ocpp/test/OCPP21MultiProtocolFakeChargingStation.java

@@ -70,17 +70,24 @@ public GetReportResponse handleGetReportRequest(GetReportRequest request) {
               @Override
               public GetVariablesResponse handleGetVariablesRequest(GetVariablesRequest request) {
                 receivedRequest = request;
-                return new GetVariablesResponse(
-                    new GetVariableResult[] {
-                      new GetVariableResult(
-                          GetVariableStatusEnum.UnknownVariable,
-                          new Component(""),
-                          new Variable("")),
-                      new GetVariableResult(
-                          GetVariableStatusEnum.UnknownVariable,
-                          new Component(""),
-                          new Variable(""))
-                    });
+                int results =
+                    isRiggedToSendInvalidResponse()
+                        ? request.getGetVariableData().length + 1
+                        : request.getGetVariableData().length;
+                GetVariableResult[] result = new GetVariableResult[results];
+                for (int i = 0; i < results; i++) {
+                  result[i] =
+                      i < request.getGetVariableData().length
+                          ? new GetVariableResult(
+                              GetVariableStatusEnum.UnknownVariable,
+                              request.getGetVariableData()[i].getComponent(),
+                              request.getGetVariableData()[i].getVariable())
+                          : new GetVariableResult(
+                              GetVariableStatusEnum.UnknownVariable,
+                              new Component(""),
+                              new Variable(""));
+                }
+                return new GetVariablesResponse(result);
               }
 
               @Override

ocpp-v2-test/src/test/java/eu/chargetime/ocpp/test/OCPP21MultiProtocolIntegrationTest.java

@@ -170,9 +170,11 @@ public void testInvalidOCPP21ClientResponseTriggersCALLRESULTERROR() throws Inte
         (OCPP21MultiProtocolFakeCSMS) setupAndStartCSMS(OCPP2_1_FIRST);
     FakeChargingStation cs = buildAndConnectChargingStation(OCPP2_1_ONLY, csms);
     cs.sendBootNotification("vendor", "model");
+    cs.setRiggedToSendInvalidResponse(true);
 
     csms.sendGetVariablesRequest();
     Thread.sleep(100);
+    assertThat(cs.getReceivedConfirmationError(), is(notNullValue()));
     assertThat(cs.getReceivedConfirmationError(), is("PropertyConstraintViolation"));
     assertThat(
         cs.getReceivedConfirmationErrorDescription(),
@@ -187,6 +189,7 @@ public void testInvalidOCPP201ClientResponseTriggersNoMessage() throws Interrupt
         (OCPP21MultiProtocolFakeCSMS) setupAndStartCSMS(OCPP2_1_FIRST);
     FakeChargingStation cs = buildAndConnectChargingStation(OCPP2_0_1_ONLY, csms);
     cs.sendBootNotification("vendor", "model");
+    cs.setRiggedToSendInvalidResponse(true);
 
     csms.sendGetVariablesRequest();
     Thread.sleep(100);