Log warning when incoming SEND message is invalid

robert-s-ubi · robert-s-ubi · commit a4e4b80151d6 · 2026-03-20T10:44:56.000+01:00
Log a warning when an incoming SEND message is invalid instead of just
silently dropping it.
diff --git a/ocpp-common/src/main/java/eu/chargetime/ocpp/Session.java b/ocpp-common/src/main/java/eu/chargetime/ocpp/Session.java
@@ -337,6 +337,8 @@ public void onSend(String id, String action, Object payload) {
           request.setOcppMessageId(id);
           if (request.validate()) {
             dispatcher.handleRequest(null, request);
+          } else {
+            logger.warn("Received SEND message with id {} is invalid: {}", id, request);
           }
         } catch (PropertyConstraintException | SecurityErrorException ex) {
           logger.warn(ex.getMessage(), ex);

Original file line number	Diff line number	Diff line change
`@@ -337,6 +337,8 @@ public void onSend(String id, String action, Object payload) {`
`337`	`337`	`request.setOcppMessageId(id);`
`338`	`338`	`if (request.validate()) {`
`339`	`339`	`dispatcher.handleRequest(null, request);`
	`340`	`+ } else {`
	`341`	`+ logger.warn("Received SEND message with id {} is invalid: {}", id, request);`
`340`	`342`	`}`
`341`	`343`	`} catch (PropertyConstraintException \| SecurityErrorException ex) {`
`342`	`344`	`logger.warn(ex.getMessage(), ex);`