Fix all compiler warnings in ocpp-common

Author: robert-s-ubi

ocpp-common/src/main/java/eu/chargetime/ocpp/CallErrorException.java

@@ -27,6 +27,7 @@ of this software and associated documentation files (the "Software"), to deal
 
 /** Exception returned to an outgoing request if an error is reported from the other end. */
 public class CallErrorException extends Exception {
+  private static final long serialVersionUID = 2491636769263746241L;
 
   private String errorCode;
   private String errorDescription;

ocpp-common/src/main/java/eu/chargetime/ocpp/NotConnectedException.java

@@ -24,4 +24,6 @@ of this software and associated documentation files (the "Software"), to deal
                                SOFTWARE.
                             */
 
-public class NotConnectedException extends Exception {}
+public class NotConnectedException extends Exception {
+  private static final long serialVersionUID = -2192470845608175121L;
+}

ocpp-common/src/main/java/eu/chargetime/ocpp/OccurenceConstraintException.java

@@ -25,4 +25,6 @@ of this software and associated documentation files (the "Software"), to deal
                             */
 
 /** Exception thrown when trying to send a request that isn't valid. */
-public class OccurenceConstraintException extends Exception {}
+public class OccurenceConstraintException extends Exception {
+  private static final long serialVersionUID = -8870111792165582976L;
+}

ocpp-common/src/main/java/eu/chargetime/ocpp/PropertyConstraintException.java

@@ -28,7 +28,7 @@ of this software and associated documentation files (the "Software"), to deal
 
 /** Exception used when validating fields. */
 public class PropertyConstraintException extends IllegalArgumentException {
-
+  private static final long serialVersionUID = 7561578774874709893L;
   private static final String EXCEPTION_MESSAGE_TEMPLATE =
       "Validation failed: [%s]. Current Value: [%s]";
 

ocpp-common/src/main/java/eu/chargetime/ocpp/SecurityErrorException.java

@@ -29,6 +29,8 @@ of this software and associated documentation files (the "Software"), to deal
 
 /** A security issue occurred */
 public class SecurityErrorException extends IllegalStateException {
+  private static final long serialVersionUID = 630599636179474207L;
+
   public SecurityErrorException(String s) {
     super(s);
   }

ocpp-common/src/main/java/eu/chargetime/ocpp/model/validation/OptionalDecorator.java

@@ -27,9 +27,9 @@ of this software and associated documentation files (the "Software"), to deal
 
 public class OptionalDecorator extends Validator<String> {
 
-  private final Validator validator;
+  private final Validator<String> validator;
 
-  public OptionalDecorator(Validator validator) {
+  public OptionalDecorator(Validator<String> validator) {
     this.validator = validator;
   }
 

ocpp-common/src/main/java/eu/chargetime/ocpp/model/validation/RequiredDecorator.java

@@ -27,17 +27,17 @@ of this software and associated documentation files (the "Software"), to deal
 
 import eu.chargetime.ocpp.PropertyConstraintException;
 
-public class RequiredDecorator extends Validator<Object> {
+public class RequiredDecorator<T> extends Validator<T> {
 
-  private final Validator requiredValidator = new RequiredValidator();
-  private final Validator decoratee;
+  private final Validator<T> requiredValidator = new RequiredValidator<>();
+  private final Validator<T> decoratee;
 
-  public RequiredDecorator(Validator validator) {
+  public RequiredDecorator(Validator<T> validator) {
     this.decoratee = validator;
   }
 
   @Override
-  public void validate(Object value) throws PropertyConstraintException {
+  public void validate(T value) throws PropertyConstraintException {
     requiredValidator.validate(value);
     decoratee.validate(value);
   }

ocpp-common/src/main/java/eu/chargetime/ocpp/model/validation/RequiredValidator.java

@@ -27,11 +27,11 @@ of this software and associated documentation files (the "Software"), to deal
 
 import eu.chargetime.ocpp.PropertyConstraintException;
 
-public class RequiredValidator extends Validator<Object> {
-  private final String ERROR_MESSAGE = "Field is required and must not be Null.";
+public class RequiredValidator<T> extends Validator<T> {
+  private static final String ERROR_MESSAGE = "Field is required and must not be Null.";
 
   @Override
-  public void validate(Object value) throws PropertyConstraintException {
+  public void validate(T value) throws PropertyConstraintException {
     if (value == null) {
       throw new PropertyConstraintException(ERROR_MESSAGE, null);
     }

ocpp-common/src/main/java/eu/chargetime/ocpp/model/validation/ValidatorBuilder.java

@@ -29,8 +29,8 @@ of this software and associated documentation files (the "Software"), to deal
 
 public class ValidatorBuilder {
 
+  private final ArrayList<IValidationRule> rules;
   private boolean required = false;
-  private ArrayList<IValidationRule> rules;
 
   public ValidatorBuilder() {
     rules = new ArrayList<>();
@@ -46,10 +46,10 @@ public ValidatorBuilder setRequired(boolean isRequired) {
     return this;
   }
 
-  public Validator build() {
-    Validator validator = new StringValidator(rules.toArray(new IValidationRule[0]));
+  public Validator<String> build() {
+    Validator<String> validator = new StringValidator(rules.toArray(new IValidationRule[0]));
 
-    if (required) validator = new RequiredDecorator(validator);
+    if (required) validator = new RequiredDecorator<>(validator);
     else validator = new OptionalDecorator(validator);
 
     return validator;

ocpp-common/src/main/java/eu/chargetime/ocpp/utilities/TestUtilities.java

@@ -26,7 +26,7 @@
  * SOFTWARE.
  */
 
-/** Utilities for tests. Used to quickly create usefull objects. */
+/** Utilities for tests. Used to quickly create useful objects. */
 public final class TestUtilities {
 
   /**
@@ -57,6 +57,7 @@ public static String aString(int length) {
    * @param <T> The type of the elements.
    * @return An array of the given elements.
    */
+  @SuppressWarnings({"varargs", "unchecked"})
   public static <T> T[] aList(T... objects) {
     return objects;
   }
@@ -73,6 +74,6 @@ public static String join(String delimiter, Object[] array) {
 
     for (Object current : array) output.append(String.format("%s%s", delimiter, current));
 
-    return output.toString().substring(1);
+    return output.substring(1);
   }
 }