Skip to content

Test CMIP7 cloud radiative effects diagnostic#683

Draft
bouweandela wants to merge 3 commits into
mainfrom
test-diagnostic-cre-cmip7
Draft

Test CMIP7 cloud radiative effects diagnostic#683
bouweandela wants to merge 3 commits into
mainfrom
test-diagnostic-cre-cmip7

Conversation

@bouweandela
Copy link
Copy Markdown
Contributor

Description

Test the recipe from ESMValGroup/ESMValTool#4461

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@bouweandela
Copy link
Copy Markdown
Contributor Author

@lewisjared When I run the command

ref test-cases run --provider esmvaltool --diagnostic cloud-radiative-effects --test-case cmip7 --fetch --clean --force-regen

with this branch it ends with

...
  File "/home/bandela/src/Climate-REF/climate-ref/packages/climate-ref/src/climate_ref/cli/test_cases.py", line 92, in _solve_test_case
    executions = list(solve_executions(data_catalog, diagnostic, diagnostic.provider))
                      │                │             │           │          └ <property object at 0x7b48b7862660>
                      │                │             │           └ CloudRadiativeEffects(name='Climatologies and zonal mean profiles of cloud radiative effects')
                      │                │             └ CloudRadiativeEffects(name='Climatologies and zonal mean profiles of cloud radiative effects')
                      │                └ {<SourceDatasetType.CMIP7: 'cmip7'>:   activity_id institution_id source_id experiment_id variant_label  ...             time...
                      └ <function solve_executions at 0x7b48b78d74c0>

  File "/home/bandela/src/Climate-REF/climate-ref/packages/climate-ref/src/climate_ref/solver.py", line 298, in solve_executions
    raise InvalidDiagnosticException(
          └ <class 'climate_ref_core.exceptions.InvalidDiagnosticException'>

climate_ref_core.exceptions.InvalidDiagnosticException: Invalid diagnostic: 'CloudRadiativeEffects(name='Climatologies and zonal mean profiles of cloud radiative effects')'
 No data catalog matches any of the diagnostic's data requirements. Available source types: SourceDatasetType.CMIP7, SourceDatasetType.obs4MIPs

Any ideas on what I'm doing wrong here?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core 93.11% <ø> (ø)
providers ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lewisjared
Copy link
Copy Markdown
Contributor

lewisjared commented May 20, 2026

Running with ref --verbose suggests that there isn't any overlap

2026-05-20 21:47:14.102 +10:00 | DEBUG    | climate_ref_core.constraints - Constraint RequireTimerange(group_by=('instance_id',), start=PartialDateTime(year=2001, month=1), end=PartialDateTime(year=2021, month=12)) not satisfied because end time 2014-12-16 12:00:00 is before required end time for /Users/jared/Library/Caches/climate_ref/cmip7-converted/MIP-DRS7/CMIP7/CMIP/CCCma/CanESM5/historical/r1i1p1f1/glb/mon/rlut/tavg-u-hxy-u/gn/20190429/rlut_tavg-u-hxy-u_mon_glb_gn_CanESM5_historical_r1i1p1f1_185001-201412.nc
2026-05-20 21:47:14.102 +10:00 | DEBUG    | climate_ref_core.constraints - Constraint RequireTimerange(group_by=('instance_id',), start=PartialDateTime(year=2001, month=1), end=PartialDateTime(year=2021, month=12)) not satisfied because end time 2014-12-16 12:00:00 is before required end time for /Users/jared/Library/Caches/climate_ref/cmip7-converted/MIP-DRS7/CMIP7/CMIP/CCCma/CanESM5/historical/r1i1p1f1/glb/mon/rlutcs/tavg-u-hxy-u/gn/20190429/rlutcs_tavg-u-hxy-u_mon_glb_gn_CanESM5_historical_r1i1p1f1_185001-201412.nc
2026-05-20 21:47:14.103 +10:00 | DEBUG    | climate_ref_core.constraints - Constraint RequireTimerange(group_by=('instance_id',), start=PartialDateTime(year=2001, month=1), end=PartialDateTime(year=2021, month=12)) not satisfied because end time 2014-12-16 12:00:00 is before required end time for /Users/jared/Library/Caches/climate_ref/cmip7-converted/MIP-DRS7/CMIP7/CMIP/CCCma/CanESM5/historical/r1i1p1f1/glb/mon/rsut/tavg-u-hxy-u/gn/20190429/rsut_tavg-u-hxy-u_mon_glb_gn_CanESM5_historical_r1i1p1f1_185001-201412.nc
2026-05-20 21:47:14.103 +10:00 | DEBUG    | climate_ref_core.constraints - Constraint RequireTimerange(group_by=('instance_id',), start=PartialDateTime(year=2001, month=1), end=PartialDateTime(year=2021, month=12)) not satisfied because end time 2014-12-16 12:00:00 is before required end time for /Users/jared/Library/Caches/climate_ref/cmip7-converted/MIP-DRS7/CMIP7/CMIP/CCCma/CanESM5/historical/r1i1p1f1/glb/mon/rsutcs/tavg-u-hxy-u/gn/20190429/rsutcs_tavg-u-hxy-u_mon_glb_gn_CanESM5_historical_r1i1p1f1_185001-201412.nc
2026-05-20 21:47:14.103 +10:00 | DEBUG    | climate_ref_core.constraints - Constraint RequireTimerange(group_by=('instance_id',), start=PartialDateTime(year=2001, month=1), end=PartialDateTime(year=2021, month=12)) not satisfied for 4 rows

A downside of having no real test data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants