Add warnings on map load for objects being outside of the map, fix edge case where building was processed when even if its origin cell was outside of the map

Author: Rampastring

src/TSMapEditor/Config/Translations/en/Translation_en.ini

@@ -77,8 +77,11 @@ MapLoader.ReadBuildings.UpgradeInvalid=Building {0} has an upgrade {1}, but@{2}d
 MapLoader.ReadBuildings.UpgradeCountMismatch=Building {0} at {1} has more upgrades ({2}) than specified by its Upgrades= value ({3}) in Rules. Skipping adding one or more of the building's upgrades.
 MapLoader.CheckFoundationCell.TileOutOfBounds=Building {0} has been placed outside of the map at {1}. Skipping adding it to map.
 MapLoader.ReadAircraft.AircraftTypeNotFound=Unable to find aircraft type {0} - skipping adding it to map.
+MapLoader.ReadAircraft.AircraftOutsideOfMap=Warning: The map has an aircraft "{0}" ({1}) placed outside of the valid map area at {2}, {3}.
 MapLoader.ReadUnits.UnitTypeNotFound=Unable to find unit type {0} - skipping adding it to map.
+MapLoader.ReadUnits.UnitOutsideOfMap=Warning: The map has a unit "{0}" ({1}) placed outside of the valid map area at {2}, {3}.
 MapLoader.ReadInfantry.InfantryTypeNotFound=Unable to find infantry type {0} - skipping adding it to map.
+MapLoader.ReadInfantry.InfantryOutsideOfMap=Warning: The map has an infantry "{0}" ({1}) placed outside of the valid map area at {2}, {3}.
 MapLoader.ReadSmudges.InvalidSmudgeSyntax=Invalid syntax in smudge defined in map: {0}
 MapLoader.ReadSmudges.InvalidSmudgeSyntaxAtPosition=Invalid syntax in smudge at {0},{1}: {2}
 MapLoader.ReadSmudges.SmudgeTypeNotFound=Cell at {0},{1} contains a smudge '{2}' that does not exist in Rules.ini. Ignoring it.

src/TSMapEditor/Constants.cs

@@ -4,7 +4,7 @@ namespace TSMapEditor
 {
     public static class Constants
     {
-        public const string ReleaseVersion = "1.7.7";
+        public const string ReleaseVersion = "1.7.8";
 
         public static int CellSizeX = 48;
         public static int CellSizeY = 24;

src/TSMapEditor/Initialization/MapLoader.cs

@@ -398,20 +398,25 @@ public static void ReadBuildings(IMap map, IniFile mapIni)
 
                 bool isClear = false;
 
-                void CheckFoundationCell(Point2D cellCoords)
+                void ApplyFoundationCell(Point2D cellCoords)
                 {
                     var tile = map.GetTile(cellCoords);
                     if (tile != null)
                     {
-                        isClear = true;
                         tile.Structures.Add(building);
                     }
                 }
 
-                // Go through foundation cells and register the building to all tiles that are valid on its foundation.
-                // If the building was added to no cells (all cells on its foundation were nonexistent),
-                // then the building is outside of the map and we should not consider it as belonging to the map.
-                buildingType.ArtConfig.DoForFoundationCoordsOrOrigin(offset => CheckFoundationCell(building.Position + offset));
+                bool IsFoundationCellOnMap(Point2D cellCoords) => map.GetTile(cellCoords) != null;
+
+                // Check that the building's origin cell is within the map. If it is not, we should not add the building to the map at all.
+                if (IsFoundationCellOnMap(building.Position))
+                {
+                    isClear = true;
+
+                    // Go through foundation cells and register the building to all tiles that are valid on its foundation.
+                    buildingType.ArtConfig.DoForFoundationCoordsOrOrigin(offset => ApplyFoundationCell(building.Position + offset));
+                }
 
                 if (!isClear)
                 {
@@ -487,7 +492,15 @@ public static void ReadAircraft(IMap map, IniFile mapIni)
                 map.Aircraft.Add(aircraft);
                 var tile = map.GetTile(x, y);
                 if (tile != null)
+                {
                     tile.Aircraft.Add(aircraft);
+                }
+                else
+                {
+                    AddMapLoadError(string.Format(Translate("MapLoader.ReadAircraft.AircraftOutsideOfMap",
+                        "Warning: The map has an aircraft \"{0}\" ({1}) placed outside of the valid map area at {2}, {3}."),
+                        aircraftType.GetEditorDisplayName(), aircraftTypeId, x, y));
+                }
             }
 
             Logger.Log("Aircraft read successfully.");
@@ -553,7 +566,15 @@ public static void ReadUnits(IMap map, IniFile mapIni)
                 map.Units.Add(unit);
                 var tile = map.GetTile(x, y);
                 if (tile != null)
+                {
                     tile.Vehicles.Add(unit);
+                }
+                else
+                {
+                    AddMapLoadError(string.Format(Translate("MapLoader.ReadUnits.UnitOutsideOfMap",
+                        "Warning: The map has a unit \"{0}\" ({1}) placed outside of the valid map area at {2}, {3}."),
+                        unitType.GetEditorDisplayName(), unitTypeId, x, y));
+                }
             }
 
             // Process follow IDs
@@ -628,7 +649,15 @@ public static void ReadInfantry(IMap map, IniFile mapIni)
                 map.Infantry.Add(infantry);
                 var tile = map.GetTile(x, y);
                 if (tile != null)
+                {
                     tile.Infantry[(int)subCell] = infantry;
+                }
+                else
+                {
+                    AddMapLoadError(string.Format(Translate("MapLoader.ReadInfantry.InfantryOutsideOfMap",
+                        "Warning: The map has an infantry \"{0}\" ({1}) placed outside of the valid map area at {2}, {3}."),
+                        infantryType.GetEditorDisplayName(), infantryTypeId, x, y));
+                }
             }
 
             Logger.Log("Infantry read successfully.");