Should be ready for 2.3.6 release...

thedillonb · thedillonb · commit ccd256bc51ca · 2015-09-06T01:06:28.000-04:00
diff --git a/CodeHub.Core/App.cs b/CodeHub.Core/App.cs
@@ -2,6 +2,12 @@
 using CodeHub.Core.ViewModels.App;
 using CodeFramework.Core.Services;
 using Cirrious.CrossCore;
+using System.Net;
+using System.Net.Http;
+using ModernHttpClient;
+using System.Threading.Tasks;
+using System;
+using Foundation;
 
 namespace CodeHub.Core
 {
@@ -15,14 +21,26 @@ public class App : MvxApplication
         /// </summary>
         public override void Initialize()
         {
+            ServicePointManager.ServerCertificateValidationCallback += (sender, cert, chain, sslPolicyErrors) => true;
+
 			//Ensure this is loaded
 			Cirrious.MvvmCross.Plugins.Messenger.PluginLoader.Instance.EnsureLoaded();
 
-			var httpService = Mvx.Resolve<IHttpClientService>();
-			GitHubSharp.Client.ClientConstructor = httpService.Create;
+            GitHubSharp.Client.ClientConstructor = () => new HttpClient(new HttpMessageHandler());
 
             // Start the app with the First View Model.
 			this.RegisterAppStart<StartupViewModel>();
         }
     }
+
+    class HttpMessageHandler : NativeMessageHandler
+    {
+        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, System.Threading.CancellationToken cancellationToken)
+        {
+            if (!string.Equals(request.Method.ToString(), "get", StringComparison.OrdinalIgnoreCase))
+                NSUrlCache.SharedCache.RemoveAllCachedResponses();
+            return base.SendAsync(request, cancellationToken);
+        }
+    }
+
 }
diff --git a/CodeHub.Core/CodeHub.Core.iOS.csproj b/CodeHub.Core/CodeHub.Core.iOS.csproj
@@ -216,6 +216,9 @@
       <HintPath>..\CodeHub.iOS\packages\MvvmCross.HotTuna.Plugin.Messenger.3.5.1\lib\portable-win+net45+wp8+win8+wpa81\Cirrious.MvvmCross.Plugins.Messenger.dll</HintPath>
     </Reference>
     <Reference Include="Xamarin.iOS" />
+    <Reference Include="ModernHttpClient">
+      <HintPath>..\packages\modernhttpclient.2.4.2\lib\Xamarin.iOS10\ModernHttpClient.dll</HintPath>
+    </Reference>
   </ItemGroup>
   <ItemGroup />
   <ItemGroup>
diff --git a/CodeHub.Core/ViewModels/Gists/GistCreateViewModel.cs b/CodeHub.Core/ViewModels/Gists/GistCreateViewModel.cs
@@ -91,7 +91,7 @@ private async Task Save()
             {
                 var createGist = new GistCreateModel()
                 {
-                    Description = Description,
+                    Description = Description ?? string.Empty,
                     Public = Public,
                     Files = Files.ToDictionary(x => x.Key, x => new GistCreateModel.File { Content = x.Value })
                 };
diff --git a/CodeHub.Core/packages.config b/CodeHub.Core/packages.config
@@ -2,6 +2,7 @@
 <packages>
   <package id="Flurry.Analytics.Portable" version="1.2.0" targetFramework="MonoTouch10" />
   <package id="GitHubClient" version="1.0.5.0" targetFramework="MonoTouch10" />
+  <package id="modernhttpclient" version="2.4.2" targetFramework="xamarinios10" />
   <package id="MvvmCross.HotTuna.CrossCore" version="3.5.1" targetFramework="MonoTouch10" />
   <package id="MvvmCross.HotTuna.MvvmCrossLibraries" version="3.5.1" targetFramework="MonoTouch10" />
   <package id="MvvmCross.HotTuna.Plugin.Messenger" version="3.5.1" targetFramework="MonoTouch10" />
diff --git a/CodeHub.iOS/AppDelegate.cs b/CodeHub.iOS/AppDelegate.cs
@@ -22,6 +22,7 @@
 using CodeFramework.iOS.XCallback;
 using Security;
 using ObjCRuntime;
+using System.Net;
 
 namespace CodeHub.iOS
 {
diff --git a/CodeHub.iOS/Bindings/UISegmentControlBinding.cs b/CodeHub.iOS/Bindings/UISegmentControlBinding.cs
diff --git a/CodeHub.iOS/CodeHub.iOS.csproj b/CodeHub.iOS/CodeHub.iOS.csproj
@@ -229,7 +229,6 @@
       <DependentUpon>EnableEnterpriseViewController.cs</DependentUpon>
     </Compile>
     <None Include="packages.config" />
-    <Compile Include="Bindings\UISegmentControlBinding.cs" />
     <Compile Include="Cells\IssueCellView.cs" />
     <Compile Include="Cells\IssueCellView.designer.cs">
       <DependentUpon>..\..\lib\CodeFramework\CodeFramework.iOS\Cells\IssueCellView.cs</DependentUpon>
@@ -419,6 +418,9 @@
     <Reference Include="Flurry.Analytics.Portable">
       <HintPath>..\packages\Flurry.Analytics.Portable.1.2.0\lib\XamariniOS10\Flurry.Analytics.Portable.dll</HintPath>
     </Reference>
+    <Reference Include="ModernHttpClient">
+      <HintPath>..\packages\modernhttpclient.2.4.2\lib\Xamarin.iOS10\ModernHttpClient.dll</HintPath>
+    </Reference>
   </ItemGroup>
   <ItemGroup>
     <Content Include="Images\anonymous%402x.png" />
diff --git a/CodeHub.iOS/Services/DefaultValueService.cs b/CodeHub.iOS/Services/DefaultValueService.cs
@@ -12,7 +12,7 @@ public T Get<T>(string key)
                 throw new Exception("Value for key '" + key + "' does not exist!");
 
             if (typeof(T) == typeof(int))
-                return (T)(object)Utilities.Defaults.IntForKey(key);
+                return (T)(object)(int)Utilities.Defaults.IntForKey(key);
             if (typeof(T) == typeof(bool))
                 return (T)(object)Utilities.Defaults.BoolForKey(key);
             if (typeof (T) == typeof (string))
diff --git a/CodeHub.iOS/Services/PushNotificationsService.cs b/CodeHub.iOS/Services/PushNotificationsService.cs
@@ -11,8 +11,8 @@ namespace CodeHub.iOS.Services
 {
 	public class PushNotificationsService : IPushNotificationsService
     {
-        private const string RegisterUri = "http://162.243.15.10/register";
-        private const string DeregisterUri = "http://162.243.15.10/unregister";
+        private const string RegisterUri = "https://push.codehub-app.com/register";
+        private const string DeregisterUri = "https://push.codehub-app.com/unregister";
 
         public async Task Register()
 		{
diff --git a/CodeHub.iOS/Setup.cs b/CodeHub.iOS/Setup.cs
@@ -14,7 +14,6 @@
 using MonoTouch.Dialog;
 using CodeFramework.iOS.Views;
 using UIKit;
-using CodeFramework.iOS.Bindings;
 
 namespace CodeHub.iOS
 {
@@ -61,12 +60,6 @@ protected override void FillBindingNames(IMvxBindingNameRegistry obj)
 			obj.AddOrOverwrite(typeof(UISegmentedControl), "ValueChanged");
         }
 
-		protected override void FillTargetFactories(Cirrious.MvvmCross.Binding.Bindings.Target.Construction.IMvxTargetBindingFactoryRegistry registry)
-		{
-			base.FillTargetFactories(registry);
-			registry.RegisterFactory(new Cirrious.MvvmCross.Binding.Bindings.Target.Construction.MvxCustomBindingFactory<UISegmentedControl>("ValueChanged", x => new UISegmentControlBinding(x)));
-		}
-
         /// <summary>
         /// Creates the app.
         /// </summary>
diff --git a/CodeHub.iOS/Utils/Util.cs b/CodeHub.iOS/Utils/Util.cs
@@ -82,7 +82,7 @@ public static void LogException (Exception e)
         static UIActionSheet _sheet;
         public static UIActionSheet GetSheet (string title)
         {
-            _sheet = new UIActionSheet (title);
+            _sheet = new UIActionSheet ();
             return _sheet;
         }
 
diff --git a/CodeHub.iOS/ViewControllers/DialogViewController.cs b/CodeHub.iOS/ViewControllers/DialogViewController.cs
@@ -271,7 +271,7 @@ public virtual void SearchButtonClicked (string text)
 			searchBar.ResignFirstResponder();
 		}
 
-		class SearchDelegate : UISearchBarDelegate {
+		protected class SearchDelegate : UISearchBarDelegate {
 			DialogViewController container;
 
 			public SearchDelegate (DialogViewController container)
@@ -493,11 +493,16 @@ public void ActivateController (UIViewController controller)
 				PresentModalViewController (controller, true);
 		}
 
+        protected virtual IUISearchBarDelegate CreateSearchDelegate()
+        {
+            return new SearchDelegate(this);
+        }
+
 		void SetupSearch ()
 		{
 			if (enableSearch){
 				searchBar = new UISearchBar (new CGRect (0, 0, tableView.Bounds.Width, 44)) {
-					Delegate = new SearchDelegate (this)
+                    Delegate = CreateSearchDelegate()
 				};
 				if (SearchPlaceholder != null)
 					searchBar.Placeholder = this.SearchPlaceholder;
diff --git a/CodeHub.iOS/Views/AccountsView.cs b/CodeHub.iOS/Views/AccountsView.cs
@@ -24,6 +24,7 @@ public class AccountsView : ViewModelDrivenDialogViewController
 
         public AccountsView() : base(true)
         {
+            Style = UITableViewStyle.Plain;
         }
 
 		public override void ViewDidLoad()
diff --git a/CodeHub.iOS/Views/App/SettingsView.cs b/CodeHub.iOS/Views/App/SettingsView.cs
@@ -72,8 +72,6 @@ private void CreateTable()
 			};
 			startupView.Tapped += () => vm.GoToDefaultStartupViewCommand.Execute(null);
 
-            var sidebarOrder = new StyledStringElement("Sidebar Order", () => vm.GoToSidebarOrderCommand.Execute(null));
-
             var largeFonts = new TrueFalseElement("Large Fonts", vm.LargeFonts, x =>
             {
                 vm.LargeFonts = x.Value;
@@ -92,13 +90,11 @@ private void CreateTable()
 				ReloadData();
 			};
 
-			var usage = new TrueFalseElement("Send Anonymous Usage".t(), vm.AnalyticsEnabled, e => vm.AnalyticsEnabled = e.Value);
-
 			//Assign the root
 			var root = new RootElement(Title);
             root.Add(accountSection);
             root.Add(new Section("Appearance") { showOrganizationsInEvents, showOrganizations, repoDescriptions, startupView, largeFonts });
-			root.Add(new Section ("Internal") { deleteCache, usage });
+			root.Add(new Section ("Internal") { deleteCache });
 			Root = root;
 
 		}
diff --git a/CodeHub.iOS/Views/Repositories/RepositoriesExploreView.cs b/CodeHub.iOS/Views/Repositories/RepositoriesExploreView.cs
@@ -18,6 +18,11 @@ public RepositoriesExploreView()
             //EnableFilter = true;
             NoItemsText = "No Repositories".t();
             Title = "Explore".t();
+        }
+
+        protected override IUISearchBarDelegate CreateSearchDelegate()
+        {
+            return null;
         }
 
         public override void ViewDidLoad()
@@ -53,7 +58,7 @@ public override void ViewDidLoad()
 				sse.Tapped += () => vm.GoToRepositoryCommand.Execute(repo);
                 return sse;
             });
-        }
+        }
     }
 }
 
diff --git a/CodeHub.iOS/Views/Source/BranchesAndTagsView.cs b/CodeHub.iOS/Views/Source/BranchesAndTagsView.cs
@@ -3,7 +3,6 @@
 using CodeHub.Core.ViewModels.Source;
 using MonoTouch.Dialog;
 using UIKit;
-using Cirrious.MvvmCross.Binding.BindingContext;
 
 namespace CodeHub.iOS.Views.Source
 {
@@ -25,9 +24,8 @@ public override void ViewDidLoad()
 
 			var vm = (BranchesAndTagsViewModel)ViewModel;
 			this.BindCollection(vm.Items, x => new StyledStringElement(x.Name, () => vm.GoToSourceCommand.Execute(x)));
-			var set = this.CreateBindingSet<BranchesAndTagsView, BranchesAndTagsViewModel>();
-			set.Bind(_viewSegment).To(x => x.SelectedFilter);
-			set.Apply();
+            _viewSegment.ValueChanged += (sender, e) => vm.SelectedFilter = (int)_viewSegment.SelectedSegment; 
+            vm.Bind(x => x.SelectedFilter, x => _viewSegment.SelectedSegment = (nint)x, true);
 		}
 
 		public override void ViewWillAppear(bool animated)
diff --git a/CodeHub.iOS/packages.config b/CodeHub.iOS/packages.config
@@ -5,6 +5,7 @@
   <package id="Flurry.Analytics.Portable" version="1.2.0" targetFramework="xamarinios10" />
   <package id="GitHubClient" version="1.0.5.0" targetFramework="xamarinios10" />
   <package id="Humanizer" version="1.37.7" targetFramework="xamarinios10" />
+  <package id="modernhttpclient" version="2.4.2" targetFramework="xamarinios10" />
   <package id="MonoTouch.SlideoutNavigation" version="0.1.1" targetFramework="xamarinios10" />
   <package id="MvvmCross.HotTuna.CrossCore" version="3.5.1" targetFramework="xamarinios10" />
   <package id="MvvmCross.HotTuna.MvvmCrossLibraries" version="3.5.1" targetFramework="xamarinios10" />

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private async Task Save()`
`91`	`91`	`{`
`92`	`92`	`var createGist = new GistCreateModel()`
`93`	`93`	`{`
`94`		`- Description = Description,`
	`94`	`+ Description = Description ?? string.Empty,`
`95`	`95`	`Public = Public,`
`96`	`96`	`Files = Files.ToDictionary(x => x.Key, x => new GistCreateModel.File { Content = x.Value })`
`97`	`97`	`};`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`using CodeFramework.iOS.XCallback;`
`23`	`23`	`using Security;`
`24`	`24`	`using ObjCRuntime;`
	`25`	`+using System.Net;`
`25`	`26`
`26`	`27`	`namespace CodeHub.iOS`
`27`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ namespace CodeHub.iOS.Services`
`11`	`11`	`{`
`12`	`12`	`public class PushNotificationsService : IPushNotificationsService`
`13`	`13`	`{`
`14`		`- private const string RegisterUri = "http://162.243.15.10/register";`
`15`		`- private const string DeregisterUri = "http://162.243.15.10/unregister";`
	`14`	`+ private const string RegisterUri = "https://push.codehub-app.com/register";`
	`15`	`+ private const string DeregisterUri = "https://push.codehub-app.com/unregister";`
`16`	`16`
`17`	`17`	`public async Task Register()`
`18`	`18`	`{`