fix(go1.25): remove the golangci-lint from tools as it is not supported for go above 1.24

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>

Author: CodeLieutenant

.gitignore

@@ -6,3 +6,4 @@ coverage.out
 *.html
 *.log
 .env
+.idea/

.run/go test utils.run.xml

@@ -0,0 +1,13 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="go test utils" type="GoTestRunConfiguration" factoryName="Go Test" nameIsGenerated="true">
+    <module name="utils" />
+    <working_directory value="$PROJECT_DIR$" />
+    <go_parameters value="-tags testing -timeout 2m" />
+    <kind value="DIRECTORY" />
+    <package value="github.com/CodeLieutenant/utils" />
+    <directory value="$PROJECT_DIR$" />
+    <filePath value="$PROJECT_DIR$" />
+    <framework value="gotest" />
+    <method v="2" />
+  </configuration>
+</component>

env_test.go

@@ -282,9 +282,9 @@ func TestGetAllIntTypesOverflow(t *testing.T) {
 	p := simpleTestEnv()
 
 	// Set environment variables directly
-	_ = os.Setenv("INT8_OVER_TEST", "128")              // > 127
-	_ = os.Setenv("INT16_OVER_TEST", "40000")           // > 32767
-	_ = os.Setenv("INT32_OVER_TEST", "2147483648")      // > int32 max
+	_ = os.Setenv("INT8_OVER_TEST", "128")                  // > 127
+	_ = os.Setenv("INT16_OVER_TEST", "40000")               // > 32767
+	_ = os.Setenv("INT32_OVER_TEST", "2147483648")          // > int32 max
 	_ = os.Setenv("INT64_OVER_TEST", "9223372036854775808") // > int64 max
 	_ = os.Setenv("INT_STD_OVER_TEST", "9223372036854775808")
 
@@ -429,6 +429,7 @@ func TestGetKeyEnv(t *testing.T) {
 	// Test with valid hex key (32 bytes when decoded)
 	validHexKey := "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef" // 32 bytes hex
 	p.Set("CRYPTO_KEY_HEX", validHexKey)
+
 	defaultKey := []byte("defaultkey")
 	result := utils.GetKeyEnv(p, "CRYPTO_KEY_HEX", defaultKey)
 	require.NotEqual(t, defaultKey, result)
@@ -478,6 +479,7 @@ func TestNewEnv(t *testing.T) {
 			require.Contains(t, r.(string), "dotenv file not found")
 		}
 	}()
+
 	env = utils.NewEnv(false)
 	require.NotNil(t, env.EnvProvider)
 }
@@ -486,17 +488,12 @@ func TestLoadDotEnv_LoadError(t *testing.T) {
 	t.Parallel()
 
 	// Create a temporary directory for this test to avoid interfering with other tests
-	tmpDir, err := os.MkdirTemp("", "env-test-*")
-	require.NoError(t, err)
-	defer func() {
-		_ = os.RemoveAll(tmpDir)
-	}()
+	tmpDir := t.TempDir()
 
 	// Create an invalid .env file that will cause godotenv.Load to fail
 	invalidEnvContent := "INVALID_LINE_WITHOUT_EQUALS\n"
 	envFile := filepath.Join(tmpDir, ".env")
-	err = os.WriteFile(envFile, []byte(invalidEnvContent), 0o644)
-	require.NoError(t, err)
+	require.NoError(t, os.WriteFile(envFile, []byte(invalidEnvContent), 0o644))
 
 	// This should not panic but should log an error and return
 	require.NotPanics(t, func() {
@@ -514,13 +511,14 @@ func TestOsEnvProvider(t *testing.T) {
 
 	// Clean up any existing value
 	originalValue := os.Getenv(testKey)
-	defer func() {
+
+	t.Cleanup(func() {
 		if originalValue != "" {
 			t.Setenv(testKey, originalValue)
 		} else {
 			t.Setenv(testKey, "")
 		}
-	}()
+	})
 
 	// Test Set
 	provider.Set(testKey, testValue)

go.mod

@@ -828,7 +828,6 @@ func TestReadFrom(t *testing.T) {
 	response := NewResponse(rr)
 	reader := strings.NewReader("test content")
 
-	require.Panics(t, func() {
-		_, _ = response.ReadFrom(reader)
-	})
+	_, err := response.ReadFrom(reader)
+	require.ErrorIs(t, err, ErrNotReaderFrom)
 }

go.sum

@@ -2,6 +2,7 @@ package httputils
 
 import (
 	"encoding/json"
+	"errors"
 	"io"
 	"log/slog"
 	"net/http"
@@ -10,6 +11,8 @@ import (
 	"github.com/Oudwins/zog"
 )
 
+var ErrNotReaderFrom = errors.New("reader does not implement io.ReaderFrom interface")
+
 type ResponseEncoder interface {
 	Encode(http.ResponseWriter, int, ...any)
 }
@@ -91,10 +94,10 @@ func (r Response) BadRequest() {
 	r.Error(http.StatusBadRequest, "bad request")
 }
 
-func (r Response) ValidationError(err zog.ZogIssueMap) {
+func (r Response) ValidationError(err zog.ZogIssueList) {
 	r.encoder.Encode(r.w, http.StatusUnprocessableEntity, map[string]any{
 		"message": "validation error",
-		"errors":  zog.Issues.SanitizeMapAndCollect(err),
+		"errors":  zog.Issues.FlattenAndCollect(err),
 	})
 }
 
@@ -120,7 +123,12 @@ func (r Response) SetHeader(key, value string) Response {
 }
 
 func (r Response) ReadFrom(src io.Reader) (int64, error) {
-	return r.w.(io.ReaderFrom).ReadFrom(src) //nolint:forcetypeassert
+	readerFrom, ok := r.w.(io.ReaderFrom)
+	if !ok {
+		return 0, ErrNotReaderFrom
+	}
+
+	return readerFrom.ReadFrom(src)
 }
 
 func (r Response) SetCookie(cookie *http.Cookie) Response {

httputils/httphelpers_test.go

@@ -8,9 +8,8 @@ import (
 	"regexp"
 	"testing"
 
-	"github.com/stretchr/testify/require"
-
 	"github.com/CodeLieutenant/utils"
+	"github.com/stretchr/testify/require"
 )
 
 func TestCreateLogFile(t *testing.T) {
@@ -19,14 +18,14 @@ func TestCreateLogFile(t *testing.T) {
 
 	path := "./test-logs/log.json"
 
-	t.Cleanup(func() { _ = os.RemoveAll("./test-logs") })
-
 	file, err := utils.CreateLogFile(path)
-	defer func() {
+	t.Cleanup(func() {
 		if file != nil {
 			_ = file.Close()
 		}
-	}()
+
+		_ = os.RemoveAll("./test-logs")
+	})
 
 	req.NoError(err)
 	req.NotNil(file)
@@ -39,13 +38,11 @@ func TestFileExistsSuccess(t *testing.T) {
 	req := require.New(t)
 	path := "./log.json"
 	file, err := utils.CreateLogFile(path)
-	defer func() {
+	t.Cleanup(func() {
 		if file != nil {
 			_ = file.Close()
 		}
-	}()
 
-	t.Cleanup(func() {
 		_ = os.Remove(path)
 	})
 
@@ -75,12 +72,7 @@ func TestCreateDirectory(t *testing.T) {
 	t.Parallel()
 	req := require.New(t)
 
-	// Use a temporary directory to avoid conflicts
-	tmp, err := os.MkdirTemp("", "test-create-dir-*")
-	req.NoError(err)
-	defer func() { _ = os.RemoveAll(tmp) }()
-
-	testDir := filepath.Join(tmp, "test-dir")
+	testDir := filepath.Join(t.TempDir(), "test-dir")
 	path, err := utils.CreateDirectory(testDir, 0o744)
 
 	req.NoError(err)
@@ -94,14 +86,11 @@ func TestGetAbsolutePath_RelativeAbsoluteAndError(t *testing.T) {
 
 	origWD, err := os.Getwd()
 	req.NoError(err)
-	defer func() { _ = os.Chdir(origWD) }()
+	t.Cleanup(func() { t.Chdir(origWD) })
 
-	tmp, err := os.MkdirTemp("", "abs-test-*")
-	req.NoError(err)
-	defer func() { _ = os.RemoveAll(tmp) }()
+	tmp := t.TempDir()
+	t.Chdir(tmp)
 
-	// Change into tmp and test relative path success
-	req.NoError(os.Chdir(tmp))
 	rel := "sub/dir/file.txt"
 	got, err := utils.GetAbsolutePath(rel)
 	req.NoError(err)
@@ -113,14 +102,10 @@ func TestGetAbsolutePath_RelativeAbsoluteAndError(t *testing.T) {
 	req.NoError(err)
 	req.Equal(tmp, got2)
 
-	// Induce error by removing the current directory before calling
-	req.NoError(os.Chdir(tmp))
+	t.Chdir(tmp)
 	req.NoError(os.RemoveAll(tmp))
 	_, err = utils.GetAbsolutePath("anything")
 	req.Error(err)
-
-	// Restore WD
-	req.NoError(os.Chdir(origWD))
 }
 
 func TestCreateDirectoryFromFile_SuccessAndError(t *testing.T) {
@@ -179,6 +164,7 @@ func TestCreateFile_CreateReopenAndError(t *testing.T) {
 	b, err := io.ReadAll(f2)
 	req.NoError(err)
 	req.Equal("hello", string(b))
+	req.NoError(f2.Close())
 
 	// Error path via invalid CWD so CreateDirectoryFromFile fails
 	req.NoError(os.Chdir(tmp))
@@ -187,7 +173,7 @@ func TestCreateFile_CreateReopenAndError(t *testing.T) {
 	req.Error(err)
 
 	// Restore
-	req.NoError(os.Chdir(origWD))
+	req.NoError(os.Chdir(origWD)) //nolint:usetesting
 }
 
 func TestGenerateRandomPassword(t *testing.T) {
@@ -406,71 +392,6 @@ func TestWorkingDir_ErrorHandling(t *testing.T) {
 	req.Equal(tmp, wd)
 }
 
-func TestProjectRootDir_ErrorCases(t *testing.T) {
-	// This test manipulates the working directory, so it can't be parallel
-	req := require.New(t)
-
-	// Save original working directory
-	origWD, err := os.Getwd()
-	req.NoError(err)
-	defer func() { _ = os.Chdir(origWD) }()
-
-	// Test normal operation first - should work and populate cache
-	root := utils.ProjectRootDir(t)
-	req.NotEmpty(root)
-	req.True(filepath.IsAbs(root))
-
-	// Test cache hit by calling again
-	root2 := utils.ProjectRootDir(t)
-	req.Equal(root, root2)
-
-	// Test from a subdirectory of the project
-	tmp, err := os.MkdirTemp(root, "test-subdir-*")
-	req.NoError(err)
-	defer func() { _ = os.RemoveAll(tmp) }()
-
-	// Change to subdirectory
-	req.NoError(os.Chdir(tmp))
-
-	// Should still find the project root
-	root3 := utils.ProjectRootDir(t)
-	req.Equal(root, root3)
-}
-
-func TestFindFile_ErrorCases(t *testing.T) {
-	// This test manipulates the working directory
-	req := require.New(t)
-
-	// Save original working directory
-	origWD, err := os.Getwd()
-	req.NoError(err)
-	defer func() { _ = os.Chdir(origWD) }()
-
-	// Test normal case - finding go.mod should work
-	dir := utils.FindFile(t, "go.mod")
-	req.NotEmpty(dir)
-	req.True(filepath.IsAbs(dir))
-
-	// Test finding a file in current directory
-	projectRoot := utils.ProjectRootDir(t)
-	testFile := filepath.Join(projectRoot, "test-find-file.tmp")
-	f, err := os.Create(testFile)
-	req.NoError(err)
-	_ = f.Close()
-	defer func() { _ = os.Remove(testFile) }()
-
-	// Change to a subdirectory
-	tmp, err := os.MkdirTemp(projectRoot, "test-find-subdir-*")
-	req.NoError(err)
-	defer func() { _ = os.RemoveAll(tmp) }()
-
-	req.NoError(os.Chdir(tmp))
-
-	// Should find the file by walking up
-	foundDir := utils.FindFile(t, "test-find-file.tmp")
-	req.Equal(projectRoot, foundDir)
-}
-
 // Test that demonstrates the GetLocalIP and GetLocalIPs error handling
 func TestGetLocalIP_ErrorPath(t *testing.T) {
 	t.Parallel()
@@ -576,25 +497,6 @@ func TestFindFile_ReadDirError(t *testing.T) {
 	req.Equal(projectRoot, found)
 }
 
-func TestProjectRootDir_CacheEdgeCases(t *testing.T) {
-	t.Parallel()
-	req := require.New(t)
-
-	// Test multiple calls to ensure cache works properly
-	root1 := utils.ProjectRootDir(t)
-	root2 := utils.ProjectRootDir(t)
-	root3 := utils.ProjectRootDir(t)
-
-	req.Equal(root1, root2)
-	req.Equal(root2, root3)
-	req.NotEmpty(root1)
-	req.True(filepath.IsAbs(root1))
-
-	// Verify go.mod exists in the root
-	goModPath := filepath.Join(root1, "go.mod")
-	req.FileExists(goModPath)
-}
-
 func TestWorkingDir_Success(t *testing.T) {
 	t.Parallel()
 	req := require.New(t)