Skip to content

Commit d0427df

Browse files
committed
Remove immutable.js
1 parent 6f6beec commit d0427df

6 files changed

Lines changed: 9 additions & 22 deletions

File tree

‎package-lock.json‎

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
"es6-object-assign": "1.1.0",
5555
"get-float-time-domain-data": "0.1.0",
5656
"get-user-media-promise": "1.1.4",
57-
"immutable": "3.8.2",
5857
"intl": "1.2.5",
5958
"intl-messageformat": "^2.2.0",
6059
"js-base64": "2.4.9",

‎src/components/monitor-list/monitor-list.jsx‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import classNames from 'classnames';
33
import Box from '../box/box.jsx';
44
import Monitor from '../../containers/monitor.jsx';
55
import PropTypes from 'prop-types';
6-
import {OrderedMap} from 'immutable';
76
import {stageSizeToTransform} from '../../lib/screen-utils';
87

98
import styles from './monitor-list.css';
@@ -21,7 +20,7 @@ const MonitorList = props => (
2120
className={styles.monitorListScaler}
2221
style={stageSizeToTransform(props.stageSize)}
2322
>
24-
{props.monitors.valueSeq().filter(m => m.visible)
23+
{props.monitors && props.monitors.valueSeq().filter(m => m.visible)
2524
.map(monitorData => (
2625
<Monitor
2726
draggable={props.draggable}
@@ -49,7 +48,9 @@ const MonitorList = props => (
4948

5049
MonitorList.propTypes = {
5150
draggable: PropTypes.bool.isRequired,
52-
monitors: PropTypes.instanceOf(OrderedMap),
51+
monitors: PropTypes.shape({
52+
valueSeq: PropTypes.func
53+
}),
5354
onMonitorChange: PropTypes.func.isRequired,
5455
stageSize: PropTypes.shape({
5556
width: PropTypes.number,

‎src/containers/list-monitor.jsx‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {connect} from 'react-redux';
66
import {getEventXY} from '../lib/touch-utils';
77
import {getVariableValue, setVariableValue} from '../lib/variable-utils';
88
import ListMonitorComponent from '../components/monitor/list-monitor.jsx';
9-
import {Map} from 'immutable';
109
import {safeStringify} from '../lib/tw-safe-stringify.js';
1110

1211
class ListMonitor extends React.Component {
@@ -161,11 +160,11 @@ class ListMonitor extends React.Component {
161160
onMouseMove(ev); // Make sure width/height are up-to-date
162161
window.removeEventListener('mousemove', onMouseMove);
163162
window.removeEventListener('mouseup', onMouseUp);
164-
this.props.vm.runtime.requestUpdateMonitor(Map({
163+
this.props.vm.runtime.requestUpdateMonitor({
165164
id: this.props.id,
166165
height: this.state.height,
167166
width: this.state.width
168-
}));
167+
});
169168
};
170169

171170
window.addEventListener('mousemove', onMouseMove);

‎src/containers/monitor.jsx‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {Theme} from '../lib/themes';
1313
import SliderPrompt from './slider-prompt.jsx';
1414

1515
import {connect} from 'react-redux';
16-
import {Map} from 'immutable';
1716
import VM from 'scratch-vm';
1817

1918
const availableModes = opcode => (
@@ -75,11 +74,11 @@ class Monitor extends React.Component {
7574
rect = getInitialPosition(
7675
this.props.monitorLayout, this.props.id, this.element.offsetWidth, this.element.offsetHeight);
7776
this.props.addMonitorRect(this.props.id, rect);
78-
this.props.vm.runtime.requestUpdateMonitor(Map({
77+
this.props.vm.runtime.requestUpdateMonitor({
7978
id: this.props.id,
8079
x: rect.upperStart.x,
8180
y: rect.upperStart.y
82-
}));
81+
});
8382
}
8483
this.element.style.top = `${rect.upperStart.y}px`;
8584
this.element.style.left = `${rect.upperStart.x}px`;

‎src/reducers/monitors.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
const UPDATE_MONITORS = 'scratch-gui/monitors/UPDATE_MONITORS';
2-
import {OrderedMap} from 'immutable';
32

4-
const initialState = OrderedMap();
3+
const initialState = null;
54

65
const reducer = function (state, action) {
76
if (typeof state === 'undefined') state = initialState;

0 commit comments

Comments
 (0)