fix: Remove parallel processing for now. It causes FFI issues in log callback for PHP 8.3 and 8.4

Author: CodeWithKyrian

src/WhisperContext.php

@@ -80,52 +80,6 @@ public function tokenize(string $text, int $maxTokens): array
         return $output;
     }
 
-    /**
-     * Split the input audio in chunks and process each chunk separately using whisper_full_with_state()
-     *
-     * Result is stored in the default state of the context
-     * Not thread safe if executed in parallel on the same context.
-     * It seems this approach can offer some speedup in some cases.
-     * However, the transcription accuracy can be worse at the beginning and end of each chunk.
-     *
-     * @param  float[]  $pcm  Raw PCM audio data, 32 bit floating point at a sample rate of 16 kHz, 1 channel.
-     * @param  WhisperFullParams  $params  The parameters to use.
-     * @param  int  $nProcessors  The number of processors to use.
-     */
-    public function fullParallel(array $pcm, WhisperFullParams $params, int $nProcessors): void
-    {
-        if (empty($pcm)) {
-            // can randomly trigger segmentation faults if we don't check this
-            throw WhisperException::noSamples();
-        }
-
-        $pcmSize = count($pcm);
-        $samples = $this->ffi->new("float[$pcmSize]");
-
-        foreach ($pcm as $i => $sample) {
-            $samples[$i] = $sample;
-        }
-
-        $cParams = $params->toCStruct($this->ffi);
-        $result = $this->ffi->whisper_full_parallel(
-            $this->ctx,
-            $cParams,
-            $this->ffi->cast('float *', $samples),
-            $pcmSize,
-            $nProcessors
-        );
-
-        match ($result) {
-            -1, -2 => throw WhisperException::failedToCalculateSpectrogram(),
-            -3 => throw WhisperException::failedToAutoDetectLanguage(),
-            -5 => throw WhisperException::audioCtxLongerThanMax($params->audioCtx, $this->modelNAudioCtx()),
-            -6 => WhisperException::failedToEncode(),
-            -7, -8 => WhisperException::failedToDecode(),
-            0 => null,
-            default => throw WhisperException::genericError($result)
-        };
-    }
-
     /**
      * Return the number of tokens in the vocabulary
      */
@@ -490,7 +444,11 @@ private function setupLoggerCallback(): void
         } else {
             $logCallback = function (int $level, string $message, ?CData $user_data) use ($logger) {
                 $psrLevel = (LogLevel::tryFrom($level) ?? LogLevel::INFO)->toPsrLogLevel();
-                $logger->log($psrLevel, $message);
+                try {
+                    $logger->log($psrLevel, $message);
+                } catch (\Throwable $e) {
+                    fwrite(STDERR, $e->getMessage());
+                }
             };
         }
 

tests/Feature/ProcessingTest.php

@@ -83,31 +83,6 @@
     expect($numSegments)->toBeGreaterThan(0);
 });
 
-it('can handle parallel processing', function () {
-    ini_set('memory_limit', -1);
-    $ctx = new WhisperContext($this->modelPath);
-    $pcm = loadTestAudio('jfk');
-
-    $fullParams = WhisperFullParams::default();
-
-    $ctx->fullParallel($pcm, $fullParams, 2);
-
-    $numSegments = $ctx->nSegments();
-    expect($numSegments)->toBeGreaterThan(0);
-
-    for ($i = 0; $i < $numSegments; $i++) {
-        $segment = $ctx->getSegmentText($i);
-        $startTimestamp = $ctx->getSegmentStartTime($i);
-        $endTimestamp = $ctx->getSegmentEndTime($i);
-
-        // Verify segment data
-        expect($segment)->toBeString()
-            ->and($startTimestamp)->toBeInt()
-            ->and($endTimestamp)->toBeInt()
-            ->and($startTimestamp)->toBeLessThanOrEqual($endTimestamp);
-    }
-});
-
 it('can convert raw PCM audio to log mel spectrogram', function () {
     $ctx = new WhisperContext($this->modelPath);
     $state = $ctx->createState();