Skip to content

Suggestion to add a potential memory leak warning to the readme #29

Description

@moshetet

S3StreamLogger will keep the logs in this.buffers until it needs to create a new file.
So if setting large rotate_every and max_file_size you can bump into a nasty memory leak.

A warning should be added to the README to warn against this, especially since the following 2 things cause you to believe it is not a possibility unless you dig into the code of the package:

  1. The package says that it implements a stream (which usually means things don't stay in memory) after they are sent away.
  2. The options rotate_every and max_file_size just refer to the way the files are rotated in S3.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions