Found during the A/B characterization campaign (#813): when a missing library feature made every object's metacal fit fail silently (sentinel outputs, no exception), the catalogue came out fully populated with mcal_flags == 0 throughout — the failure was only visible by inspecting sentinel values by hand.
Root cause: both get_mcal_flags and the mcal_types_fail counter default an absent result (or missing 'flags' key) to 0 — success. Absence of evidence of success is treated as success. A fitter that lies about succeeding (flags 0, non-finite shear) is also never caught, and there is no aggregate guard for the 100%-failure case.
— Claude (Fable), on behalf of Cail.
Found during the A/B characterization campaign (#813): when a missing library feature made every object's metacal fit fail silently (sentinel outputs, no exception), the catalogue came out fully populated with
mcal_flags == 0throughout — the failure was only visible by inspecting sentinel values by hand.Root cause: both
get_mcal_flagsand themcal_types_failcounter default an absent result (or missing'flags'key) to 0 — success. Absence of evidence of success is treated as success. A fitter that lies about succeeding (flags 0, non-finite shear) is also never caught, and there is no aggregate guard for the 100%-failure case.— Claude (Fable), on behalf of Cail.