From 4759748c6d2bf3e34dd89bf7c091ee34f9e0014c Mon Sep 17 00:00:00 2001 From: Qther Date: Thu, 14 May 2026 20:59:29 +0800 Subject: [PATCH] perf: check Class#isInstance before casting ensures that a ClassCastException won't be generated, as doing so costs a lot --- .../cyclops/cyclopscore/helper/BlockEntityHelpersCommon.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/loader-common/src/main/java/org/cyclops/cyclopscore/helper/BlockEntityHelpersCommon.java b/loader-common/src/main/java/org/cyclops/cyclopscore/helper/BlockEntityHelpersCommon.java index b5c46acfe1d..d823984f231 100644 --- a/loader-common/src/main/java/org/cyclops/cyclopscore/helper/BlockEntityHelpersCommon.java +++ b/loader-common/src/main/java/org/cyclops/cyclopscore/helper/BlockEntityHelpersCommon.java @@ -32,9 +32,9 @@ public Optional get(BlockGetter level, BlockPos pos, Class targetClazz if (blockEntity == null) { return Optional.empty(); } - try { + if (targetClazz.isInstance(blockEntity)) { return Optional.of(targetClazz.cast(blockEntity)); - } catch (ClassCastException e) { + } else { return Optional.empty(); } }