From 293bf5d9ca4ec0d5de2fa0ebe5728f164b2b28ec Mon Sep 17 00:00:00 2001
From: Ciaran Mark Hasnip <chasnip@np04-srv-024.cern.ch>
Date: Fri, 17 Oct 2025 12:14:07 +0200
Subject: [PATCH 1/5] Add a class named TAMakerBSMWindowAlgorithm, which is
 part of the TAAlgorithm superclass. This is the only change.

---
 schema/appmodel/trigger.schema.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/schema/appmodel/trigger.schema.xml b/schema/appmodel/trigger.schema.xml
index b2e97192..3d071951 100644
--- a/schema/appmodel/trigger.schema.xml
+++ b/schema/appmodel/trigger.schema.xml
@@ -307,6 +307,16 @@
  <class name="TAMakerPrescaleAlgorithm">
   <superclass name="TAAlgorithm"/>
  </class>
+ 
+ <class name="TAMakerBSMWindowAlgorithm">
+   <superclass name="TAAlgorithm"/>
+   <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
+   <attribute name="adc_threshold" description="Threshold for the SADC sum" type="u32" init-value="400000" is-not-null="yes"/>
+   <attribute name="window_length" description="Length of window in time ticks" type="u32" init-value="20000" is-not-null="yes"/>
+   <attribute name="num_time_bins" description="Number of time bins" type="u32" init-value="5" is-not-null="yes"/>
+   <attribute name="bdt_threshold" description="BDT score threshold" type="u32" init-value="99" is-not-null="yes"/>
+   <attribute name="ratio_threshold" description="Threshold for ToT/peak ratio" type="u32" init-value="65" is-not-null="yes"/>
+ </class>
 
  <class name="TCAlgorithm" description="Base class for TC algorithms">
   <superclass name="Jsonable"/>

From f9d680a12c3cf81f6878ba5b00bfec87a01f3ff3 Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Tue, 31 Mar 2026 10:26:28 +0200
Subject: [PATCH 2/5] Update appmodel for new algorithm name
 (ProtoDUNEBSMWindow) and new parameters.

---
 schema/appmodel/trigger.schema.xml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/schema/appmodel/trigger.schema.xml b/schema/appmodel/trigger.schema.xml
index 3d071951..289a3662 100644
--- a/schema/appmodel/trigger.schema.xml
+++ b/schema/appmodel/trigger.schema.xml
@@ -308,14 +308,13 @@
   <superclass name="TAAlgorithm"/>
  </class>
  
- <class name="TAMakerBSMWindowAlgorithm">
+ <class name="TAMakerProtoDUNEBSMWindowAlgorithm">
    <superclass name="TAAlgorithm"/>
    <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
    <attribute name="adc_threshold" description="Threshold for the SADC sum" type="u32" init-value="400000" is-not-null="yes"/>
    <attribute name="window_length" description="Length of window in time ticks" type="u32" init-value="20000" is-not-null="yes"/>
-   <attribute name="num_time_bins" description="Number of time bins" type="u32" init-value="5" is-not-null="yes"/>
+   <attribute name="num_time_bins" description="Number of time bins" type="u32" init-value="10" is-not-null="yes"/>
    <attribute name="bdt_threshold" description="BDT score threshold" type="u32" init-value="99" is-not-null="yes"/>
-   <attribute name="ratio_threshold" description="Threshold for ToT/peak ratio" type="u32" init-value="65" is-not-null="yes"/>
  </class>
 
  <class name="TCAlgorithm" description="Base class for TC algorithms">

From 71e988aba78a2bbc218d050f1f94460060804332 Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Wed, 17 Jun 2026 15:13:06 +0200
Subject: [PATCH 3/5] Update user-defined variables.

---
 schema/appmodel/trigger.schema.xml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/schema/appmodel/trigger.schema.xml b/schema/appmodel/trigger.schema.xml
index dbb0486f..229d7430 100644
--- a/schema/appmodel/trigger.schema.xml
+++ b/schema/appmodel/trigger.schema.xml
@@ -331,9 +331,7 @@
  <class name="TAMakerProtoDUNEBSMWindowAlgorithm">
    <superclass name="TAAlgorithm"/>
    <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
-   <attribute name="adc_threshold" description="Threshold for the SADC sum" type="u32" init-value="400000" is-not-null="yes"/>
-   <attribute name="window_length" description="Length of window in time ticks" type="u32" init-value="20000" is-not-null="yes"/>
-   <attribute name="num_time_bins" description="Number of time bins" type="u32" init-value="10" is-not-null="yes"/>
+   <attribute name="adc_threshold_induction" description="Threshold for the SADC sum on induction planes" type="u32" init-value="12000000" is-not-null="yes"/>
    <attribute name="bdt_threshold" description="BDT score threshold" type="u32" init-value="99" is-not-null="yes"/>
  </class>
 

From 91f538e2baf609e11cf729b8aabbb6885ad8437a Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Wed, 24 Jun 2026 13:42:01 +0200
Subject: [PATCH 4/5] Implemented PR comments from Michal.

---
 schema/appmodel/trigger.schema.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/schema/appmodel/trigger.schema.xml b/schema/appmodel/trigger.schema.xml
index 1b6171e6..6fcaccbb 100644
--- a/schema/appmodel/trigger.schema.xml
+++ b/schema/appmodel/trigger.schema.xml
@@ -80,7 +80,7 @@
 
 <oks-schema>
 
-<info name="" type="" num-of-items="57" oks-format="schema" oks-version="862f2957270" created-by="asztuc" created-on="np04-srv-019.cern.ch" creation-time="20231211T133151" last-modified-by="eflumerf" last-modified-on="ironvirt9.mshome.net" last-modification-time="20251111T225403"/>
+<info name="" type="" num-of-items="58" oks-format="schema" oks-version="862f2957270" created-by="asztuc" created-on="np04-srv-019.cern.ch" creation-time="20231211T133151" last-modified-by="eflumerf" last-modified-on="ironvirt9.mshome.net" last-modification-time="20251111T225403"/>
 
 <include>
  <file path="schema/confmodel/dunedaq.schema.xml"/>
@@ -329,10 +329,10 @@
  </class>
  
  <class name="TAMakerProtoDUNEBSMWindowAlgorithm">
-   <superclass name="TAAlgorithm"/>
-   <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
-   <attribute name="adc_threshold_induction" description="Threshold for the SADC sum on induction planes" type="u32" init-value="12000000" is-not-null="yes"/>
-   <attribute name="bdt_threshold" description="BDT score threshold" type="u32" init-value="99" is-not-null="yes"/>
+  <superclass name="TAAlgorithm"/>
+  <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
+  <attribute name="adc_threshold_induction" description="Threshold for the SADC sum on induction planes" type="u32" init-value="12000000" is-not-null="yes"/>
+  <attribute name="bdt_threshold" description="BDT score threshold. Must be a float between 0 and 1." type="float" init-value="0.999" is-not-null="yes"/>
  </class>
 
  <class name="TCAlgorithm" description="Base class for TC algorithms">

From e71431a8554feb43e5afb196d0cc91a851fdbbe8 Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Fri, 26 Jun 2026 08:46:24 +0200
Subject: [PATCH 5/5] Addressign final PR comments. Limited bdt_threshold to be
 between 0 and 1. User trying to set a threshold outside these limits now
 throws an error, as it should.

---
 schema/appmodel/trigger.schema.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/schema/appmodel/trigger.schema.xml b/schema/appmodel/trigger.schema.xml
index 6fcaccbb..dc2f568e 100644
--- a/schema/appmodel/trigger.schema.xml
+++ b/schema/appmodel/trigger.schema.xml
@@ -332,7 +332,7 @@
   <superclass name="TAAlgorithm"/>
   <attribute name="channel_map_name" description="Channel map for TA algorithm" type="string" init-value="PD2VDTPCChannelMap" is-not-null="yes"/>
   <attribute name="adc_threshold_induction" description="Threshold for the SADC sum on induction planes" type="u32" init-value="12000000" is-not-null="yes"/>
-  <attribute name="bdt_threshold" description="BDT score threshold. Must be a float between 0 and 1." type="float" init-value="0.999" is-not-null="yes"/>
+  <attribute name="bdt_threshold" description="BDT score threshold. Must be a float between 0 and 1." type="float" range="0..1" init-value="0.999" is-not-null="yes"/>
  </class>
 
  <class name="TCAlgorithm" description="Base class for TC algorithms">