From df0e187af4309342eaba80f87b525c7cd6370d73 Mon Sep 17 00:00:00 2001
From: Ciaran Mark Hasnip <chasnip@np04-srv-024.cern.ch>
Date: Thu, 16 Oct 2025 09:29:22 +0200
Subject: [PATCH 1/6] daqsystemtest compiled with coredaq-v5.4.3 and with BSM
 Window TAMaker only added.

---
 config/daqsystemtest/moduleconfs.data.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index 2ca82ea..dd3c1b3 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -711,6 +711,17 @@
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
 </obj>
 
+<obj class="TAMakerBSMWindowAlgorithm" id="ta-maker-bsmwindow">
+ <attr name="prescale" type="u32" val="10"/>
+ <attr name="max_samples_over_threshold" type="u32" val="10000"/>
+ <attr name="channel_map_name" type="string" val="PD2VDTPCChannelMap"/>
+ <attr name="adc_threshold" type="u32" val="400000"/>
+ <attr name="window_length" type="u32" val="20000"/>
+ <attr name="num_time_bins" type="u32" val="5"/>
+ <attr name="bdt_threshold" type="u32" val="99"/>
+ <attr name="ratio_threshold" type="u32" val="65"/>
+</obj>
+
 <obj class="TCDataProcessor" id="def-tc-processor">
  <attr name="queue_sizes" type="u32" val="10000"/>
  <attr name="thread_names_prefix" type="string" val="mlt_"/>

From 915b261f22572dab5ed1087fde2558fb803076d2 Mon Sep 17 00:00:00 2001
From: Ciaran Mark Hasnip <chasnip@np04-srv-024.cern.ch>
Date: Tue, 31 Mar 2026 10:15:52 +0200
Subject: [PATCH 2/6] Update config files for new algorithm naming
 (ProtoDUNEBSMWindow) and updated parameters for new model.

---
 config/daqsystemtest/moduleconfs.data.xml | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index dd3c1b3..81a459a 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -711,15 +711,14 @@
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
 </obj>
 
-<obj class="TAMakerBSMWindowAlgorithm" id="ta-maker-bsmwindow">
- <attr name="prescale" type="u32" val="10"/>
+<obj class="TAMakerProtoDUNEBSMWindowAlgorithm" id="ta-maker-pdbsmwindow">
+ <attr name="prescale" type="u32" val="1"/>
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
  <attr name="channel_map_name" type="string" val="PD2VDTPCChannelMap"/>
  <attr name="adc_threshold" type="u32" val="400000"/>
  <attr name="window_length" type="u32" val="20000"/>
- <attr name="num_time_bins" type="u32" val="5"/>
- <attr name="bdt_threshold" type="u32" val="99"/>
- <attr name="ratio_threshold" type="u32" val="65"/>
+ <attr name="num_time_bins" type="u32" val="10"/>
+ <attr name="bdt_threshold" type="u32" val="992"/>
 </obj>
 
 <obj class="TCDataProcessor" id="def-tc-processor">
@@ -743,7 +742,7 @@
 </obj>
 
 <obj class="TCMakerPrescaleAlgorithm" id="tc-pass-through-algo">
- <attr name="prescale" type="u32" val="100"/>
+ <attr name="prescale" type="u32" val="1"/>
  <attr name="tc_type_name" type="string" val="kPrescale"/>
 </obj>
 
@@ -783,7 +782,7 @@
  <attr name="latency_monitoring" type="bool" val="1"/>
  <attr name="print_tp_info" type="bool" val="0"/>
  <rel name="algorithms">
-  <ref class="TAMakerPrescaleAlgorithm" id="dummy-ta-maker"/>
+  <ref class="TAMakerProtoDUNEBSMWindowAlgorithm" id="ta-maker-pdbsmwindow"/>
  </rel>
 </obj>
 
@@ -793,7 +792,7 @@
  <attr name="latency_monitoring" type="bool" val="0"/>
  <attr name="print_tp_info" type="bool" val="0"/>
  <rel name="algorithms">
-  <ref class="TAMakerPrescaleAlgorithm" id="dummy-ta-maker"/>
+  <ref class="TAMakerProtoDUNEBSMWindowAlgorithm" id="ta-maker-pdbsmwindow"/>
  </rel>
 </obj>
 

From 57c714f802a1418a28d42c168a29207bcc3ae1fd Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Wed, 17 Jun 2026 15:10:23 +0200
Subject: [PATCH 3/6] Update user-defined variables.

---
 config/daqsystemtest/moduleconfs.data.xml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index db291cd..cddbadd 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -809,9 +809,7 @@
  <attr name="prescale" type="u32" val="1"/>
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
  <attr name="channel_map_name" type="string" val="PD2VDTPCChannelMap"/>
- <attr name="adc_threshold" type="u32" val="400000"/>
- <attr name="window_length" type="u32" val="20000"/>
- <attr name="num_time_bins" type="u32" val="10"/>
+ <attr name="adc_threshold_induction" type="u32" val="12000000"/>
  <attr name="bdt_threshold" type="u32" val="992"/>
 </obj>
 

From 79d80d78152ce66eb7c5c24f02f51bffa6241e7a Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Fri, 19 Jun 2026 17:17:12 +0200
Subject: [PATCH 4/6] Change default bdt threshold to be 0.99, this gives 1Hz
 trigger rate with BDE only.

---
 config/daqsystemtest/moduleconfs.data.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index 3c182b5..9c521b8 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -798,7 +798,7 @@
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
  <attr name="channel_map_name" type="string" val="PD2VDTPCChannelMap"/>
  <attr name="adc_threshold_induction" type="u32" val="12000000"/>
- <attr name="bdt_threshold" type="u32" val="992"/>
+ <attr name="bdt_threshold" type="u32" val="999"/>
 </obj>
 
 <obj class="TCDataProcessor" id="def-tc-processor">

From a12d38d8a0d96cea1f8fed5c022d76e5ef275afa Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Sun, 21 Jun 2026 17:20:40 +0200
Subject: [PATCH 5/6] Return TPDataProcessor to default values for PR.

---
 config/daqsystemtest/moduleconfs.data.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index 9c521b8..e589d29 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -821,7 +821,7 @@
 </obj>
 
 <obj class="TCMakerPrescaleAlgorithm" id="tc-pass-through-algo">
- <attr name="prescale" type="u32" val="1"/>
+ <attr name="prescale" type="u32" val="100"/>
  <attr name="tc_type_name" type="string" val="kPrescale"/>
 </obj>
 
@@ -863,7 +863,7 @@
  <attr name="latency_monitoring" type="bool" val="1"/>
  <attr name="print_tp_info" type="bool" val="0"/>
  <rel name="algorithms">
-  <ref class="TAMakerProtoDUNEBSMWindowAlgorithm" id="ta-maker-pdbsmwindow"/>
+  <ref class="TAMakerPrescaleAlgorithm" id="dummy-ta-maker"/>
  </rel>
 </obj>
 
@@ -873,7 +873,7 @@
  <attr name="latency_monitoring" type="bool" val="0"/>
  <attr name="print_tp_info" type="bool" val="0"/>
  <rel name="algorithms">
-  <ref class="TAMakerProtoDUNEBSMWindowAlgorithm" id="ta-maker-pdbsmwindow"/>
+  <ref class="TAMakerPrescaleAlgorithm" id="dummy-ta-maker"/>
  </rel>
 </obj>
 

From bb343251112d91190d10785eeebb7eb481513a19 Mon Sep 17 00:00:00 2001
From: Ciaran Hasnip <ciaran.mark.hasnip@cern.ch>
Date: Wed, 24 Jun 2026 13:40:44 +0200
Subject: [PATCH 6/6] Implemented PR comments from Michal.

---
 config/daqsystemtest/moduleconfs.data.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/daqsystemtest/moduleconfs.data.xml b/config/daqsystemtest/moduleconfs.data.xml
index e589d29..26ebe4c 100644
--- a/config/daqsystemtest/moduleconfs.data.xml
+++ b/config/daqsystemtest/moduleconfs.data.xml
@@ -63,7 +63,7 @@
 
 <oks-data>
 
-<info name="" type="" num-of-items="96" oks-format="data" oks-version="862f2957270" created-by="gjc" created-on="thinkpad" creation-time="20231207T105629" last-modified-by="eflumerf" last-modified-on="ironvirt9.mshome.net" last-modification-time="20251105T144619"/>
+<info name="" type="" num-of-items="97" oks-format="data" oks-version="862f2957270" created-by="gjc" created-on="thinkpad" creation-time="20231207T105629" last-modified-by="eflumerf" last-modified-on="ironvirt9.mshome.net" last-modification-time="20251105T144619"/>
 
 <include>
  <file path="schema/confmodel/dunedaq.schema.xml"/>
@@ -798,7 +798,7 @@
  <attr name="max_samples_over_threshold" type="u32" val="10000"/>
  <attr name="channel_map_name" type="string" val="PD2VDTPCChannelMap"/>
  <attr name="adc_threshold_induction" type="u32" val="12000000"/>
- <attr name="bdt_threshold" type="u32" val="999"/>
+ <attr name="bdt_threshold" type="float" val="0.999"/>
 </obj>
 
 <obj class="TCDataProcessor" id="def-tc-processor">