Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.
This repository was archived by the owner on May 5, 2025. It is now read-only.

When using RumRoute it causes a re-render of entire component tree on history.push() calls #22

Description

@boazr-neosec

Based on the instructions detailed here we integrated this library in order to get better and more meaningful reports collected in Datadog RUM service.

Problem is that using RumRoute (as Route) causes each call to history.push() (where const history = useHistory(); in the standard way) causes a re-render of the components tree employed on the screen currently using used.

If we eliminate this import { RumRoute as Route } from '@datadog/rum-react-integration'; and import from react-router-dom problem is gone.

We're not sure where exactly the problem lies as the code inside this library and probably more so in @datadog/browser-rum-core is complex

Context (Environment)

  • React v18.3.1
  • react-router-dom v5.3.4

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions