Skip to content

Commit ab2130d

Browse files
Wrongly indented code on initial models (#745)
The insertion of the rescaled initial model should always happen, not only when it doesn't exist
1 parent db351d1 commit ab2130d

1 file changed

Lines changed: 27 additions & 28 deletions

File tree

src/murfey/server/feedback.py

Lines changed: 27 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,7 @@ def _downscaled_box_size(
10901090
raise ValueError(f"Box size is too large: {box_size}")
10911091

10921092

1093-
def _resize_intial_model(
1093+
def _resize_initial_model(
10941094
downscaled_box_size: int,
10951095
downscaled_pixel_size: float,
10961096
input_path: Path,
@@ -1203,7 +1203,7 @@ def _register_3d_batch(message: dict, _db):
12031203
/ f"{provided_initial_model.stem}_rescaled_{pj_id}{provided_initial_model.suffix}"
12041204
)
12051205
if not rescaled_initial_model_path.is_file():
1206-
_resize_intial_model(
1206+
_resize_initial_model(
12071207
*_downscaled_box_size(
12081208
relion_options["particle_diameter"],
12091209
relion_options["angpix"],
@@ -1213,33 +1213,32 @@ def _register_3d_batch(message: dict, _db):
12131213
machine_config.external_executables,
12141214
machine_config.external_environment,
12151215
)
1216-
feedback_params.initial_model = str(rescaled_initial_model_path)
1217-
other_options["initial_model"] = str(rescaled_initial_model_path)
1218-
next_job = feedback_params.next_job
1219-
class3d_dir = (
1220-
f"{class3d_message['class3d_dir']}{(feedback_params.next_job + 1):03}"
1221-
)
1222-
feedback_params.next_job += 1
1223-
_db.add(feedback_params)
1224-
_db.commit()
1216+
feedback_params.initial_model = str(rescaled_initial_model_path)
1217+
other_options["initial_model"] = str(rescaled_initial_model_path)
1218+
class3d_dir = (
1219+
f"{class3d_message['class3d_dir']}{(feedback_params.next_job + 1):03}"
1220+
)
1221+
feedback_params.next_job += 1
1222+
_db.add(feedback_params)
1223+
_db.commit()
12251224

1226-
class3d_grp_uuid = _murfey_id(message["program_id"], _db)[0]
1227-
class_uuids = _murfey_id(message["program_id"], _db, number=4)
1228-
class3d_params = db.Class3DParameters(
1229-
pj_id=pj_id,
1230-
murfey_id=class3d_grp_uuid,
1231-
particles_file=class3d_message["particles_file"],
1232-
class3d_dir=class3d_dir,
1233-
batch_size=class3d_message["batch_size"],
1234-
)
1235-
_db.add(class3d_params)
1236-
_db.commit()
1237-
_murfey_class3ds(
1238-
class_uuids,
1239-
class3d_message["particles_file"],
1240-
message["program_id"],
1241-
_db,
1242-
)
1225+
class3d_grp_uuid = _murfey_id(message["program_id"], _db)[0]
1226+
class_uuids = _murfey_id(message["program_id"], _db, number=4)
1227+
class3d_params = db.Class3DParameters(
1228+
pj_id=pj_id,
1229+
murfey_id=class3d_grp_uuid,
1230+
particles_file=class3d_message["particles_file"],
1231+
class3d_dir=class3d_dir,
1232+
batch_size=class3d_message["batch_size"],
1233+
)
1234+
_db.add(class3d_params)
1235+
_db.commit()
1236+
_murfey_class3ds(
1237+
class_uuids,
1238+
class3d_message["particles_file"],
1239+
message["program_id"],
1240+
_db,
1241+
)
12431242

12441243
if feedback_params.hold_class3d:
12451244
# If waiting then save the message

0 commit comments

Comments
 (0)