Skip to content

Commit e6be925

Browse files
committed
Remove vestigial try block and fix runtime issue where None[] or None.get() was being called
1 parent ff3679c commit e6be925

1 file changed

Lines changed: 31 additions & 31 deletions

File tree

src/workflows/services/common_service.py

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -192,40 +192,40 @@ def start_transport(self):
192192
self.transport.subscription_callback_set_intercept(
193193
self._transport_interceptor
194194
)
195-
try:
196-
# Configure OTELTracing if configuration is available
197-
otel_config = (
198-
self.config._opentelemetry if self.config and hasattr(self.config, "opentelemetry") else None
199-
)
200-
201-
if otel_config and "timeout" not in otel_config:
202-
self.log.warning("Missing optional OTEL configuration field `timeout`. Will default to 10 seconds. ")
203-
204-
# Configure OTELTracing
205-
resource = Resource.create(
206-
{
207-
SERVICE_NAME: self._service_name,
208-
}
209-
)
195+
196+
# Configure OTELTracing if configuration is available
197+
otel_config = (
198+
self.config._opentelemetry if self.config and hasattr(self.config, "opentelemetry") else None
199+
)
200+
201+
if otel_config and "timeout" not in otel_config:
202+
self.log.warning("Missing optional OTEL configuration field `timeout`. Will default to 10 seconds. ")
203+
204+
# Configure OTELTracing
205+
resource = Resource.create(
206+
{
207+
SERVICE_NAME: self._service_name,
208+
}
209+
)
210210

211-
self.log.debug("Configuring OTELTracing")
212-
provider = TracerProvider(resource=resource)
213-
trace.set_tracer_provider(provider)
211+
self.log.debug("Configuring OTELTracing")
212+
provider = TracerProvider(resource=resource)
213+
trace.set_tracer_provider(provider)
214214

215-
# Configure BatchProcessor and OTLPSpanExporter using config values
216-
otlp_exporter = OTLPSpanExporter(
217-
endpoint=otel_config["endpoint"],
218-
timeout=otel_config.get("timeout", 10),
219-
)
220-
span_processor = BatchSpanProcessor(otlp_exporter)
221-
provider.add_span_processor(span_processor)
215+
# Configure BatchProcessor and OTLPSpanExporter using config values
216+
otlp_exporter = OTLPSpanExporter(
217+
endpoint=otel_config["endpoint"],
218+
timeout=otel_config.get("timeout", 10),
219+
)
220+
span_processor = BatchSpanProcessor(otlp_exporter)
221+
provider.add_span_processor(span_processor)
222222

223-
# Add OTELTracingMiddleware to the transport layer
224-
tracer = trace.get_tracer(__name__)
225-
otel_middleware = OTELTracingMiddleware(
226-
tracer, service_name=self._service_name
227-
)
228-
self._transport.add_middleware(otel_middleware)
223+
# Add OTELTracingMiddleware to the transport layer
224+
tracer = trace.get_tracer(__name__)
225+
otel_middleware = OTELTracingMiddleware(
226+
tracer, service_name=self._service_name
227+
)
228+
self._transport.add_middleware(otel_middleware)
229229

230230
metrics = self._environment.get("metrics")
231231
if metrics:

0 commit comments

Comments
 (0)