Fix dual-read mismatches and ZodError on discourse node parse

Author: sid597

apps/roam/src/components/settings/AdminPanel.tsx

@@ -277,7 +277,7 @@ const FeatureFlagsTab = (): React.ReactElement => {
   }, []);
 
   const [suggestiveModeEnabled, setSuggestiveModeEnabled] = useState(
-    getFeatureFlag("Suggestive mode enabled"),
+    () => getFeatureFlag("Suggestive mode enabled"),
   );
   const [suggestiveModeUid, setSuggestiveModeUid] = useState(
     legacySuggestiveModeMeta.suggestiveModeEnabledUid,

apps/roam/src/components/settings/components/BlockPropSettingPanels.tsx

@@ -232,7 +232,10 @@ const BaseFlagPanel = ({
     await syncFlagToBlock(checked);
     refreshConfigTree();
     setter(settingKeys, checked);
-    onChange?.(checked);
+    // Delay onChange to let the async Roam block.update flush before
+    // the re-render reads block props via dual-read comparison.
+    // TODO(ENG-1471): remove with dual-read cleanup
+    setTimeout(() => onChange?.(checked), 100);
   };
 
   return (

apps/roam/src/components/settings/utils/accessors.ts

@@ -568,7 +568,7 @@ const getLegacyDiscourseNodeSetting = (
       enabled: specificationUid
         ? getBasicTreeByParentUid(specificationUid).some(
             (c) => c.text === "enabled",
-          ) || specificationQuery.conditions.length > 0
+          )
         : false,
       query: specificationQuery,
     },
@@ -936,11 +936,13 @@ export const setPersonalSetting = (keys: string[], value: json): void => {
   });
 };
 
-const getRawDiscourseNodeBlockProps = (nodeType: string): json | undefined => {
+const getRawDiscourseNodeBlockProps = (
+  nodeType: string,
+): Record<string, json> | undefined => {
   let pageUid = nodeType;
   let blockProps = getBlockPropsByUid(pageUid, []);
 
-  if (!blockProps || Object.keys(blockProps).length === 0) {
+  if (!isRecord(blockProps) || Object.keys(blockProps).length === 0) {
     const lookedUpUid = getPageUidByPageTitle(
       `${DISCOURSE_NODE_PAGE_PREFIX}${nodeType}`,
     );
@@ -950,7 +952,9 @@ const getRawDiscourseNodeBlockProps = (nodeType: string): json | undefined => {
     }
   }
 
-  return blockProps;
+  return isRecord(blockProps) && Object.keys(blockProps).length > 0
+    ? (blockProps as Record<string, json>)
+    : undefined;
 };
 
 export const getDiscourseNodeSettings = (