ENG-1484: drop reload prompts — reactivity is unconditional via dual-write

Author: sid597

apps/roam/src/components/settings/AdminPanel.tsx

@@ -18,7 +18,6 @@ import { setSetting } from "~/utils/extensionSettings";
 import {
   getFeatureFlag,
   setFeatureFlag,
-  isNewSettingsStoreEnabled,
 } from "~/components/settings/utils/accessors";
 import {
   onSettingChange,
@@ -372,7 +371,6 @@ const FeatureFlagsTab = (): React.ReactElement => {
   );
   const [isAlertOpen, setIsAlertOpen] = useState(false);
   const [isInstructionOpen, setIsInstructionOpen] = useState(false);
-  const isReactive = isNewSettingsStoreEnabled();
 
   return (
     <div className="flex flex-col gap-4 p-4">
@@ -432,24 +430,14 @@ const FeatureFlagsTab = (): React.ReactElement => {
 
       <Alert
         isOpen={isInstructionOpen}
-        onConfirm={() =>
-          isReactive ? setIsInstructionOpen(false) : window.location.reload()
-        }
-        onCancel={isReactive ? undefined : () => setIsInstructionOpen(false)}
-        confirmButtonText={isReactive ? "OK" : "Reload Graph"}
-        cancelButtonText={isReactive ? undefined : "Later"}
+        onConfirm={() => setIsInstructionOpen(false)}
+        confirmButtonText="OK"
         intent={Intent.PRIMARY}
       >
         <p>
           If this is the first time enabling it, you will need to generate and
           upload all node embeddings to supabase.
         </p>
-        {!isReactive && (
-          <p>
-            Please reload the graph to see the new &apos;Suggestive Mode&apos;
-            tab.
-          </p>
-        )}
         <p>
           Go to Suggestive Mode{" "}
           {"-> Sync Config -> Click on 'Generate & Upload All Node Embeddings'"}

apps/roam/src/components/settings/HomePersonalSettings.tsx

@@ -26,10 +26,7 @@ import { setSetting } from "~/utils/extensionSettings";
 import { enablePostHog, disablePostHog } from "~/utils/posthog";
 import KeyboardShortcutInput from "./KeyboardShortcutInput";
 import streamlineStyling from "~/styles/streamlineStyling";
-import {
-  getFeatureFlag,
-  isNewSettingsStoreEnabled,
-} from "~/components/settings/utils/accessors";
+import { getFeatureFlag } from "~/components/settings/utils/accessors";
 import { PersonalFlagPanel } from "./components/BlockPropSettingPanels";
 import posthog from "posthog-js";
 
@@ -41,16 +38,12 @@ const HomePersonalSettings = ({ onloadArgs }: { onloadArgs: OnloadArgs }) => {
     <div className="flex flex-col gap-4 p-1">
       <Label>
         Personal node menu trigger
-        <Description
-          description={`Override the global trigger for the discourse node menu.${isNewSettingsStoreEnabled() ? "" : " Must refresh after editing."}`}
-        />
+        <Description description="Override the global trigger for the discourse node menu." />
         <NodeMenuTriggerComponent extensionAPI={extensionAPI} />
       </Label>
       <Label>
         Node search menu trigger
-        <Description
-          description={`Set the trigger character for the node search menu.${isNewSettingsStoreEnabled() ? "" : " Must refresh after editing."}`}
-        />
+        <Description description="Set the trigger character for the node search menu." />
         <NodeSearchMenuTriggerSetting onloadArgs={onloadArgs} />
       </Label>
       <KeyboardShortcutInput