ENG-1478: extract emitter key constants, fix stale TODO

Author: sid597

apps/roam/src/components/LeftSidebarView.tsx

@@ -22,7 +22,10 @@ import getPageUidByPageTitle from "roamjs-components/queries/getPageUidByPageTit
 import openBlockInSidebar from "roamjs-components/writes/openBlockInSidebar";
 import extractRef from "roamjs-components/util/extractRef";
 import { getFormattedConfigTree, notify } from "~/utils/discourseConfigRef";
-import { onSettingChange } from "~/components/settings/utils/settingsEmitter";
+import {
+  onSettingChange,
+  settingKeys,
+} from "~/components/settings/utils/settingsEmitter";
 import {
   type LeftSidebarConfig,
   type LeftSidebarPersonalSectionConfig,
@@ -343,9 +346,12 @@ export const useConfig = () => {
       refreshConfigTree();
       setConfig(buildConfig());
     };
-    const unsubGlobal = onSettingChange("global:Left sidebar", handleUpdate);
+    const unsubGlobal = onSettingChange(
+      settingKeys.globalLeftSidebar,
+      handleUpdate,
+    );
     const unsubPersonal = onSettingChange(
-      "personal:Left sidebar",
+      settingKeys.personalLeftSidebar,
       handleUpdate,
     );
     return () => {
@@ -356,9 +362,9 @@ export const useConfig = () => {
   return { config, setConfig };
 };
 
-// TODO(ENG-1471): refreshAndNotify still needed for other subscribe() consumers
-// (PanelManager, Canvas). Left sidebar reactivity now uses emitter, but other
-// components still depend on notify(). Remove when all consumers migrate to emitter.
+// TODO(ENG-1471): refreshAndNotify still needed by settings panels
+// (LeftSidebarGlobalSettings, LeftSidebarPersonalSettings) for old-system CRUD.
+// Remove when settings panels also read via accessors + emitter.
 export const refreshAndNotify = () => {
   refreshConfigTree();
   notify();

apps/roam/src/components/settings/utils/pullWatchers.ts

@@ -12,7 +12,7 @@ import {
   type PersonalSettings,
   type DiscourseNodeSettings,
 } from "./zodSchema";
-import { emitSettingChange } from "./settingsEmitter";
+import { emitSettingChange, settingKeys } from "./settingsEmitter";
 
 type PullWatchCallback = Parameters<AddPullWatch>[2];
 
@@ -93,7 +93,7 @@ export const featureFlagHandlers: Partial<
 > = {
   /* eslint-disable @typescript-eslint/naming-convention */
   "Enable left sidebar": (newValue, oldValue) => {
-    emitSettingChange("Enable left sidebar", newValue, oldValue);
+    emitSettingChange(settingKeys.leftSidebarFlag, newValue, oldValue);
   },
   /* eslint-enable @typescript-eslint/naming-convention */
 };
@@ -109,7 +109,7 @@ type GlobalSettingsHandlers = {
 export const globalSettingsHandlers: GlobalSettingsHandlers = {
   /* eslint-disable @typescript-eslint/naming-convention */
   "Left sidebar": (newValue, oldValue) => {
-    emitSettingChange("global:Left sidebar", newValue, oldValue);
+    emitSettingChange(settingKeys.globalLeftSidebar, newValue, oldValue);
   },
   /* eslint-enable @typescript-eslint/naming-convention */
 };
@@ -125,7 +125,7 @@ type PersonalSettingsHandlers = {
 export const personalSettingsHandlers: PersonalSettingsHandlers = {
   /* eslint-disable @typescript-eslint/naming-convention */
   "Left sidebar": (newValue, oldValue) => {
-    emitSettingChange("personal:Left sidebar", newValue, oldValue);
+    emitSettingChange(settingKeys.personalLeftSidebar, newValue, oldValue);
   },
   /* eslint-enable @typescript-eslint/naming-convention */
 };

apps/roam/src/components/settings/utils/settingsEmitter.ts

@@ -1,5 +1,11 @@
 type SettingChangeCallback = (newValue: unknown, oldValue: unknown) => void;
 
+export const settingKeys = {
+  leftSidebarFlag: "Enable left sidebar",
+  globalLeftSidebar: "global:Left sidebar",
+  personalLeftSidebar: "personal:Left sidebar",
+} as const;
+
 const listeners = new Map<string, Set<SettingChangeCallback>>();
 
 export const onSettingChange = (

apps/roam/src/index.ts

@@ -39,7 +39,10 @@ import {
   getPersonalSetting,
 } from "./components/settings/utils/accessors";
 import { setupPullWatchOnSettingsPage } from "./components/settings/utils/pullWatchers";
-import { onSettingChange } from "./components/settings/utils/settingsEmitter";
+import {
+  onSettingChange,
+  settingKeys,
+} from "./components/settings/utils/settingsEmitter";
 import { mountLeftSidebar } from "./components/LeftSidebarView";
 
 export const DEFAULT_CANVAS_PAGE_FORMAT = "Canvas/*";
@@ -154,7 +157,7 @@ export default runExtension(async (onloadArgs) => {
   }
 
   const unsubLeftSidebarFlag = onSettingChange(
-    "Enable left sidebar",
+    settingKeys.leftSidebarFlag,
     (newValue) => {
       const enabled = Boolean(newValue);
       const wrapper = document.querySelector<HTMLDivElement>(