Skip to content

Commit 506c385

Browse files
committed
Refactor equals and hashCode tests for Split and TestCase classes
1 parent 45bc51f commit 506c385

3 files changed

Lines changed: 3 additions & 10 deletions

File tree

src/main/java/de/donnerbart/split/model/Split.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import java.util.Set;
1313
import java.util.stream.Collectors;
1414

15-
public class Split implements Comparable<Split> {
15+
public final class Split implements Comparable<Split> {
1616

1717
private final @NotNull Set<TestCase> tests = new HashSet<>();
1818
private final @NotNull FormatOption formatOption;

src/test/java/de/donnerbart/split/model/SplitTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@
33
import nl.jqno.equalsverifier.EqualsVerifier;
44
import org.junit.jupiter.api.Test;
55

6-
import static nl.jqno.equalsverifier.Warning.ALL_FIELDS_SHOULD_BE_USED;
7-
import static nl.jqno.equalsverifier.Warning.STRICT_INHERITANCE;
8-
96
class SplitTest {
107

118
@Test
129
void test_equalsAndHashCode() {
13-
EqualsVerifier.forClass(Split.class).suppress(STRICT_INHERITANCE).suppress(ALL_FIELDS_SHOULD_BE_USED).verify();
10+
EqualsVerifier.forClass(Split.class).withOnlyTheseFields("index").verify();
1411
}
1512
}

src/test/java/de/donnerbart/split/model/TestCaseTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@
33
import nl.jqno.equalsverifier.EqualsVerifier;
44
import org.junit.jupiter.api.Test;
55

6-
import static nl.jqno.equalsverifier.Warning.ALL_FIELDS_SHOULD_BE_USED;
76
import static nl.jqno.equalsverifier.Warning.STRICT_INHERITANCE;
87

98
class TestCaseTest {
109

1110
@Test
1211
void test_equalsAndHashCode() {
13-
EqualsVerifier.forClass(TestCase.class)
14-
.suppress(STRICT_INHERITANCE)
15-
.suppress(ALL_FIELDS_SHOULD_BE_USED)
16-
.verify();
12+
EqualsVerifier.forClass(TestCase.class).withOnlyTheseFields("name").verify();
1713
}
1814
}

0 commit comments

Comments
 (0)