fix some shell lint errors

Author: h4x3rotab

attestation/configid-based/attest.sh

@@ -91,7 +91,8 @@ download_command() {
     # Download and extract image
     echo "Downloading Dstack image..."
     local image_url="${IMAGE_DL_URL}"
-    local image_filename="$(basename "${image_url}")"
+    local image_filename
+    image_filename="$(basename "${image_url}")"
     local image_path="${IMAGES_DIR}/${image_filename}"
 
     echo "Downloading image from ${image_url}"
@@ -186,7 +187,7 @@ calc_mrs_command() {
 
     # Run dstack-mr with metadata.json from the image
     echo "Running dstack-mr to calculate MRs..."
-    ${TOOLS_DIR}/dstack-mr -metadata "${IMAGES_DIR}/dstack-${IMAGE_VERSION}/metadata.json" \
+    "${TOOLS_DIR}/dstack-mr" -metadata "${IMAGES_DIR}/dstack-${IMAGE_VERSION}/metadata.json" \
                        -cpu ${VCPU_COUNT} \
                        -memory "${MEM_SIZE}M" \
                        -json > "known_good_mrs.json.tmp"
@@ -245,7 +246,7 @@ EOF
             if [ -n "$instance_id" ]; then
                 echo "✅ App started successfully!"
                 echo "Instance ID: $instance_id"
-                echo $instance_id > instance_id.txt
+                echo "$instance_id" > instance_id.txt
                 break
             fi
             # Check for boot errors

custom-domain/dstack-ingress/build-image.sh

@@ -10,6 +10,6 @@ if ! docker buildx inspect buildkit_20 &>/dev/null; then
 fi
 touch pinned-packages.txt
 git rev-parse HEAD > .GIT_REV
-docker buildx build --builder buildkit_20 --no-cache --build-arg SOURCE_DATE_EPOCH="0" --output type=docker,name=$NAME,rewrite-timestamp=true .
-docker run --rm --entrypoint bash $NAME -c "dpkg -l | grep '^ii' |awk '{print \$2\"=\"\$3}' | sort" > pinned-packages.txt
+docker buildx build --builder buildkit_20 --no-cache --build-arg SOURCE_DATE_EPOCH="0" --output type=docker,name="$NAME",rewrite-timestamp=true .
+docker run --rm --entrypoint bash "$NAME" -c "dpkg -l | grep '^ii' |awk '{print \$2\"=\"\$3}' | sort" > pinned-packages.txt
 rm .GIT_REV

custom-domain/dstack-ingress/scripts/entrypoint.sh

@@ -80,9 +80,9 @@ obtain_certificate() {
     certbot certonly --dns-cloudflare \
         --dns-cloudflare-credentials ~/.cloudflare/cloudflare.ini \
         --dns-cloudflare-propagation-seconds 120 \
-        --email $CERTBOT_EMAIL \
+        --email "$CERTBOT_EMAIL" \
         --agree-tos --no-eff-email --non-interactive \
-        -d $DOMAIN
+        -d "$DOMAIN"
 }
 
 set_cname_record() {

custom-domain/dstack-ingress/scripts/generate-evidences.sh

@@ -6,8 +6,8 @@ CERT_FILE=/etc/letsencrypt/live/${DOMAIN}/fullchain.pem
 
 mkdir -p /evidences
 cd /evidences
-cp ${ACME_ACCOUNT_FILE} acme-account.json
-cp ${CERT_FILE} cert.pem
+cp "${ACME_ACCOUNT_FILE}" acme-account.json
+cp "${CERT_FILE}" cert.pem
 
 sha256sum acme-account.json cert.pem > sha256sum.txt
 
@@ -20,5 +20,5 @@ while [ ${#PADDED_HASH} -lt 128 ]; do
 done
 QUOTED_HASH="${PADDED_HASH}"
 
-curl -s --unix-socket /var/run/tappd.sock http://localhost/prpc/Tappd.RawQuote?report_data=${QUOTED_HASH} > quote.json
+curl -s --unix-socket /var/run/tappd.sock "http://localhost/prpc/Tappd.RawQuote?report_data=${QUOTED_HASH}" > quote.json
 echo "Generated evidences successfully"

launcher/build-image.sh

@@ -10,6 +10,6 @@ if ! docker buildx inspect buildkit_20 &>/dev/null; then
 fi
 touch pinned-packages.txt
 git rev-parse HEAD > .GIT_REV
-docker buildx build --platform linux/amd64 --builder buildkit_20 --no-cache --build-arg SOURCE_DATE_EPOCH="0" --output type=docker,name=$NAME,rewrite-timestamp=true .
-docker run --rm --entrypoint bash $NAME -c "dpkg -l | grep '^ii' |awk '{print \$2\"=\"\$3}' | sort" > pinned-packages.txt
-rm .GIT_REV
+docker buildx build --platform linux/amd64 --builder buildkit_20 --no-cache --build-arg SOURCE_DATE_EPOCH="0" --output "type=docker,name=$NAME,rewrite-timestamp=true" .
+docker run --rm --entrypoint bash "$NAME" -c "dpkg -l | grep '^ii' |awk '{print \$2\"=\"\$3}' | sort" > pinned-packages.txt
+rm .GIT_REV

launcher/entrypoint.sh

@@ -6,7 +6,7 @@ EXTERNAL_PORT=10080
 SERVICE_NAME=server
 
 
-cd $WORKDIR
+cd $WORKDIR || exit
 
 check-update() {
     echo "Checking for updates..."

launcher/get-latest.sh

@@ -29,8 +29,8 @@ MINUTE=$(date +%-M)
 # Use time-based selection instead of random to create more predictable upgrade patterns
 # This will switch images roughly every minute
 if [ $((MINUTE % 2)) -eq 0 ]; then
-    echo "nginx@sha256:d67fed8b03f1ed3d2a5e3cbc5ca268ad7a7528adfdd1220c420c8cf4e3802d9c" > $OUTPUT
+    echo "nginx@sha256:d67fed8b03f1ed3d2a5e3cbc5ca268ad7a7528adfdd1220c420c8cf4e3802d9c" > "$OUTPUT"
 else
-    echo "nginx@sha256:81aa342ba08035632898b78d46d0e11d79abeee63b3a6994a44ac34e102ef888" > $OUTPUT
+    echo "nginx@sha256:81aa342ba08035632898b78d46d0e11d79abeee63b3a6994a44ac34e102ef888" > "$OUTPUT"
 fi
 

phala-cloud-prelaunch-script/prelaunch.sh

@@ -112,7 +112,7 @@ elif [[ -n "$DSTACK_AWS_ACCESS_KEY_ID" && -n "$DSTACK_AWS_SECRET_ACCESS_KEY" &&
     fi
 
     echo "Logging in to AWS ECR..."
-    aws ecr get-login-password --region $DSTACK_AWS_REGION | docker login --username AWS --password-stdin "$DSTACK_AWS_ECR_REGISTRY"
+    aws ecr get-login-password --region "$DSTACK_AWS_REGION" | docker login --username AWS --password-stdin "$DSTACK_AWS_ECR_REGISTRY"
     if [ $? -eq 0 ]; then
         echo "AWS ECR login successful"
         notify_host_hoot_info "AWS ECR login successful"
@@ -142,17 +142,21 @@ fi
 
 
 if [[ -e /var/run/dstack.sock ]]; then
-    export DSTACK_APP_ID=$(curl -s --unix-socket /var/run/dstack.sock http://dstack/Info | jq -j .app_id)
+    DSTACK_APP_ID=$(curl -s --unix-socket /var/run/dstack.sock http://dstack/Info | jq -j .app_id)
+    export DSTACK_APP_ID
 else
-    export DSTACK_APP_ID=$(curl -s --unix-socket /var/run/tappd.sock http://dstack/prpc/Tappd.Info | jq -j .app_id)
+    DSTACK_APP_ID=$(curl -s --unix-socket /var/run/tappd.sock http://dstack/prpc/Tappd.Info | jq -j .app_id)
+    export DSTACK_APP_ID
 fi
 # Check if app-compose.json has default_gateway_domain field and DSTACK_GATEWAY_DOMAIN is not set
 # If true, set DSTACK_GATEWAY_DOMAIN from app-compose.json
 if [[ $(jq 'has("default_gateway_domain")' app-compose.json) == "true" && -z "$DSTACK_GATEWAY_DOMAIN" ]]; then
-    export DSTACK_GATEWAY_DOMAIN=$(jq -j '.default_gateway_domain' app-compose.json)
+    DSTACK_GATEWAY_DOMAIN=$(jq -j '.default_gateway_domain' app-compose.json)
+    export DSTACK_GATEWAY_DOMAIN
 fi
 if [[ -n "$DSTACK_GATEWAY_DOMAIN" ]]; then
-    export DSTACK_APP_DOMAIN=$DSTACK_APP_ID"."$DSTACK_GATEWAY_DOMAIN
+    DSTACK_APP_DOMAIN=$DSTACK_APP_ID"."$DSTACK_GATEWAY_DOMAIN
+    export DSTACK_APP_DOMAIN
 fi
 
 echo "----------------------------------------------"