Skip to content

Commit 2ddfa70

Browse files
committed
rimport main() tests: Avoid magic booleans.
1 parent 07aedeb commit 2ddfa70

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

tests/rimport/test_main.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ def test_single_file_success(
6060
# Verify
6161
assert result == 0
6262
mock_normalize_paths.assert_called_once_with(inputdata_root, ["test.nc"])
63+
check = False
6364
mock_stage_data.assert_called_once_with(
64-
test_file, inputdata_root, staging_root, False
65+
test_file, inputdata_root, staging_root, check
6566
)
6667
assert "No need to run relink.py" in caplog.text
6768

@@ -106,10 +107,11 @@ def test_file_list_success(
106107
inputdata_root, ["file1.nc", "file2.nc"]
107108
)
108109
assert mock_stage_data.call_count == 2
110+
check = False
109111
mock_stage_data.assert_has_calls(
110112
[
111-
call(file1, inputdata_root, staging_root, False),
112-
call(file2, inputdata_root, staging_root, False),
113+
call(file1, inputdata_root, staging_root, check),
114+
call(file2, inputdata_root, staging_root, check),
113115
]
114116
)
115117

@@ -252,8 +254,9 @@ def test_check_mode_calls(
252254
# ensure_running_as should NOT be called in check mode
253255
mock_ensure_running_as.assert_not_called()
254256
# stage_data should be called with check=True
257+
check = True
255258
mock_stage_data.assert_called_once_with(
256-
test_file, inputdata_root, staging_root, True
259+
test_file, inputdata_root, staging_root, check
257260
)
258261
# Message about relink.py should not have been printed
259262
assert "No need to run relink.py" not in caplog.text

0 commit comments

Comments
 (0)