relink: Move inputdata_root args to shared function and use that.

Author: samsrabin

relink.py

@@ -17,6 +17,7 @@
     DEFAULT_STAGING_ROOT,
     get_log_level,
     add_parser_verbosity_group,
+    add_inputdata_root,
     validate_paths,
     validate_directory,
 )
@@ -316,18 +317,8 @@ def parse_arguments():
         ),
     )
 
-    # The root of the directory tree containing CESM input data.
-    # ONLY INTENDED FOR USE IN TESTING
-    parser.add_argument(
-        "--inputdata-root",
-        "-inputdata-root",
-        "--inputdata",
-        "-inputdata",
-        "-i",
-        type=validate_directory,
-        default=DEFAULT_INPUTDATA_ROOT,
-        help=argparse.SUPPRESS,
-    )
+    # Add inputdata_root option flags
+    add_inputdata_root(parser)
 
     # Add verbosity options
     add_parser_verbosity_group(parser)

shared.py

@@ -32,6 +32,27 @@ def get_log_level(quiet: bool = False, verbose: bool = False) -> int:
     return logging.INFO
 
 
+def add_inputdata_root(parser: argparse.ArgumentParser):
+    """Add inputdata_root option to an argument parser.
+
+    The root of the directory tree containing CESM input data. Only intended for use in testing, so
+    help is suppressed.
+
+    Args:
+        parser: ArgumentParser instance to add the inputdata_root arg to.
+    """
+    parser.add_argument(
+        "--inputdata-root",
+        "-inputdata-root",
+        "--inputdata",
+        "-inputdata",
+        "-i",
+        type=validate_directory,
+        default=DEFAULT_INPUTDATA_ROOT,
+        help=argparse.SUPPRESS,
+    )
+
+
 def add_parser_verbosity_group(parser: argparse.ArgumentParser):
     """Add mutually exclusive verbosity options to an argument parser.
 

tests/relink/conftest.py

@@ -18,7 +18,9 @@ def fixture_temp_dirs():
 
     with patch("relink.DEFAULT_INPUTDATA_ROOT", source_dir):
         with patch("relink.DEFAULT_STAGING_ROOT", target_dir):
-            yield source_dir, target_dir
+            with patch("shared.DEFAULT_INPUTDATA_ROOT", source_dir):
+                with patch("shared.DEFAULT_STAGING_ROOT", target_dir):
+                    yield source_dir, target_dir
 
     # Cleanup
     shutil.rmtree(source_dir, ignore_errors=True)