rimport: configure_logging() now requires level.

Author: samsrabin

rimport

@@ -327,7 +327,7 @@ def print_can_file_be_downloaded(file_can_be_downloaded: bool):
         logger.info("%sFile is not (yet) available for download.", INDENT)
 
 
-def configure_logging(log_level: int = logging.INFO) -> None:
+def configure_logging(log_level: int) -> None:
     """Configure logging to send INFO/WARNING to stdout and ERROR/CRITICAL to stderr.
 
     Sets up two handlers:
@@ -337,7 +337,7 @@ def configure_logging(log_level: int = logging.INFO) -> None:
     Both handlers use simple message-only formatting without timestamps or level names.
 
     Args:
-        log_level: Minimum logging level (DEBUG, INFO, or WARNING). Default is INFO.
+        log_level: Minimum logging level (DEBUG, INFO, or WARNING).
     """
     logger.setLevel(log_level)
 

tests/rimport/test_configure_logging.py

@@ -35,17 +35,17 @@ def cleanup_logger(self):
 
     def test_sets_logger_level_to_info(self):
         """Test that configure_logging sets the logger level to INFO."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         assert rimport.logger.level == logging.INFO
 
     def test_creates_two_handlers(self):
         """Test that configure_logging creates exactly two handlers."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         assert len(rimport.logger.handlers) == 2
 
     def test_info_handler_goes_to_stdout(self, capsys):
         """Test that INFO level messages go to stdout."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         rimport.logger.info("Test info message")
 
         captured = capsys.readouterr()
@@ -54,7 +54,7 @@ def test_info_handler_goes_to_stdout(self, capsys):
 
     def test_warning_handler_goes_to_stdout(self, capsys):
         """Test that WARNING level messages go to stdout."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         rimport.logger.warning("Test warning message")
 
         captured = capsys.readouterr()
@@ -63,7 +63,7 @@ def test_warning_handler_goes_to_stdout(self, capsys):
 
     def test_error_handler_goes_to_stderr(self, capsys):
         """Test that ERROR level messages go to stderr."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         rimport.logger.error("Test error message")
 
         captured = capsys.readouterr()
@@ -72,22 +72,13 @@ def test_error_handler_goes_to_stderr(self, capsys):
 
     def test_critical_handler_goes_to_stderr(self, capsys):
         """Test that CRITICAL level messages go to stderr."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         rimport.logger.critical("Test critical message")
 
         captured = capsys.readouterr()
         assert captured.out == ""
         assert "Test critical message" in captured.err
 
-    def test_debug_messages_not_logged_if_info(self, capsys):
-        """Test that DEBUG level messages are not logged if logger level is INFO."""
-        rimport.configure_logging()
-        rimport.logger.debug("Test debug message")
-
-        captured = capsys.readouterr()
-        assert captured.out == ""
-        assert captured.err == ""
-
     def test_clears_existing_handlers(self):
         """Test that configure_logging clears any existing handlers."""
         # Add a dummy handler
@@ -97,15 +88,15 @@ def test_clears_existing_handlers(self):
         assert len(rimport.logger.handlers) >= 1
 
         # Configure logging
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
 
         # Verify old handlers were cleared and new ones added
         assert len(rimport.logger.handlers) == 2
         assert dummy_handler not in rimport.logger.handlers
 
     def test_formatter_uses_message_only(self, capsys):
         """Test that the formatter outputs only the message without level/timestamp."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         rimport.logger.info("Simple message")
 
         captured = capsys.readouterr()
@@ -115,13 +106,13 @@ def test_formatter_uses_message_only(self, capsys):
 
     def test_multiple_calls_dont_duplicate_handlers(self):
         """Test that calling configure_logging multiple times doesn't duplicate handlers."""
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         assert len(rimport.logger.handlers) == 2
 
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         assert len(rimport.logger.handlers) == 2  # Still 2, not 4
 
-        rimport.configure_logging()
+        rimport.configure_logging(logging.INFO)
         assert len(rimport.logger.handlers) == 2  # Still 2, not 6
 
     def test_configure_with_debug_level(self, capsys):
@@ -158,4 +149,3 @@ def test_configure_with_info_level_suppresses_debug(self, capsys):
 
         captured = capsys.readouterr()
         assert "Debug message" not in captured.out
-        assert "Info message" in captured.out