rimport: Default inputdata root is now a module-level var.

Author: samsrabin

rimport

@@ -16,6 +16,7 @@ import sys
 from pathlib import Path
 from typing import Iterable, List
 
+DEFAULT_SOURCE_ROOT = Path("/glade/campaign/cesm/cesmdata/cseg/inputdata")
 DEFAULT_STAGING_ROOT = Path(
     "/glade/campaign/collections/gdex/data/d651077/cesmdata/inputdata"
 )
@@ -49,11 +50,11 @@ def build_parser() -> argparse.ArgumentParser:
         "-inputdata",
         dest="inputdata",
         metavar="inputdata_dir",
-        # TODO: This should be a module-level variable
-        default=os.path.join(
-            "/glade", "campaign", "cesm", "cesmdata", "cseg", "inputdata"
+        default=DEFAULT_SOURCE_ROOT,
+        help=(
+            "Change the default local top level inputdata directory."
+            f" Default: '{DEFAULT_SOURCE_ROOT}'"
         ),
-        help="Change the default local top level inputdata directory.",
     )
 
     return parser

tests/rimport/test_build_parser.py

@@ -72,10 +72,7 @@ def test_inputdata_default(self):
         """Test that -inputdata has correct default value."""
         parser = rimport.build_parser()
         args = parser.parse_args(["-file", "test.txt"])
-        expected_default = os.path.join(
-            "/glade", "campaign", "cesm", "cesmdata", "cseg", "inputdata"
-        )
-        assert args.inputdata == expected_default
+        assert args.inputdata == rimport.DEFAULT_SOURCE_ROOT
 
     def test_inputdata_custom(self):
         """Test that -inputdata can be customized."""