rimport: Default staging root is now a module-level variable.

Author: samsrabin

rimport

@@ -16,6 +16,10 @@ import sys
 from pathlib import Path
 from typing import Iterable, List
 
+DEFAULT_STAGING_ROOT = Path(
+    "/glade/campaign/collections/gdex/data/d651077/cesmdata/inputdata"
+)
+
 
 def build_parser() -> argparse.ArgumentParser:
     parser = argparse.ArgumentParser(
@@ -155,8 +159,7 @@ def get_staging_root() -> Path:
     env = os.getenv("RIMPORT_STAGING")
     if env:
         return Path(env).expanduser().resolve()
-    # TODO: This should be a module-level variable.
-    return Path("/glade/campaign/collections/gdex/data/d651077/cesmdata/inputdata")
+    return DEFAULT_STAGING_ROOT
 
 
 def main(argv: List[str] | None = None) -> int:

tests/rimport/test_get_staging_root.py

@@ -55,10 +55,7 @@ def test_returns_default_when_env_not_set(self):
 
             result = rimport.get_staging_root()
 
-            expected = Path(
-                "/glade/campaign/collections/gdex/data/d651077/cesmdata/inputdata"
-            )
-            assert result == expected
+            assert result == rimport.DEFAULT_STAGING_ROOT
 
     def test_returns_env_value_when_set(self, tmp_path):
         """Test that RIMPORT_STAGING environment variable is used when set."""
@@ -108,8 +105,5 @@ def test_env_value_overrides_default(self, tmp_path):
             result = rimport.get_staging_root()
 
             # Should NOT be the default
-            default = Path(
-                "/glade/campaign/collections/gdex/data/d651077/cesmdata/inputdata"
-            )
-            assert result != default
+            assert result != rimport.DEFAULT_STAGING_ROOT
             assert result == custom_staging.resolve()