fix: TODOs

Author: Justintime50

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Drop support for Node 12, 13, 14, and 15
 - Adds `webhook_secret` and `custom_headers` properties to Typescript definitions of a Webhook
+- `findMatchingMockRequest` mocking function made private
 - Removes undocumented and unmaintained `repl`
 - Bumps dependencies
 

test/helpers/mocking.js

@@ -34,7 +34,7 @@ export class MockMiddleware {
   // eslint-disable-next-line class-methods-use-this,no-unused-vars,consistent-return
   send(body) {
     // we don't need to do anything with the body
-    const mockRequest = this.findMatchingMockRequest(this.request);
+    const mockRequest = this._findMatchingMockRequest(this.request);
     if (mockRequest) {
       this.body = mockRequest.responseInfo.body;
       return mockRequest.responseInfo;
@@ -45,16 +45,18 @@ export class MockMiddleware {
   // eslint-disable-next-line no-unused-vars
   query(params) {
     // we don't need to do anything with the params
-    const mockRequest = this.findMatchingMockRequest(this.request);
+    const mockRequest = this._findMatchingMockRequest(this.request);
     if (mockRequest) {
       this.body = mockRequest.responseInfo.body;
       return mockRequest.responseInfo;
     }
     return {};
   }
 
-  // TODO: Make private in the future
-  findMatchingMockRequest(request) {
+  /**
+   * @private
+   */
+  _findMatchingMockRequest(request) {
     // for each mock request, check if the method and url match
     for (let i = 0; i < this.mockRequests.length; i += 1) {
       const mockRequest = this.mockRequests[i];

test/services/address.test.js

@@ -47,8 +47,7 @@ describe('Address Service', function () {
 
     // Delivery verification assertions
     expect(address.verifications.delivery.success).to.be.false;
-    // TODO: details is not deserializing correctly, related to the larger "double EasyPostObject" wrapping issue
-    // expect(address.verifications.delivery.details).to.equal({});
+    expect(address.verifications.delivery.details).to.not.be.null;
     expect(address.verifications.delivery.errors[0].code).to.equal('E.ADDRESS.NOT_FOUND');
     expect(address.verifications.delivery.errors[0].field).to.equal('address');
     expect(address.verifications.delivery.errors[0].suggestion).to.be.null;

types/PaymentMethod/PaymentMethod.d.ts

@@ -2,8 +2,6 @@ import { IObjectWithId } from '../base';
 
 /**
  * The Payment method object can be either credit card or bank account.
- *
- * TODO: Add the link to the API doc once its updated
  */
 export declare interface IPaymentMethod extends IObjectWithId<'PaymentMethod'> {
   /**

types/errors/ErrorCode.d.ts

@@ -1,4 +1,3 @@
-// TODO: there seems to be a lot of duplicate codes listed here https://www.easypost.com/errors-guide
 export declare type TErrorCode =
   | 'ADDRESS.COUNTRY.INVALID'
   | 'ADDRESS.PARAMETERS.INVALID_CHARACTER'