Skip to content

Commit 1109053

Browse files
ECWID-155668 Add "updateShippingOption" method to ecwid-java-api-client - (refactor) fix detekt: get rid of magic numbers
1 parent b754075 commit 1109053

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
package com.ecwid.apiclient.v3.dto.profile.enums
22

3+
private const val MINUTES_IN_DAY = 1_440 // 24 hours * 60 minutes
4+
private const val MINUTES_IN_MONTH = 43_200 // 30 * MINUTES_IN_DAY
5+
36
@Suppress("unused")
47
enum class AvailabilityPeriodTimeUnit(val valueInMinutes: Int) {
5-
DAYS(24 * 60),
6-
MONTHS(30 * 24 * 60);
8+
DAYS(MINUTES_IN_DAY),
9+
MONTHS(MINUTES_IN_MONTH)
710
}
Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
package com.ecwid.apiclient.v3.dto.profile.enums
22

3+
private const val DAYS_IN_WEEK = 7
4+
private const val SINGLE_UNIT = 1
5+
private const val MONTHS_IN_CENTURY = 1200
6+
37
@Suppress("unused")
48
enum class AvailabilityPeriodType(val unitCount: Int, val unit: AvailabilityPeriodTimeUnit?) {
5-
SEVEN_DAYS(7, AvailabilityPeriodTimeUnit.DAYS),
6-
ONE_MONTH(1, AvailabilityPeriodTimeUnit.MONTHS),
7-
UNLIMITED(1200, AvailabilityPeriodTimeUnit.MONTHS);
9+
SEVEN_DAYS(DAYS_IN_WEEK, AvailabilityPeriodTimeUnit.DAYS),
10+
ONE_MONTH(SINGLE_UNIT, AvailabilityPeriodTimeUnit.MONTHS),
11+
UNLIMITED(MONTHS_IN_CENTURY, AvailabilityPeriodTimeUnit.MONTHS)
812
}

0 commit comments

Comments
 (0)