diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dc57508a10..6ba7e7709ae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased (develop) +- fixed: Say "edit name" instead of "edit settings" on the create/split wallet scene when the listed wallets have no settings to edit + ## 4.51.0 (staging) - added: Push info-server attestation tokens into edge-core-js via `setAttestationToken` so the login server can skip CAPTCHA for attested devices, and allow `LOGIN_SERVER` / `INFO_SERVER` env overrides for local E2E stacks. diff --git a/src/__tests__/scenes/__snapshots__/CreateWalletEditNameScene.test.tsx.snap b/src/__tests__/scenes/__snapshots__/CreateWalletEditNameScene.test.tsx.snap index 0969f4d2a78..d94a5ba47c0 100644 --- a/src/__tests__/scenes/__snapshots__/CreateWalletEditNameScene.test.tsx.snap +++ b/src/__tests__/scenes/__snapshots__/CreateWalletEditNameScene.test.tsx.snap @@ -312,7 +312,7 @@ exports[`CreateWalletEditNameComponent should render with loading props 1`] = ` ] } > - Tap on wallet to edit settings + Tap on wallet to edit name = props => { ) ) + // Tapping a row opens the wallet settings modal, which only shows a name + // field unless the asset declares its own settings (Monero's backend picker). + // Promise settings in the instructions only when a listed wallet has some, + // otherwise the tap does nothing but rename. Splits never qualify, since no + // splittable asset declares wallet settings. + const hasWalletSettings = React.useMemo( + () => + createWalletList.some(item => { + if (item.walletType == null) return false + const settings = SPECIAL_CURRENCY_INFO[item.pluginId]?.walletSettings + return settings != null && settings.length > 0 + }), + [createWalletList] + ) + const handleEditWalletName = useHandler( async (key: string, currentName: string, pluginId: string) => { const result = await Airship.show( @@ -427,7 +442,9 @@ const CreateWalletEditNameComponent: React.FC = props => { )} - {lstrings.fragment_create_wallet_edit_settings_instructions} + {hasWalletSettings + ? lstrings.fragment_create_wallet_edit_settings_instructions + : lstrings.fragment_create_wallet_instructions}