Skip to content

execute() does not dispatch the calldata — proposals have no on-chain effect #30

Description

@Escelit

Description:
Governance::execute validates votes, enforces timelock, marks executed = true, and emits an event. It never actually decodes or dispatches calldata to any target contract. Proposals are therefore symbolic — they cannot update LTV ratios, change oracle weights, or trigger any on-chain state change.

Expected behaviour:
Define a structured Action enum (e.g., UpdateLTV { new_max: u32 }, UpdateOracleWeight { oracle: Address, weight: u32 }). execute should decode calldata into an Action and make the appropriate cross-contract call.

Labels: enhancement, contracts, governance, high-priority

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions