This repository was archived by the owner on Jan 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Expand file tree
/
Copy pathviews.py
More file actions
595 lines (506 loc) · 25.6 KB
/
views.py
File metadata and controls
595 lines (506 loc) · 25.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
# -*- encoding: utf-8 -*-
from django.views import generic as generic_views
from django.views.generic.base import TemplateResponseMixin
from django.shortcuts import get_object_or_404
from django.http import HttpResponseRedirect
from django.contrib import messages
from django.utils.translation import ugettext_lazy as _
from django.core.urlresolvers import reverse
from django.utils.decorators import method_decorator
from django.contrib.auth.decorators import login_required
from django.contrib.admin.views.decorators import staff_member_required
from django.utils.timezone import now
from django.utils.importlib import import_module
from . import models, forms, utils, decorators, settings
from .view_mixins import OrderMappingMixin, PrepareViewMixin
from pyconde.proposals.views import NextRedirectMixin
from pyconde.utils import create_403
from pyconde.conference.models import current_conference
class ListProposalsView(OrderMappingMixin, generic_views.TemplateView):
"""
Lists all proposals the reviewer should be able to review, sorted by
"priority".
This listing should include some filter functionality to filter proposals
by tag, track or kind.
Access: review-team and staff
"""
template_name = 'reviews/reviewable_proposals.html'
order_mapping = {
'comments': 'num_comments',
'reviews': 'num_reviews',
'title': 'proposal__title',
'activity': 'latest_activity_date',
'score': 'score',
}
default_order = 'reviews'
def get_context_data(self, **kwargs):
proposals = self.get_queryset()
my_reviews = models.Review.objects \
.filter(user=self.request.user) \
.select_related('proposal')
reviewed_proposals = [rev.proposal for rev in my_reviews]
for proposal in proposals:
proposal.reviewed = proposal.proposal in reviewed_proposals
return {
'proposals': proposals,
'order': self.get_request_order(),
'filter_form': self.filter_form,
}
def get_request_order(self):
"""
Overrides get_request_order to prevent non-authorized users to
use the score ordering.
"""
order = super(ListProposalsView, self).get_request_order()
if order.lstrip('-') == 'score' and not (self.request.user.is_staff or self.request.user.is_superuser):
return self.get_default_order()
return order
def get_queryset(self):
qs = models.ProposalMetaData.objects \
.select_related('proposal', 'proposal__track',
'proposal__kind',
'latest_proposalversion') \
.only('proposal__kind', 'proposal__track',
'proposal__title', 'proposal__id',
'score', 'num_reviews', 'num_comments',
'latest_proposalversion__id',
'latest_proposalversion__title',
'latest_activity_date',
'latest_comment_date') \
.order_by(self.get_order()) \
.filter(proposal__conference_id=current_conference().id)
if self.filter_form.is_valid():
track_slug = self.filter_form.cleaned_data['track']
kind_slug = self.filter_form.cleaned_data['kind']
if track_slug:
qs = qs.filter(proposal__track__slug=track_slug)
if kind_slug:
qs = qs.filter(proposal__kind__slug=kind_slug)
return qs
@method_decorator(decorators.reviewer_or_staff_required)
def dispatch(self, request, *args, **kwargs):
self.filter_form = forms.ProposalFilterForm(request.GET)
return super(ListProposalsView, self).dispatch(request, *args, **kwargs)
class ListMyProposalsView(ListProposalsView):
"""
A simple view that allows a user to see the discussions going on around
his/her proposal.
"""
template_name = 'reviews/my_proposals.html'
order_mapping = {
'comments': 'num_comments',
'title': 'proposal__title',
'activity': 'latest_comment_date',
}
default_order = '-activity'
@method_decorator(login_required)
def dispatch(self, request, *args, **kwargs):
self.filter_form = forms.ProposalFilterForm(request.GET)
return super(ListProposalsView, self).dispatch(request, *args, **kwargs)
def get_queryset(self):
speaker = self.request.user.speaker_profile
my_proposals = models.Proposal.current_conference.filter(speaker=speaker) \
| models.Proposal.current_conference.filter(additional_speakers=speaker)
qs = super(ListMyProposalsView, self).get_queryset()
return qs.filter(proposal__in=my_proposals)
class MyReviewsView(OrderMappingMixin, generic_views.ListView):
"""
Lists all the reviews made by the current user.
"""
model = models.Review
default_order = 'title'
order_mapping = {
'title': 'proposal__title',
'speaker': 'proposal__speaker',
'rating': 'rating',
}
def get_queryset(self):
return self.model.objects.filter(user=self.request.user) \
.order_by(self.get_order()) \
.select_related('proposal',
'proposal_version',
'proposal__kind',
'proposal__speaker') \
.only('rating', 'proposal_version',
'proposal__id', 'proposal__title',
'proposal__kind',
'proposal__speaker')
def get_template_names(self):
return ['reviews/my_reviews.html']
def get_context_data(self, *args, **kwargs):
data = super(MyReviewsView, self).get_context_data(*args, **kwargs)
data['order'] = self.get_request_order()
return data
@method_decorator(decorators.reviewer_required)
def dispatch(self, request, *args, **kwargs):
return super(MyReviewsView, self).dispatch(request, *args, **kwargs)
class SubmitReviewView(generic_views.TemplateView):
"""
Only reviewers should be able to submit reviews as long as the proposal
accepts one. The review-period should perhaps coincide with closing
the proposal for discussion.
Access: review-team
"""
# TODO: Freeze the proposal version from GET -> POST
template_name = 'reviews/submit_review_form.html'
form = None
def post(self, request, *args, **kwargs):
self.form = forms.ReviewForm(data=request.POST)
if self.form.is_valid():
review = self.form.save(commit=False)
review.proposal = self.proposal
review.proposal_version = self.proposal_version
review.user = request.user
review.save()
messages.success(request, _("Review has been saved"))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.proposal.pk}))
return self.get(request, *args, **kwargs)
def get_context_data(self, **kwargs):
if self.form is None:
self.form = forms.ReviewForm()
return {
'form': self.form,
'proposal': self.proposal,
'proposal_version': self.proposal_version,
'current_title': self.proposal_version.title if self.proposal_version else self.proposal.title,
}
@method_decorator(decorators.reviewer_required)
@method_decorator(decorators.reviews_active_required)
def dispatch(self, request, *args, **kwargs):
self.proposal = get_object_or_404(models.Proposal, pk=kwargs['pk'])
if utils.is_proposal_author(request.user, self.proposal):
return create_403(request, _("You are not allowed to review your own proposals."))
if not self.proposal.can_be_reviewed():
messages.error(request, _("This proposal can no longer be reviewed."))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.proposal.pk}))
if models.Review.objects.filter(user=request.user, proposal=self.proposal).count():
messages.info(request, _("You have already reviewed this proposal"))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.proposal.pk}))
self.proposal_version = models.ProposalVersion.objects.get_latest_for(self.proposal)
return super(SubmitReviewView, self).dispatch(request, *args, **kwargs)
class UpdateReviewView(generic_views.UpdateView):
"""
Allows a reviewer to update his/her review as long as the review period is
open.
Access: author of review
"""
model = models.Review
template_name_suffix = '_update_form'
form_class = forms.UpdateReviewForm
def get_object(self):
if hasattr(self, 'object') and self.object:
return self.object
return self.model.objects.get(user=self.request.user, proposal__pk=self.kwargs['pk'])
def form_valid(self, form):
obj = form.save(commit=False)
obj.proposal_version = models.ProposalVersion.objects.get_latest_for(self.object.proposal)
obj.save()
messages.success(self.request, _("Changes have been saved"))
return HttpResponseRedirect(self.get_success_url())
def get_context_data(self, **kwargs):
data = super(UpdateReviewView, self).get_context_data(**kwargs)
data['proposal'] = self.object.proposal
data['proposal_version'] = models.ProposalVersion.objects.get_latest_for(self.object.proposal)
data['current_title'] = data['proposal_version'].title if data['proposal_version'] else data['proposal'].title
return data
def get_success_url(self):
return reverse('reviews-proposal-details', kwargs={'pk': self.kwargs['pk']})
@method_decorator(decorators.reviewer_required)
@method_decorator(decorators.reviews_active_required)
def dispatch(self, request, *args, **kwargs):
self.request = request
self.kwargs = kwargs
self.object = self.get_object()
if not self.object.proposal.can_be_reviewed():
messages.error(request, _("This proposal can no longer be reviewed."))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.object.proposal.pk}))
if utils.is_proposal_author(request.user, self.object.proposal):
return create_403(request, _("You are not allowed to review your own proposals."))
return super(UpdateReviewView, self).dispatch(request, *args, **kwargs)
class DeleteReviewView(NextRedirectMixin, PrepareViewMixin, generic_views.DeleteView):
"""
Allows the author of a review to delete it.
Access: Author of review
"""
model = models.Review
def get_object(self):
if hasattr(self, 'object') and self.object:
return self.object
return self.model.objects.get(user=self.request.user, proposal__pk=self.kwargs['pk'])
def get_success_url(self):
next = self.get_next_redirect()
if next:
return next
return reverse('reviews-proposal-details', kwargs={'pk': self.kwargs['pk']})
def get_context_data(self, *args, **kwargs):
data = super(DeleteReviewView, self).get_context_data(*args, **kwargs)
data['next'] = self.get_success_url()
return data
def delete(self, request, *args, **kwargs):
resp = super(DeleteReviewView, self).delete(request, *args, **kwargs)
messages.success(request, _("Review has been deleted"))
return resp
@method_decorator(decorators.reviews_active_required)
@method_decorator(login_required)
def dispatch(self, request, *args, **kwargs):
self.prepare(request, *args, **kwargs)
if not self.object.proposal.can_be_reviewed():
messages.error(request, _("This proposal can no longer be reviewed."))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.object.proposal.pk}))
if utils.is_proposal_author(request.user, self.object.proposal):
return create_403(request, _("You are not allowed to review your own proposals."))
return super(DeleteReviewView, self).dispatch(request, *args, **kwargs)
class SubmitCommentView(TemplateResponseMixin, generic_views.View):
"""
Everyone on the review-team as well as the original author should be
able to comment on a proposal.
Access: speaker, co-speakers and review-team
"""
template_name = 'reviews/comment_form.html'
def get(self, request, *args, **kwargs):
if not hasattr(self, 'form') or self.form is None:
self.form = forms.CommentForm()
return self.render_to_response({
'form': self.form
})
def post(self, request, *args, **kwargs):
self.form = forms.CommentForm(data=request.POST)
if self.form.is_valid():
comment = self.form.save(commit=False)
comment.author = request.user
comment.proposal = self.proposal
comment.proposal_version = self.proposal_version
comment.save()
messages.success(request, _("Comment has been added"))
if settings.ENABLE_COMMENT_NOTIFICATIONS:
utils.send_comment_notification(comment)
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.proposal.pk}))
return self.get(request, *args, **kwargs)
@method_decorator(decorators.reviews_active_required)
@method_decorator(login_required)
def dispatch(self, request, *args, **kwargs):
self.proposal = get_object_or_404(models.Proposal, pk=kwargs['pk'])
if not utils.can_participate_in_review(request.user, self.proposal):
return create_403(request)
self.proposal_version = models.ProposalVersion.objects.get_latest_for(self.proposal)
return super(SubmitCommentView, self).dispatch(request, *args, **kwargs)
class DeleteCommentView(NextRedirectMixin, PrepareViewMixin, generic_views.DeleteView):
"""
Allows the author of a comment or a staff member to delete a review (i.e.
mark it as deleted).
Access: Author of comment and staff member
"""
model = models.Comment
def get_success_url(self):
next = self.get_next_redirect()
if next:
return next
return reverse('reviews-proposal-details', kwargs={'pk': self.kwargs['proposal_pk']})
def get_object(self, **kwargs):
if hasattr(self, 'object') and self.object:
return self.object
return self.model.objects.get(pk=self.kwargs['pk'], proposal__pk=self.kwargs['proposal_pk'])
def delete(self, *args, **kwargs):
self.object.mark_as_deleted(self.request.user)
self.object.save()
return HttpResponseRedirect(self.get_success_url())
def get_context_data(self, *args, **kwargs):
data = super(DeleteCommentView, self).get_context_data(*args, **kwargs)
data['next'] = self.get_success_url()
return data
@method_decorator(decorators.reviews_active_required)
@method_decorator(login_required)
def dispatch(self, request, *args, **kwargs):
self.prepare(request, *args, **kwargs)
if not (self.object.author == self.request.user or self.request.user.is_staff or self.request.user.is_superuser):
return create_403(request)
return super(DeleteCommentView, self).dispatch(request, *args, **kwargs)
class ProposalDetailsView(generic_views.DetailView):
"""
An extended version of the details view of the proposals app that
also includes the discussion as well as the review of the current user.
Access: author, review-team and staff (for easier comment moderation)
Template: reviews/proposal_details.html
"""
model = models.Proposal
def get_template_names(self):
return ['reviews/proposal_details.html']
def get_context_data(self, **kwargs):
comment_form = forms.CommentForm()
comment_form.helper.form_action = reverse('reviews-submit-comment', kwargs={'pk': self.object.pk})
comments = self.object.comments.select_related('proposal_version', 'author').all()
proposal_versions = self.object.versions.select_related('creator').all()
data = super(ProposalDetailsView, self).get_context_data(**kwargs)
data['comments'] = comments
data['proposal_version'] = models.ProposalVersion.objects.get_latest_for(self.object)
data['comment_form'] = comment_form
data['versions'] = proposal_versions
data['timeline'] = map(self.wrap_timeline_elements, utils.merge_comments_and_versions(comments, proposal_versions))
data['can_review'] = utils.can_review_proposal(self.request.user, self.object) and not utils.is_proposal_author(self.request.user, self.object)
data['can_update'] = utils.is_proposal_author(self.request.user, self.object)
data['can_comment'] = utils.can_participate_in_review(self.request.user, self.object) and current_conference().get_reviews_active()
try:
review = self.object.reviews.get(user=self.request.user)
data['user_review'] = review
data['review_outdated'] = review.proposal_version != data['proposal_version']
except:
pass
data['current_title'] = data['proposal_version'].title if data['proposal_version'] else self.object.title
return data
def get_object(self, queryset=None):
if hasattr(self, 'object') and self.object:
return self.object
return super(ProposalDetailsView, self).get_object(queryset)
@method_decorator(login_required)
def dispatch(self, request, *args, **kwargs):
self.request = request
self.args = args
self.kwargs = kwargs
self.object = self.get_object()
if not (utils.can_participate_in_review(self.request.user, self.object) or request.user.is_staff):
return create_403(request)
return super(ProposalDetailsView, self).dispatch(request, *args, **kwargs)
def wrap_timeline_elements(self, item):
type_ = 'comment'
user = None
if isinstance(item, models.ProposalVersion):
type_ = 'version'
user = item.creator
else:
user = item.author
return {
'type': type_,
'item': item,
'hide_author': current_conference().anonymize_proposal_author and utils.is_proposal_author(user, self.object),
}
class ProposalVersionListView(generic_views.ListView):
"""
Lists all versions of a given proposal.
Access: author of proposal and reviewer and staff
"""
model = models.ProposalVersion
proposal = None
def get_queryset(self):
if self.proposal is None:
self.proposal = models.Proposal.current_conference.get(pk=self.kwargs['proposal_pk'])
return self.model.objects.filter(original=self.proposal)
def get_context_data(self, **kwargs):
data = super(ProposalVersionListView, self).get_context_data(**kwargs)
data['original'] = models.Proposal.current_conference.get(pk=self.kwargs['proposal_pk'])
data['proposal'] = data['original']
data['proposal_version'] = models.ProposalVersion.objects.get_latest_for(data['original'])
return data
def get(self, *args, **kwargs):
self.object_list = self.get_queryset()
if not (utils.can_participate_in_review(self.request.user, self.proposal) or self.request.user.is_staff):
return create_403(_("You have to be the author of this proposal or a reviewer to access this page"))
return super(ProposalVersionListView, self).get(*args, **kwargs)
class ProposalVersionDetailsView(generic_views.DetailView):
"""
Displays details of a specific proposal version.
Access: author of proposal and reviewer and staff
"""
model = models.ProposalVersion
context_object_name = 'version'
def get_object(self):
if hasattr(self, 'object') and self.object:
return self.object
return get_object_or_404(self.model.objects.select_related('original'), pk=self.kwargs['pk'], original__pk=self.kwargs['proposal_pk'])
def get_context_data(self, **kwargs):
data = super(ProposalVersionDetailsView, self).get_context_data(**kwargs)
proposal = data['version'].original
data.update({
'proposal': proposal,
'proposal_version': models.ProposalVersion.objects.get_latest_for(proposal),
'versions': proposal.versions.select_related('creator').all()
})
return data
def get(self, request, *args, **kwargs):
self.object = self.get_object()
if not (utils.can_participate_in_review(self.request.user, self.object.original) or request.user.is_staff):
return create_403(_("You have to be the author of this proposal or a reviewer to access this page"))
return super(ProposalVersionDetailsView, self).get(request, *args, **kwargs)
class UpdateProposalView(TemplateResponseMixin, generic_views.View):
"""
This should create a new version of the proposal and notify all
contributors to the discussion so far.
Access: speaker and co-speakers
"""
template_name = 'reviews/update_proposal.html'
form = None
def get(self, request, *args, **kwargs):
if self.form is None:
if self.proposal_version:
self.form = self.get_form_class().init_from_proposal(self.proposal_version)
else:
self.form = self.get_form_class().init_from_proposal(self.object)
return self.render_to_response({
'form': self.form,
'proposal': self.object,
'proposal_version': self.proposal_version,
'current_title': self.proposal_version.title if self.proposal_version else self.object.title,
})
def post(self, request, *args, **kwargs):
self.form = self.get_form_class()(data=request.POST)
if not self.form.is_valid():
return self.get(request, *args, **kwargs)
new_version = self.form.save(commit=False)
# Set the fields we don't want people to be able to modify right now
new_version.original = self.object
new_version.creator = request.user
new_version.pub_date = now()
new_version.conference = self.object.conference
new_version.kind = self.object.kind
new_version.speaker = self.object.speaker
new_version.submission_date = self.object.submission_date
new_version.track = self.object.track
new_version.save()
new_version.additional_speakers = self.object.additional_speakers.all()
new_version.available_timeslots = self.object.available_timeslots.all()
self.form.save_m2m()
messages.success(request, _("Proposal has been successfully updated"))
if settings.ENABLE_PROPOSAL_UPDATE_NOTIFICATIONS:
utils.send_proposal_update_notification(new_version)
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.object.pk}))
@method_decorator(decorators.reviews_active_required)
def dispatch(self, request, *args, **kwargs):
self.object = get_object_or_404(models.Proposal.current_conference, pk=kwargs['pk'])
if not self.object.can_be_updated():
messages.error(request, _("Proposals can no longer be updated"))
return HttpResponseRedirect(reverse('reviews-proposal-details', kwargs={'pk': self.object.pk}))
self.proposal_version = models.ProposalVersion.objects.get_latest_for(self.object)
if not utils.is_proposal_author(request.user, self.object):
return create_403(_("You have to be the author of this review in order to access this page"))
return super(UpdateProposalView, self).dispatch(request, *args, **kwargs)
def get_form_class(self):
type_slug = self.object.kind.slug
formcls_path = settings.PROPOSAL_UPDATE_FORMS.get(type_slug)
if formcls_path:
mod_name, cls_name = formcls_path.rsplit('.', 1)
mod = import_module(mod_name)
form_cls = getattr(mod, cls_name)
if form_cls:
return form_cls
return forms.UpdateProposalForm
def get_template_names(self):
return [
'reviews/update_{0}_proposal.html'.format(self.object.kind.slug),
self.template_name
]
class ProposalReviewsView(generic_views.ListView):
"""
Provides staff members with an overview of all reviews of a proposal and its
final score.
"""
model = models.Review
def get_context_data(self, **kwargs):
data = super(ProposalReviewsView, self).get_context_data(**kwargs)
data['proposal'] = get_object_or_404(models.Proposal, pk=self.kwargs['proposal_pk'])
data['proposal_version'] = models.ProposalVersion.objects.get_latest_for(data['proposal'])
data['current_title'] = data['proposal_version'].title if data['proposal_version'] else data['proposal'].title
return data
def get_queryset(self):
return self.model.objects.filter(proposal__pk=self.kwargs['proposal_pk']).select_related('proposal_version').order_by('pub_date')
@method_decorator(staff_member_required)
def dispatch(self, request, *args, **kwargs):
return super(ProposalReviewsView, self).dispatch(request, *args, **kwargs)