Skip to content

Unused method in haystack reporter class #779

Description

@virendraagarwal

HI Team,

I found method in Haystack reporter. Ii is never used for conversion of Zipkin span to haystack span is there any specific use case for this method or it is dead code.

https://github.com/ExpediaDotCom/spring-cloud-sleuth-haystack-reporter/blob/master/src/main/java/com/expedia/www/spring/cloud/sleuth/haystack/reporter/reporters/HaystackReporter.java

private Log buildLog(Long timestamp, String key, String value) {
final Log.Builder logBuilder = Log.newBuilder();

logBuilder.setTimestamp(timestamp);
logBuilder.addFields(buildTag(key, value));

return logBuilder.build();
}

Thanks
Virendra Agarwal

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions