Skip to content

No CI workflow lints or builds the frontend on push or pull request #59

Description

@aadityat23

Problem

.github/workflows/ has backend-tests.yml and sdk-tests.yml, both scoped to their respective directories via path filters. There is no equivalent workflow for finverify-terminal/frontend/ — next lint and next build are never run automatically, so a broken build or a lint violation is only caught if a human happens to run it locally before merging.

Why this matters

The frontend is a real, deployed Next.js application (live on Vercel) with roughly 14 components and growing. Right now a PR that breaks the build or introduces an obvious lint error can merge to main undetected until the next manual deploy. This is the same gap the backend and SDK already closed for their respective directories — the frontend is the one part of the stack without any CI safety net at all.

Acceptance Criteria

  • A .github/workflows/frontend-ci.yml runs npm ci, npm run lint, and npm run build on push/PR to main, scoped via path filters to finverify-terminal/frontend/**

  • The workflow fails the check if either lint or build fails

  • Confirmed green on a test PR that touches the frontend

  • Tests added where appropriate — this issue is itself the test infrastructure

  • Documentation updated if necessary — CONTRIBUTING.md mentions the new CI check

Files likely to modify

.github/workflows/frontend-ci.yml
CONTRIBUTING.md

Skills required

GitHub Actions, Next.js, npm

Estimated difficulty

2/5

Estimated effort

2–4 hours

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions